From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: linux-scsi@vger.kernel.org, Yang Yingliang <yangyingliang@huawei.com>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>, jejb@linux.ibm.com
Subject: Re: [PATCH] scsi: scsi_debug: fix possible name leak in sdebug_add_host_helper()
Date: Thu, 1 Dec 2022 03:45:29 +0000 [thread overview]
Message-ID: <166986602284.2101055.6946595367935631373.b4-ty@oracle.com> (raw)
In-Reply-To: <20221112131010.3757845-1-yangyingliang@huawei.com>
On Sat, 12 Nov 2022 21:10:10 +0800, Yang Yingliang wrote:
> Afer commit 1fa5ae857bb1 ("driver core: get rid of struct device's
> bus_id string array"), the name of device is allocated dynamically,
> it needs be freed, when device_register() returns error.
>
> As comment of device_register() says, it should use put_device()
> to give up the reference in the error path. So fix this by calling
> put_device(), then the name can be freed in kobject_cleanup(), and
> sdbg_host is freed in sdebug_release_adapter().
>
> [...]
Applied to 6.2/scsi-queue, thanks!
[1/1] scsi: scsi_debug: fix possible name leak in sdebug_add_host_helper()
https://git.kernel.org/mkp/scsi/c/e6d773f93a49
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2022-12-01 3:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-12 13:10 [PATCH] scsi: scsi_debug: fix possible name leak in sdebug_add_host_helper() Yang Yingliang
2022-11-26 0:20 ` Martin K. Petersen
2022-12-01 3:45 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166986602284.2101055.6946595367935631373.b4-ty@oracle.com \
--to=martin.petersen@oracle.com \
--cc=jejb@linux.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).