From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: jejb@linux.ibm.com, nmusini@cisco.com, sebaddel@cisco.com,
Gaosheng Cui <cuigaosheng1@huawei.com>,
JBottomley@Odin.com, kartilak@cisco.com, hare@suse.de
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi: snic: Fix possible UAF in snic_tgt_create
Date: Thu, 1 Dec 2022 03:45:06 +0000 [thread overview]
Message-ID: <166986602290.2101055.12272748018432463980.b4-ty@oracle.com> (raw)
In-Reply-To: <20221117035100.2944812-1-cuigaosheng1@huawei.com>
On Thu, 17 Nov 2022 11:51:00 +0800, Gaosheng Cui wrote:
> Smatch report warning as follows:
>
> drivers/scsi/snic/snic_disc.c:307 snic_tgt_create() warn:
> '&tgt->list' not removed from list
>
> If device_add() fails in snic_tgt_create(), tgt will be freed, but
> tgt->list will not be removed from snic->disc.tgt_list, then list
> traversal may cause UAF.
>
> [...]
Applied to 6.2/scsi-queue, thanks!
[1/1] scsi: snic: Fix possible UAF in snic_tgt_create
https://git.kernel.org/mkp/scsi/c/e118df492320
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2022-12-01 3:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 3:51 [PATCH] scsi: snic: Fix possible UAF in snic_tgt_create Gaosheng Cui
2022-11-26 0:31 ` Martin K. Petersen
2022-12-01 3:45 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166986602290.2101055.12272748018432463980.b4-ty@oracle.com \
--to=martin.petersen@oracle.com \
--cc=JBottomley@Odin.com \
--cc=cuigaosheng1@huawei.com \
--cc=hare@suse.de \
--cc=jejb@linux.ibm.com \
--cc=kartilak@cisco.com \
--cc=linux-scsi@vger.kernel.org \
--cc=nmusini@cisco.com \
--cc=sebaddel@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).