From: Himanshu Madhani <himanshu.madhani@oracle.com>
To: Shubhankar Kuranagatti <shubhankarvk@gmail.com>
Cc: Martin Petersen <martin.petersen@oracle.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"target-devel@vger.kernel.org" <target-devel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers: target: target_core_pr.c: Fix tabspace error
Date: Tue, 20 Apr 2021 14:48:05 +0000 [thread overview]
Message-ID: <1A81A74B-DCA1-482C-8444-EAD143D432F7@oracle.com> (raw)
In-Reply-To: <20210420122846.gjh6pmzz2w37tqc5@kewl-virtual-machine>
> On Apr 20, 2021, at 7:28 AM, Shubhankar Kuranagatti <shubhankarvk@gmail.com> wrote:
>
> Tabs have been used to replace spaces.
> This is done to maintain code uniformity.
>
> Signed-off-by: Shubhankar Kuranagatti <shubhankarvk@gmail.com>
> ---
> drivers/target/target_core_pr.c | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/target/target_core_pr.c b/drivers/target/target_core_pr.c
> index d4cc43afe05b..6538b2be1634 100644
> --- a/drivers/target/target_core_pr.c
> +++ b/drivers/target/target_core_pr.c
> @@ -539,18 +539,18 @@ static int core_scsi3_pr_seq_non_holder(struct se_cmd *cmd, u32 pr_reg_type,
> return 0;
> }
> } else if (we && registered_nexus) {
> - /*
> - * Reads are allowed for Write Exclusive locks
> - * from all registrants.
> - */
> - if (cmd->data_direction == DMA_FROM_DEVICE) {
> - pr_debug("Allowing READ CDB: 0x%02x for %s"
> - " reservation\n", cdb[0],
> - core_scsi3_pr_dump_type(pr_reg_type));
> -
> - return 0;
> - }
> - }
> + /*
> + * Reads are allowed for Write Exclusive locks
> + * from all registrants.
> + */
> + if (cmd->data_direction == DMA_FROM_DEVICE) {
> + pr_debug("Allowing READ CDB: 0x%02x for %s"
> + " reservation\n", cdb[0],
> + core_scsi3_pr_dump_type(pr_reg_type));
> +
> + return 0;
> + }
> + }
this last one has one too many tab.
> pr_debug("%s Conflict for %sregistered nexus %s CDB: 0x%2x"
> " for %s reservation\n", transport_dump_cmd_direction(cmd),
> (registered_nexus) ? "" : "un",
> --
> 2.17.1
>
--
Himanshu Madhani Oracle Linux Engineering
prev parent reply other threads:[~2021-04-20 14:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 12:28 [PATCH] drivers: target: target_core_pr.c: Fix tabspace error Shubhankar Kuranagatti
2021-04-20 14:48 ` Himanshu Madhani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1A81A74B-DCA1-482C-8444-EAD143D432F7@oracle.com \
--to=himanshu.madhani@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=shubhankarvk@gmail.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).