From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E594BC31E40 for ; Mon, 12 Aug 2019 14:23:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AAE0B206DF for ; Mon, 12 Aug 2019 14:23:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="lX5ak2Xq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727764AbfHLOXN (ORCPT ); Mon, 12 Aug 2019 10:23:13 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:43938 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726702AbfHLOXN (ORCPT ); Mon, 12 Aug 2019 10:23:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=JC9bjRjuIitXlaEbE5ucjUB4Dfb3oO6G8MrnTPUb1J4=; b=lX5ak2XqD+ggQsKs9z4THC9og dS2wUYhSN+GT7/ohMUSb+MG7LIvfrHMTOcd1m8m+fjXM/XvN8AiPJhRtTv+FPByBbLtflmRRMcrQp w4QRF2mrNHrRXRfXvrbkTnM1bMcjAkwOrmU64upy5a2OQfnM19Ts1ipTVyP4m6GusGGf9TNYsXQyV O3HWf1zfTWfSjqT/PARL6B5LyZLQ/GNESrUoRlmfMOvz/7yDxhQFlPZz72rjE/pAvfH+r6n5Wq8aL J4uIhDQWbnOvni0ENGL68k/iBQErRNTN4KrVAlHIEEQCzFgcInGX8oTr5YZmZJKLoo8hoPEOgPajN bNZsc2f2w==; Received: from hch by bombadil.infradead.org with local (Exim 4.92 #3 (Red Hat Linux)) id 1hxBE8-0002tc-PC; Mon, 12 Aug 2019 14:23:12 +0000 Date: Mon, 12 Aug 2019 07:23:12 -0700 From: Christoph Hellwig To: Douglas Gilbert Cc: linux-scsi@vger.kernel.org, martin.petersen@oracle.com, jejb@linux.vnet.ibm.com, hare@suse.de, bvanassche@acm.org Subject: Re: [PATCH v3 04/20] sg: rework sg_poll(), minor changes Message-ID: <20190812142312.GD8105@infradead.org> References: <20190807114252.2565-1-dgilbert@interlog.com> <20190807114252.2565-5-dgilbert@interlog.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190807114252.2565-5-dgilbert@interlog.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On Wed, Aug 07, 2019 at 01:42:36PM +0200, Douglas Gilbert wrote: > Re-arrange code in sg_poll(). Rename sg_read_oxfer() to > sg_rd_append(). In sg_start_req() rename rw to r0w. > Plus associated changes demanded by checkpatch.pl r0w seems like a really odd variably name that doesn't help readability. Also all these changes seem independent from each other to me, so they should be split into multiple patches.