Linux-SCSI Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 1/1] scsi: lpfc: Convert existing %pf users to %ps
@ 2019-09-04 16:04 Sakari Ailus
  2019-09-04 17:23 ` Andy Shevchenko
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Sakari Ailus @ 2019-09-04 16:04 UTC (permalink / raw)
  To: James Smart, Dick Kennedy
  Cc: linux-scsi, Joe Perches, Petr Mladek, linux-kernel, rafael,
	Andy Shevchenko, Heikki Krogerus

Convert the remaining %pf users to %ps to prepare for the removal of the
old %pf conversion specifier support.

Fixes: 323506644972 ("scsi: lpfc: Migrate to %px and %pf in kernel print calls")
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
 drivers/scsi/lpfc/lpfc_hbadisc.c | 4 ++--
 drivers/scsi/lpfc/lpfc_sli.c     | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c
index e7463d561f305..749286acdc173 100644
--- a/drivers/scsi/lpfc/lpfc_hbadisc.c
+++ b/drivers/scsi/lpfc/lpfc_hbadisc.c
@@ -6051,7 +6051,7 @@ __lpfc_find_node(struct lpfc_vport *vport, node_filter filter, void *param)
 	list_for_each_entry(ndlp, &vport->fc_nodes, nlp_listp) {
 		if (filter(ndlp, param)) {
 			lpfc_printf_vlog(vport, KERN_INFO, LOG_NODE,
-					 "3185 FIND node filter %pf DID "
+					 "3185 FIND node filter %ps DID "
 					 "ndlp x%px did x%x flg x%x st x%x "
 					 "xri x%x type x%x rpi x%x\n",
 					 filter, ndlp, ndlp->nlp_DID,
@@ -6062,7 +6062,7 @@ __lpfc_find_node(struct lpfc_vport *vport, node_filter filter, void *param)
 		}
 	}
 	lpfc_printf_vlog(vport, KERN_INFO, LOG_NODE,
-			 "3186 FIND node filter %pf NOT FOUND.\n", filter);
+			 "3186 FIND node filter %ps NOT FOUND.\n", filter);
 	return NULL;
 }
 
diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
index bb5705267c395..2ff0879a95126 100644
--- a/drivers/scsi/lpfc/lpfc_sli.c
+++ b/drivers/scsi/lpfc/lpfc_sli.c
@@ -2712,7 +2712,7 @@ lpfc_sli_handle_mb_event(struct lpfc_hba *phba)
 
 		/* Mailbox cmd <cmd> Cmpl <cmpl> */
 		lpfc_printf_log(phba, KERN_INFO, LOG_MBOX | LOG_SLI,
-				"(%d):0307 Mailbox cmd x%x (x%x/x%x) Cmpl %pf "
+				"(%d):0307 Mailbox cmd x%x (x%x/x%x) Cmpl %ps "
 				"Data: x%x x%x x%x x%x x%x x%x x%x x%x x%x "
 				"x%x x%x x%x\n",
 				pmb->vport ? pmb->vport->vpi : 0,
-- 
2.20.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/1] scsi: lpfc: Convert existing %pf users to %ps
  2019-09-04 16:04 [PATCH 1/1] scsi: lpfc: Convert existing %pf users to %ps Sakari Ailus
@ 2019-09-04 17:23 ` Andy Shevchenko
  2019-09-04 20:22 ` James Smart
  2019-09-07 20:27 ` Martin K. Petersen
  2 siblings, 0 replies; 5+ messages in thread
From: Andy Shevchenko @ 2019-09-04 17:23 UTC (permalink / raw)
  To: Sakari Ailus
  Cc: James Smart, Dick Kennedy, linux-scsi, Joe Perches, Petr Mladek,
	linux-kernel, rafael, Heikki Krogerus

On Wed, Sep 04, 2019 at 07:04:23PM +0300, Sakari Ailus wrote:
> Convert the remaining %pf users to %ps to prepare for the removal of the
> old %pf conversion specifier support.

FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> Fixes: 323506644972 ("scsi: lpfc: Migrate to %px and %pf in kernel print calls")
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
>  drivers/scsi/lpfc/lpfc_hbadisc.c | 4 ++--
>  drivers/scsi/lpfc/lpfc_sli.c     | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c
> index e7463d561f305..749286acdc173 100644
> --- a/drivers/scsi/lpfc/lpfc_hbadisc.c
> +++ b/drivers/scsi/lpfc/lpfc_hbadisc.c
> @@ -6051,7 +6051,7 @@ __lpfc_find_node(struct lpfc_vport *vport, node_filter filter, void *param)
>  	list_for_each_entry(ndlp, &vport->fc_nodes, nlp_listp) {
>  		if (filter(ndlp, param)) {
>  			lpfc_printf_vlog(vport, KERN_INFO, LOG_NODE,
> -					 "3185 FIND node filter %pf DID "
> +					 "3185 FIND node filter %ps DID "
>  					 "ndlp x%px did x%x flg x%x st x%x "
>  					 "xri x%x type x%x rpi x%x\n",
>  					 filter, ndlp, ndlp->nlp_DID,
> @@ -6062,7 +6062,7 @@ __lpfc_find_node(struct lpfc_vport *vport, node_filter filter, void *param)
>  		}
>  	}
>  	lpfc_printf_vlog(vport, KERN_INFO, LOG_NODE,
> -			 "3186 FIND node filter %pf NOT FOUND.\n", filter);
> +			 "3186 FIND node filter %ps NOT FOUND.\n", filter);
>  	return NULL;
>  }
>  
> diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
> index bb5705267c395..2ff0879a95126 100644
> --- a/drivers/scsi/lpfc/lpfc_sli.c
> +++ b/drivers/scsi/lpfc/lpfc_sli.c
> @@ -2712,7 +2712,7 @@ lpfc_sli_handle_mb_event(struct lpfc_hba *phba)
>  
>  		/* Mailbox cmd <cmd> Cmpl <cmpl> */
>  		lpfc_printf_log(phba, KERN_INFO, LOG_MBOX | LOG_SLI,
> -				"(%d):0307 Mailbox cmd x%x (x%x/x%x) Cmpl %pf "
> +				"(%d):0307 Mailbox cmd x%x (x%x/x%x) Cmpl %ps "
>  				"Data: x%x x%x x%x x%x x%x x%x x%x x%x x%x "
>  				"x%x x%x x%x\n",
>  				pmb->vport ? pmb->vport->vpi : 0,
> -- 
> 2.20.1
> 

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/1] scsi: lpfc: Convert existing %pf users to %ps
  2019-09-04 16:04 [PATCH 1/1] scsi: lpfc: Convert existing %pf users to %ps Sakari Ailus
  2019-09-04 17:23 ` Andy Shevchenko
@ 2019-09-04 20:22 ` James Smart
  2019-09-07 20:27 ` Martin K. Petersen
  2 siblings, 0 replies; 5+ messages in thread
From: James Smart @ 2019-09-04 20:22 UTC (permalink / raw)
  To: Sakari Ailus, Dick Kennedy
  Cc: linux-scsi, Joe Perches, Petr Mladek, linux-kernel, rafael,
	Andy Shevchenko, Heikki Krogerus

On 9/4/2019 9:04 AM, Sakari Ailus wrote:
> Convert the remaining %pf users to %ps to prepare for the removal of the
> old %pf conversion specifier support.
>
> Fixes: 323506644972 ("scsi: lpfc: Migrate to %px and %pf in kernel print calls")
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
>   drivers/scsi/lpfc/lpfc_hbadisc.c | 4 ++--
>   drivers/scsi/lpfc/lpfc_sli.c     | 2 +-
>   2 files changed, 3 insertions(+), 3 deletions(-)
>
>

Reviewed by: James Smart <james.smart@broadcom.com>

-- james



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/1] scsi: lpfc: Convert existing %pf users to %ps
  2019-09-04 16:04 [PATCH 1/1] scsi: lpfc: Convert existing %pf users to %ps Sakari Ailus
  2019-09-04 17:23 ` Andy Shevchenko
  2019-09-04 20:22 ` James Smart
@ 2019-09-07 20:27 ` Martin K. Petersen
  2019-09-09 13:22   ` Sakari Ailus
  2 siblings, 1 reply; 5+ messages in thread
From: Martin K. Petersen @ 2019-09-07 20:27 UTC (permalink / raw)
  To: Sakari Ailus
  Cc: James Smart, Dick Kennedy, linux-scsi, Joe Perches, Petr Mladek,
	linux-kernel, rafael, Andy Shevchenko, Heikki Krogerus


Sakari,

> Convert the remaining %pf users to %ps to prepare for the removal of
> the old %pf conversion specifier support.

Applied to 5.4/scsi-queue, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/1] scsi: lpfc: Convert existing %pf users to %ps
  2019-09-07 20:27 ` Martin K. Petersen
@ 2019-09-09 13:22   ` Sakari Ailus
  0 siblings, 0 replies; 5+ messages in thread
From: Sakari Ailus @ 2019-09-09 13:22 UTC (permalink / raw)
  To: Martin K. Petersen
  Cc: James Smart, Dick Kennedy, linux-scsi, Joe Perches, Petr Mladek,
	linux-kernel, rafael, Andy Shevchenko, Heikki Krogerus

On Sat, Sep 07, 2019 at 04:27:34PM -0400, Martin K. Petersen wrote:
> 
> Sakari,
> 
> > Convert the remaining %pf users to %ps to prepare for the removal of
> > the old %pf conversion specifier support.
> 
> Applied to 5.4/scsi-queue, thanks!

Thanks, Martin!

-- 
Sakari Ailus
sakari.ailus@linux.intel.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-04 16:04 [PATCH 1/1] scsi: lpfc: Convert existing %pf users to %ps Sakari Ailus
2019-09-04 17:23 ` Andy Shevchenko
2019-09-04 20:22 ` James Smart
2019-09-07 20:27 ` Martin K. Petersen
2019-09-09 13:22   ` Sakari Ailus

Linux-SCSI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-scsi/0 linux-scsi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-scsi linux-scsi/ https://lore.kernel.org/linux-scsi \
		linux-scsi@vger.kernel.org linux-scsi@archiver.kernel.org
	public-inbox-index linux-scsi


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-scsi


AGPL code for this site: git clone https://public-inbox.org/ public-inbox