linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Roman Bolshakov <r.bolshakov@yadro.com>
To: Himanshu Madhani <hmadhani@marvell.com>
Cc: <James.Bottomley@HansenPartnership.com>,
	<martin.petersen@oracle.com>, <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 07/14] qla2xxx: Fix Nport ID display value
Date: Thu, 12 Sep 2019 19:55:28 +0300	[thread overview]
Message-ID: <20190912165528.pbe5wip7ywst3x6a@SPB-NB-133.local> (raw)
In-Reply-To: <20190912151949.2348-8-hmadhani@marvell.com>

On Thu, Sep 12, 2019 at 08:19:42AM -0700, Himanshu Madhani wrote:
> From: Quinn Tran <qutran@marvell.com>
> 
> For N2N, the NPort ID is assigned by driver in the PLOGI ELS.
> According to FW Spec the byte order for SID is not the same as
> DID.
> 
> Signed-off-by: Quinn Tran <qutran@marvell.com>
> Signed-off-by: Himanshu Madhani <hmadhani@marvell.com>
> ---
>  drivers/scsi/qla2xxx/qla_iocb.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_iocb.c b/drivers/scsi/qla2xxx/qla_iocb.c
> index 1886de92034c..5c279449ca1c 100644
> --- a/drivers/scsi/qla2xxx/qla_iocb.c
> +++ b/drivers/scsi/qla2xxx/qla_iocb.c
> @@ -2696,9 +2696,10 @@ qla24xx_els_logo_iocb(srb_t *sp, struct els_entry_24xx *els_iocb)
>  	els_iocb->port_id[0] = sp->fcport->d_id.b.al_pa;
>  	els_iocb->port_id[1] = sp->fcport->d_id.b.area;
>  	els_iocb->port_id[2] = sp->fcport->d_id.b.domain;
> -	els_iocb->s_id[0] = vha->d_id.b.al_pa;
> -	els_iocb->s_id[1] = vha->d_id.b.area;
> -	els_iocb->s_id[2] = vha->d_id.b.domain;
> +	/* For SID the byte order is different than DID */
> +	els_iocb->s_id[1] = vha->d_id.b.al_pa;
> +	els_iocb->s_id[2] = vha->d_id.b.area;
> +	els_iocb->s_id[0] = vha->d_id.b.domain;
>  	els_iocb->control_flags = 0;
>  
>  	if (elsio->u.els_logo.els_cmd == ELS_DCMD_PLOGI) {
> -- 
> 2.12.0
> 

Hi,

This one doesn't apply to 5.4/scsi-queue, the hunk lines should be:
@@ -2656,9 +2656,10 @@

Best regards,
Roman

  reply	other threads:[~2019-09-12 16:55 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-12 15:19 [PATCH 00/14] qla2xxx: Bug fixes for the driver Himanshu Madhani
2019-09-12 15:19 ` [PATCH 01/14] qla2xxx: Silence fwdump template message Himanshu Madhani
2019-09-12 15:19 ` [PATCH 02/14] qla2xxx: Fix unbound sleep in fcport delete path Himanshu Madhani
2019-09-12 15:19 ` [PATCH 03/14] qla2xxx: Fix stale mem access on driver unload Himanshu Madhani
2019-09-12 15:19 ` [PATCH 04/14] qla2xxx: Optimize NPIV tear down process Himanshu Madhani
2019-09-12 15:19 ` [PATCH 05/14] qla2xxx: Fix N2N link reset Himanshu Madhani
2019-09-12 15:19 ` [PATCH 06/14] qla2xxx: Fix N2N link up fail Himanshu Madhani
2019-09-12 15:19 ` [PATCH 07/14] qla2xxx: Fix Nport ID display value Himanshu Madhani
2019-09-12 16:55   ` Roman Bolshakov [this message]
2019-09-12 17:23     ` [EXT] " Himanshu Madhani
2019-09-12 15:19 ` [PATCH 08/14] qla2xxx: Dual FCP-NVMe target port support Himanshu Madhani
2019-09-12 15:19 ` [PATCH 09/14] qla2xxx: Add error handling for PLOGI ELS passthrough Himanshu Madhani
2019-09-12 15:19 ` [PATCH 10/14] qla2xxx: Set remove flag for all VP Himanshu Madhani
2019-09-12 15:19 ` [PATCH 11/14] qla2xxx: Check for MB timeout while capturing ISP27/28xx FW dump Himanshu Madhani
2019-09-12 15:19 ` [PATCH 12/14] qla2xxx: Capture FW dump on MPI heartbeat stop event Himanshu Madhani
2019-09-12 15:19 ` [PATCH 13/14] qla2xxx: Improve logging for scan thread Himanshu Madhani
2019-09-12 15:19 ` [PATCH 14/14] qla2xxx: Update driver version to 10.01.00.20-k Himanshu Madhani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190912165528.pbe5wip7ywst3x6a@SPB-NB-133.local \
    --to=r.bolshakov@yadro.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=hmadhani@marvell.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).