From: Rob Herring <robh@kernel.org>
To: Vignesh Raghavendra <vigneshr@ti.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
jejb@linux.ibm.com,
Martin K Petersen <martin.petersen@oracle.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
Pedro Sousa <pedrom.sousa@synopsys.com>,
Janek Kotas <jank@cadence.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org, nsekhar@ti.com
Subject: Re: [PATCH 1/2] dt-bindings: ufs: ti,j721e-ufs.yaml: Add binding for TI UFS wrapper
Date: Tue, 1 Oct 2019 07:08:26 -0500 [thread overview]
Message-ID: <20191001120826.GA4214@bogus> (raw)
In-Reply-To: <20190918133921.25844-2-vigneshr@ti.com>
On Wed, Sep 18, 2019 at 07:09:20PM +0530, Vignesh Raghavendra wrote:
> Add binding documentation of TI wrapper for Cadence UFS Controller.
>
> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
> ---
> .../devicetree/bindings/ufs/ti,j721e-ufs.yaml | 45 +++++++++++++++++++
> 1 file changed, 45 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/ufs/ti,j721e-ufs.yaml
>
> diff --git a/Documentation/devicetree/bindings/ufs/ti,j721e-ufs.yaml b/Documentation/devicetree/bindings/ufs/ti,j721e-ufs.yaml
> new file mode 100644
> index 000000000000..dabd7c795fbe
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/ufs/ti,j721e-ufs.yaml
> @@ -0,0 +1,45 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/ufs/ti,j721e-ufs.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TI J721e UFS Host Controller Glue Driver
> +
> +maintainers:
> + - Vignesh Raghavendra <vigneshr@ti.com>
> +
> +properties:
> + compatible:
> + items:
> + - const: ti,j721e-ufs
> +
> + reg:
> + maxItems: 1
> + description: address of TI UFS glue registers
> +
> + clocks:
> + maxItems: 1
> + description: phandle to the M-PHY clock
> +
> + power-domains:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - power-domains
> +
> +examples:
> + - |
> + ufs_wrapper: ufs-wrapper@4e80000 {
> + compatible = "ti,j721e-ufs";
> + reg = <0x0 0x4e80000 0x0 0x100>;
> + power-domains = <&k3_pds 277>;
> + clocks = <&k3_clks 277 1>;
> + assigned-clocks = <&k3_clks 277 1>;
> + assigned-clock-parents = <&k3_clks 277 4>;
> + #address-cells = <2>;
> + #size-cells = <2>;
Based on the driver you expect to have a child node here with the UFS
controller? You need to show that and have a schema for it.
> + };
> --
> 2.23.0
>
next prev parent reply other threads:[~2019-10-01 12:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 13:39 [PATCH 0/2] scsi: ufs: Add driver for TI wrapper for Cadence UFS IP Vignesh Raghavendra
2019-09-18 13:39 ` [PATCH 1/2] dt-bindings: ufs: ti,j721e-ufs.yaml: Add binding for TI UFS wrapper Vignesh Raghavendra
2019-10-01 12:08 ` Rob Herring [this message]
2019-10-01 12:18 ` Vignesh Raghavendra
2019-10-03 21:56 ` Rob Herring
2019-09-18 13:39 ` [PATCH 2/2] scsi: ufs: Add driver for TI wrapper for Cadence UFS IP Vignesh Raghavendra
2019-10-01 3:57 ` [PATCH 0/2] " Martin K. Petersen
2019-10-01 8:08 ` Vignesh Raghavendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191001120826.GA4214@bogus \
--to=robh@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=devicetree@vger.kernel.org \
--cc=jank@cadence.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martin.petersen@oracle.com \
--cc=nsekhar@ti.com \
--cc=pedrom.sousa@synopsys.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).