* [PATCH -next] scsi: csiostor: Remove set but not used variable 'rln'
@ 2019-10-29 6:15 YueHaibing
2019-11-13 2:29 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-10-29 6:15 UTC (permalink / raw)
To: James E . J . Bottomley, Martin K. Petersen, Dan Carpenter
Cc: YueHaibing, linux-scsi, linux-kernel, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/scsi/csiostor/csio_lnode.c: In function 'csio_ln_init':
drivers/scsi/csiostor/csio_lnode.c:1995:21: warning:
variable 'rln' set but not used [-Wunused-but-set-variable]
It is never used since introduction, so remove it.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/scsi/csiostor/csio_lnode.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/csiostor/csio_lnode.c b/drivers/scsi/csiostor/csio_lnode.c
index 23cbe4cda760..74ff8adc41f7 100644
--- a/drivers/scsi/csiostor/csio_lnode.c
+++ b/drivers/scsi/csiostor/csio_lnode.c
@@ -1992,7 +1992,7 @@ static int
csio_ln_init(struct csio_lnode *ln)
{
int rv = -EINVAL;
- struct csio_lnode *rln, *pln;
+ struct csio_lnode *pln;
struct csio_hw *hw = csio_lnode_to_hw(ln);
csio_init_state(&ln->sm, csio_lns_uninit);
@@ -2022,7 +2022,6 @@ csio_ln_init(struct csio_lnode *ln)
* THe rest is common for non-root physical and NPIV lnodes.
* Just get references to all other modules
*/
- rln = csio_root_lnode(ln);
if (csio_is_npiv_ln(ln)) {
/* NPIV */
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] scsi: csiostor: Remove set but not used variable 'rln'
2019-10-29 6:15 [PATCH -next] scsi: csiostor: Remove set but not used variable 'rln' YueHaibing
@ 2019-11-13 2:29 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2019-11-13 2:29 UTC (permalink / raw)
To: YueHaibing
Cc: James E . J . Bottomley, Martin K. Petersen, Dan Carpenter,
linux-scsi, linux-kernel, kernel-janitors
YueHaibing,
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/csiostor/csio_lnode.c: In function 'csio_ln_init':
> drivers/scsi/csiostor/csio_lnode.c:1995:21: warning:
> variable 'rln' set but not used [-Wunused-but-set-variable]
>
> It is never used since introduction, so remove it.
Applied to 5.5/scsi-queue, thanks.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-13 2:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-29 6:15 [PATCH -next] scsi: csiostor: Remove set but not used variable 'rln' YueHaibing
2019-11-13 2:29 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).