From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C674FC43331 for ; Sun, 10 Nov 2019 02:45:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9281D215EA for ; Sun, 10 Nov 2019 02:45:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573353913; bh=FsKtONwnJ0E+3juQFQYvpQtt820kG0TE5BDmYoercLA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=gwEPHqjsCCLMUJeNQFqZjaIZ1dSthwnt/yQ//HPgFhVq01SEeEUgIb5wkVr3fWeZA /nFTp6lLX7/FMzYYG/tB1Fw/oD7+c/RGHTbaMDM2n7wBFuJ3eVnkk4BGHjps0tMeLw 2wfSE34eShnu5w+hrQI6/Eug2xwFLjgNl22D1pN4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728757AbfKJCpM (ORCPT ); Sat, 9 Nov 2019 21:45:12 -0500 Received: from mail.kernel.org ([198.145.29.99]:46094 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727104AbfKJCpM (ORCPT ); Sat, 9 Nov 2019 21:45:12 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D2B3521D7E; Sun, 10 Nov 2019 02:45:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573353911; bh=FsKtONwnJ0E+3juQFQYvpQtt820kG0TE5BDmYoercLA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AvqADmnaK5GnSbvtR9G4lNkj8QV0hiR6RFa9FXtNaSuocC8AaJtqWOUi1rh9JE5+C DLEHPWORjAoGOpo1DkgXJ09CX0Tl+Nqf5oCVkRkBE0byk3/CS3I2JxeQROnoYVAOTH 9D3BWHXoU55otZqy84ujQXub9I2dQHawx7f+uSAQ= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Finn Thain , Michael Schmitz , "Martin K . Petersen" , Sasha Levin , linux-scsi@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 175/191] scsi: NCR5380: Handle BUS FREE during reselection Date: Sat, 9 Nov 2019 21:39:57 -0500 Message-Id: <20191110024013.29782-175-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191110024013.29782-1-sashal@kernel.org> References: <20191110024013.29782-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org From: Finn Thain [ Upstream commit ca694afad707cb3ae2fdef3b28454444d9ac726e ] The X3T9.2 specification (draft) says, under "6.1.4.2 RESELECTION time-out procedure", that a target may assert RST or go to BUS FREE phase if the initiator does not respond within 200 us. Something like this has been observed with AztecMonster II target. When it happens, all we can do is wait for the target to try again. Tested-by: Michael Schmitz Signed-off-by: Finn Thain Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/NCR5380.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/NCR5380.c b/drivers/scsi/NCR5380.c index 5c3ffb466bb10..bce6c990d060a 100644 --- a/drivers/scsi/NCR5380.c +++ b/drivers/scsi/NCR5380.c @@ -2039,6 +2039,9 @@ static void NCR5380_reselect(struct Scsi_Host *instance) if (NCR5380_poll_politely(hostdata, STATUS_REG, SR_REQ, SR_REQ, 2 * HZ) < 0) { + if ((NCR5380_read(STATUS_REG) & (SR_BSY | SR_SEL)) == 0) + /* BUS FREE phase */ + return; shost_printk(KERN_ERR, instance, "reselect: REQ timeout\n"); do_abort(instance); return; -- 2.20.1