linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Roman Bolshakov <r.bolshakov@yadro.com>
To: Himanshu Madhani <hmadhani@marvell.com>
Cc: Bart Van Assche <bvanassche@acm.org>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	Quinn Tran <qutran@marvell.com>
Subject: Re: [EXT] [PATCH 0/4] scsi: qla2xxx: Bug fixes
Date: Wed, 20 Nov 2019 03:09:38 +0300	[thread overview]
Message-ID: <20191120000938.vy7o2znyj4lpnpan@SPB-NB-133.local> (raw)
In-Reply-To: <20191119214656.t2rluirv5kgzl6vg@SPB-NB-133.local>

On Wed, Nov 20, 2019 at 12:46:56AM +0300, Roman Bolshakov wrote:
> Hi Himanshu,
> 
> I've tried the patch and it seems that LOGO doesn't succeed yet:
> [ 1079.073246] qla2xxx [0000:00:06.0]-2870:1: Async-logout - hdl=0 loop-id=0 portid=000002 21:00:00:24:ff:7f:35:c6.
> [ 1079.073333] qla2xxx [0000:00:06.0]-5837:1: Async-logout failed - 21:00:00:24:ff:7f:35:c6 hdl=12 portid=000002 comp=31 iop0=19 iop1=c.
> 
> It means that firmware detected IOCB parameter error at offset 0xc.
> I'll examine IOCB parameter dumps tomorrow.
> 

FWIW, it was an easy fix, we have to set either explicit LOGO bit or implicit
LOGO bit. Free N_Port handle is not allowed to be set alone. I corrected
the patch:
https://github.com/roolebo/linux/commit/6e86300a60552bfc0a4c49d65d89e5011dd90f10

--
Roman

      reply	other threads:[~2019-11-20  0:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-12  0:39 [PATCH 0/4] scsi: qla2xxx: Bug fixes Roman Bolshakov
2019-09-12  0:39 ` [PATCH 1/4] scsi: qla2xxx: Ignore NULL pointer in tcm_qla2xxx_free_mcmd Roman Bolshakov
2019-09-12  0:39 ` [PATCH 2/4] scsi: qla2xxx: Initialize free_work before flushing it Roman Bolshakov
2019-09-12  0:39 ` [PATCH 3/4] scsi: qla2xxx: Drop superfluous INIT_WORK of del_work Roman Bolshakov
2019-09-12  0:39 ` [PATCH 4/4] scsi: qla2xxx: Change discovery state before PLOGI Roman Bolshakov
2019-09-12  5:37 ` [PATCH 0/4] scsi: qla2xxx: Bug fixes Bart Van Assche
2019-09-12 13:49   ` Roman Bolshakov
2019-09-12 13:53     ` Himanshu Madhani
2019-11-07 19:00       ` Roman Bolshakov
2019-11-13 18:54         ` Roman Bolshakov
     [not found]           ` <0B40AFCA-8CB0-4F21-BDD1-DFE7A66DAA07@marvell.com>
2019-11-19 21:46             ` [EXT] " Roman Bolshakov
2019-11-20  0:09               ` Roman Bolshakov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191120000938.vy7o2znyj4lpnpan@SPB-NB-133.local \
    --to=r.bolshakov@yadro.com \
    --cc=bvanassche@acm.org \
    --cc=hmadhani@marvell.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=qutran@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).