From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBF9CC2D0C0 for ; Fri, 20 Dec 2019 14:48:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 975C3222C2 for ; Fri, 20 Dec 2019 14:48:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576853306; bh=TGOFOEaM02eSycs8ivW3/kTi++LLIwg1K09ilHSMG3k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=lTPvJrjYb3NJdP5wuacBvbU64+aE2cut2JkIJ2JkemQI8yP7lIUblGZQb+Fpi7bdX e45EJOt/7bteDcymZDs4fO1C/lp91sPuqxV4yBGsApBXr05HRi9s+vuFmn2wxEuSO1 lEXncG18qE+n4d1Yb3vs2z2tTyeS1gr1Nn5piahY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727874AbfLTOsW (ORCPT ); Fri, 20 Dec 2019 09:48:22 -0500 Received: from mail.kernel.org ([198.145.29.99]:46246 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727852AbfLTOrv (ORCPT ); Fri, 20 Dec 2019 09:47:51 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3AA7E21D7E; Fri, 20 Dec 2019 14:47:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576853270; bh=TGOFOEaM02eSycs8ivW3/kTi++LLIwg1K09ilHSMG3k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HEyxExxC3A+/lmqPPsKq1Kx2BLpDcSj3x4QcJxQK5Di9GfSQEwDj6zsPcXFz8W4qa Mzl3rK9i4sruu/nnS3TuMCp6u9I09Mzj6SDkOBeq5W24OxWYgBKRB6rmxOLJiqV/Mw 74MmzdYcOWS42/wQkidL6bzFZpC3oEmDsSRblu5E= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Dan Carpenter , "Martin K . Petersen" , Sasha Levin , linux-scsi@vger.kernel.org Subject: [PATCH AUTOSEL 4.4 05/11] scsi: iscsi: qla4xxx: fix double free in probe Date: Fri, 20 Dec 2019 09:47:37 -0500 Message-Id: <20191220144744.10565-5-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191220144744.10565-1-sashal@kernel.org> References: <20191220144744.10565-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org From: Dan Carpenter [ Upstream commit fee92f25777789d73e1936b91472e9c4644457c8 ] On this error path we call qla4xxx_mem_free() and then the caller also calls qla4xxx_free_adapter() which calls qla4xxx_mem_free(). It leads to a couple double frees: drivers/scsi/qla4xxx/ql4_os.c:8856 qla4xxx_probe_adapter() warn: 'ha->chap_dma_pool' double freed drivers/scsi/qla4xxx/ql4_os.c:8856 qla4xxx_probe_adapter() warn: 'ha->fw_ddb_dma_pool' double freed Fixes: afaf5a2d341d ("[SCSI] Initial Commit of qla4xxx") Link: https://lore.kernel.org/r/20191203094421.hw7ex7qr3j2rbsmx@kili.mountain Signed-off-by: Dan Carpenter Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/qla4xxx/ql4_os.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c index d220b4f691c77..f714d5f917d10 100644 --- a/drivers/scsi/qla4xxx/ql4_os.c +++ b/drivers/scsi/qla4xxx/ql4_os.c @@ -4285,7 +4285,6 @@ static int qla4xxx_mem_alloc(struct scsi_qla_host *ha) return QLA_SUCCESS; mem_alloc_error_exit: - qla4xxx_mem_free(ha); return QLA_ERROR; } -- 2.20.1