From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49565C5519A for ; Mon, 27 Apr 2020 08:41:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 32D4820656 for ; Mon, 27 Apr 2020 08:41:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726504AbgD0IlG (ORCPT ); Mon, 27 Apr 2020 04:41:06 -0400 Received: from mx2.suse.de ([195.135.220.15]:35650 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726183AbgD0IlF (ORCPT ); Mon, 27 Apr 2020 04:41:05 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 35E55B042; Mon, 27 Apr 2020 08:41:03 +0000 (UTC) Date: Mon, 27 Apr 2020 10:41:02 +0200 From: Daniel Wagner To: Bart Van Assche Cc: "Martin K . Petersen" , "James E . J . Bottomley" , linux-scsi@vger.kernel.org, Nilesh Javali , Himanshu Madhani , Quinn Tran , Martin Wilck , Roman Bolshakov Subject: Re: [PATCH v4 08/11] qla2xxx: Fix the code that reads from mailbox registers Message-ID: <20200427084102.3zpbjhjlqtltljfk@beryllium.lan> References: <20200427030310.19687-1-bvanassche@acm.org> <20200427030310.19687-9-bvanassche@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200427030310.19687-9-bvanassche@acm.org> Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On Sun, Apr 26, 2020 at 08:03:07PM -0700, Bart Van Assche wrote: > Make the MMIO accessors strongly typed such that the compiler checks whether > the accessor function is used that matches the register width. Fix those > MMIO accesses where another number of bits was read or written than the size > of the register. > > Cc: Nilesh Javali > Cc: Himanshu Madhani > Cc: Quinn Tran > Cc: Martin Wilck > Cc: Daniel Wagner > Cc: Roman Bolshakov > Signed-off-by: Bart Van Assche Reviewed-by: Daniel Wagner