From: Eric Biggers <ebiggers@kernel.org>
To: Satya Tangirala <satyat@google.com>,
Avri Altman <avri.altman@wdc.com>,
Alim Akhtar <alim.akhtar@samsung.com>
Cc: linux-scsi@vger.kernel.org,
Barani Muthukumaran <bmuthuku@qti.qualcomm.com>,
Kuohong Wang <kuohong.wang@mediatek.com>,
Kim Boojin <boojin.kim@samsung.com>
Subject: Re: [PATCH v4 0/3] Inline Encryption Support for UFS
Date: Mon, 6 Jul 2020 17:13:58 -0700 [thread overview]
Message-ID: <20200707001358.GC833@sol.localdomain> (raw)
In-Reply-To: <20200706200414.2027450-1-satyat@google.com>
On Mon, Jul 06, 2020 at 08:04:11PM +0000, Satya Tangirala wrote:
> This patch series adds support for inline encryption to UFS using
> the inline encryption support in the block layer. It follows the JEDEC
> UFSHCI v2.1 specification, which defines inline encryption for UFS.
>
> This patch series previously went through a number of iterations as
> part of the "Inline Encryption Support" patchset (last version was v13:
> https://lkml.kernel.org/r/20200514003727.69001-1-satyat@google.com).
> This patch series is rebased on v5.8-rc4.
>
> Patch 1 introduces the crypto registers and struct definitions defined
> in the UFSHCI v2.1 spec.
>
> Patch 2 introduces functions to manipulate the UFS inline encryption
> hardware (again in line with the UFSHCI v2.1 spec) via the block
> layer keyslot manager. Device specific drivers must set the
> UFSHCD_CAP_CRYPTO in hba->caps before ufshcd_hba_init_crypto is called
> to opt-in to inline encryption support.
Note that it's now ufshcd_hba_init_crypto_capabilities(), not
ufshcd_hba_init_crypto().
>
> Patch 3 wires up ufshcd.c with the UFS crypto API introduced in Patch 2.
>
> This patch series has been tested on some Qualcomm chipsets (on the
> db845c, sm8150-mtp and sm8250-mtp) using some additional patches at
> https://lkml.kernel.org/linux-scsi/20200501045111.665881-1-ebiggers@kernel.org/
> and on some Mediatek chipsets using the additional patch in
> https://lkml.kernel.org/linux-scsi/20200304022101.14165-1-stanley.chu@mediatek.com/.
> These additional patches are required because these chipsets need certain
> additional behaviour not specified within the UFSHCI v2.1 spec.
>
> Thanks a lot to all the folks who tested this out!
>
> Changes v3 => v4:
> - fix incorrect patch folding
> - some cleanups from Eric
>
> Changes v2 => v3:
> - introduce ufshcd_prepare_req_desc_hdr_crypto to clean up code slightly
> - split up ufshcd_hba_init_crypto into ufshcd_hba_init_crypto_capabilities
> and ufshcd_init_crypto. The first function is called from
> ufshcd_hba_capabilities, and only reads crypto capabilities from device
> registers and sets up appropriate crypto structures. The second function
> is called from ufshcd_init, and actually initializes the inline crypto
> hardware.
>
> Changes v1 => v2
> - handle OCS_DEVICE_FATAL_ERROR explicitly in ufshcd_transfer_rsp_status
>
> Satya Tangirala (3):
> scsi: ufs: UFS driver v2.1 spec crypto additions
> scsi: ufs: UFS crypto API
> scsi: ufs: Add inline encryption support to UFS
These patches look good to me. Avri and Alim, what do you think?
We'd like these to be applied for 5.9.
- Eric
next prev parent reply other threads:[~2020-07-07 0:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200706200432epcas5p1d276cdebadfecc3984de37a80c4b19f2@epcas5p1.samsung.com>
2020-07-06 20:04 ` [PATCH v4 0/3] Inline Encryption Support for UFS Satya Tangirala
2020-07-06 20:04 ` [PATCH v4 1/3] scsi: ufs: UFS driver v2.1 spec crypto additions Satya Tangirala
2020-07-06 20:04 ` [PATCH v4 2/3] scsi: ufs: UFS crypto API Satya Tangirala
2020-07-08 7:44 ` Avri Altman
2020-07-08 16:00 ` Eric Biggers
2020-07-06 20:04 ` [PATCH v4 3/3] scsi: ufs: Add inline encryption support to UFS Satya Tangirala
2020-07-07 0:13 ` Eric Biggers [this message]
2020-07-08 7:46 ` [PATCH v4 0/3] Inline Encryption Support for UFS Avri Altman
2020-07-07 17:36 ` Alim Akhtar
2020-07-07 17:59 ` Eric Biggers
2020-07-08 6:06 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200707001358.GC833@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=bmuthuku@qti.qualcomm.com \
--cc=boojin.kim@samsung.com \
--cc=kuohong.wang@mediatek.com \
--cc=linux-scsi@vger.kernel.org \
--cc=satyat@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).