From: <dan.carpenter@oracle.com>
To: kwmad.kim@samsung.com
Cc: linux-scsi@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Subject: [bug report] scsi: ufs: exynos: Implement dbg_register_dump
Date: Fri, 24 Jul 2020 13:19:36 +0300 [thread overview]
Message-ID: <20200724101936.GA318943@mwanda> (raw)
Hello Kiwoong Kim,
The patch 957ee40d413b: "scsi: ufs: exynos: Implement
dbg_register_dump" from Jul 15, 2020, leads to the following static
checker warning:
drivers/scsi/ufs/ufs-exynos.c:1242 exynos_ufs_dbg_register_dump()
warn: test_bit() takes a bit number
drivers/scsi/ufs/ufs-exynos.c
1238 static void exynos_ufs_dbg_register_dump(struct ufs_hba *hba)
1239 {
1240 struct exynos_ufs *ufs = ufshcd_get_variant(hba);
1241
1242 if (!test_and_set_bit(EXYNOS_UFS_DBG_DUMP_CXT, &ufs->dbg_flag)) {
^^^^^^^^^^^^^^^^^^^^^^^
This is BIT(0) but test_and_set_bit should just take 0, otherwise it's
a double shift.
1243 exynos_ufs_dump_info(&ufs->handle, hba->dev);
1244 clear_bit(EXYNOS_UFS_DBG_DUMP_CXT, &ufs->dbg_flag);
1245 }
1246 }
regards,
dan carpenter
reply other threads:[~2020-07-24 10:19 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200724101936.GA318943@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kwmad.kim@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).