Linux-SCSI Archive on lore.kernel.org
 help / color / Atom feed
* [bug report] scsi: ufs: exynos: Implement dbg_register_dump
@ 2020-07-24 10:19 dan.carpenter
  0 siblings, 0 replies; only message in thread
From: dan.carpenter @ 2020-07-24 10:19 UTC (permalink / raw)
  To: kwmad.kim; +Cc: linux-scsi, linux-samsung-soc

Hello Kiwoong Kim,

The patch 957ee40d413b: "scsi: ufs: exynos: Implement
dbg_register_dump" from Jul 15, 2020, leads to the following static
checker warning:

	drivers/scsi/ufs/ufs-exynos.c:1242 exynos_ufs_dbg_register_dump()
	warn: test_bit() takes a bit number

drivers/scsi/ufs/ufs-exynos.c
  1238  static void exynos_ufs_dbg_register_dump(struct ufs_hba *hba)
  1239  {
  1240          struct exynos_ufs *ufs = ufshcd_get_variant(hba);
  1241  
  1242          if (!test_and_set_bit(EXYNOS_UFS_DBG_DUMP_CXT, &ufs->dbg_flag)) {
                                      ^^^^^^^^^^^^^^^^^^^^^^^
This is BIT(0) but test_and_set_bit should just take 0, otherwise it's
a double shift.

  1243                  exynos_ufs_dump_info(&ufs->handle, hba->dev);
  1244                  clear_bit(EXYNOS_UFS_DBG_DUMP_CXT, &ufs->dbg_flag);
  1245          }
  1246  }

regards,
dan carpenter

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-24 10:19 [bug report] scsi: ufs: exynos: Implement dbg_register_dump dan.carpenter

Linux-SCSI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-scsi/0 linux-scsi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-scsi linux-scsi/ https://lore.kernel.org/linux-scsi \
		linux-scsi@vger.kernel.org
	public-inbox-index linux-scsi

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-scsi


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git