Linux-SCSI Archive on
 help / color / Atom feed
* [PATCH] scsi: qla2xxx: Fix wrong return value in qlt_chk_unresolv_exchg()
@ 2020-08-02 11:15 Tianjia Zhang
  0 siblings, 0 replies; only message in thread
From: Tianjia Zhang @ 2020-08-02 11:15 UTC (permalink / raw)
  To: njavali, jejb, martin.petersen, himanshu.madhani, quinn.tran
  Cc: GR-QLogic-Storage-Upstream, linux-scsi, linux-kernel, tianjia.zhang

In the case of a failed retry, a positive value EIO is returned here.
I think this is a typo error. It is necessary to return an error value.

Fixes: 0691094ff3f2c ("scsi: qla2xxx: Add logic to detect ABTS hang and response completion")
Cc: Quinn Tran <>
Signed-off-by: Tianjia Zhang <>
 drivers/scsi/qla2xxx/qla_target.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
index c2c0e6049da4..f2bb841c2059 100644
--- a/drivers/scsi/qla2xxx/qla_target.c
+++ b/drivers/scsi/qla2xxx/qla_target.c
@@ -5668,7 +5668,7 @@ static int qlt_chk_unresolv_exchg(struct scsi_qla_host *vha,
 		/* found existing exchange */
 		if (qpair->retry_term_cnt >= 5) {
-			rc = EIO;
+			rc = -EIO;
 			qpair->retry_term_cnt = 0;
 			ql_log(ql_log_warn, vha, 0xffff,
 			    "Unable to send ABTS Respond. Dumping firmware.\n");

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-02 11:15 [PATCH] scsi: qla2xxx: Fix wrong return value in qlt_chk_unresolv_exchg() Tianjia Zhang

Linux-SCSI Archive on

Archives are clonable:
	git clone --mirror linux-scsi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-scsi linux-scsi/ \
	public-inbox-index linux-scsi

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone