* [PATCH] scsi: qla2xxx: Fix wrong return value in qla_nvme_register_hba()
@ 2020-08-02 11:15 Tianjia Zhang
2020-08-31 17:41 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Tianjia Zhang @ 2020-08-02 11:15 UTC (permalink / raw)
To: njavali, jejb, martin.petersen, quinn.tran, himanshu.madhani
Cc: GR-QLogic-Storage-Upstream, linux-scsi, linux-kernel, tianjia.zhang
On an error exit path, a negative error code should be returned
instead of a positive return value.
Fixes: 8777e4314d397 ("scsi: qla2xxx: Migrate NVME N2N handling into state machine")
Cc: Quinn Tran <quinn.tran@cavium.com>
Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
---
drivers/scsi/qla2xxx/qla_nvme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c
index fa695a4007f8..a8da6be52b18 100644
--- a/drivers/scsi/qla2xxx/qla_nvme.c
+++ b/drivers/scsi/qla2xxx/qla_nvme.c
@@ -678,7 +678,7 @@ int qla_nvme_register_hba(struct scsi_qla_host *vha)
struct nvme_fc_port_template *tmpl;
struct qla_hw_data *ha;
struct nvme_fc_port_info pinfo;
- int ret = EINVAL;
+ int ret = -EINVAL;
if (!IS_ENABLED(CONFIG_NVME_FC))
return ret;
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi: qla2xxx: Fix wrong return value in qla_nvme_register_hba()
2020-08-02 11:15 [PATCH] scsi: qla2xxx: Fix wrong return value in qla_nvme_register_hba() Tianjia Zhang
@ 2020-08-31 17:41 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2020-08-31 17:41 UTC (permalink / raw)
To: jejb, himanshu.madhani, njavali, quinn.tran, Tianjia Zhang
Cc: Martin K . Petersen, GR-QLogic-Storage-Upstream, linux-scsi,
tianjia.zhang, linux-kernel
On Sun, 2 Aug 2020 19:15:30 +0800, Tianjia Zhang wrote:
> On an error exit path, a negative error code should be returned
> instead of a positive return value.
Applied to 5.10/scsi-queue, thanks!
[1/1] scsi: qla2xxx: Fix wrong return value in qla_nvme_register_hba()
https://git.kernel.org/mkp/scsi/c/ca4fb89a3d71
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-31 17:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-02 11:15 [PATCH] scsi: qla2xxx: Fix wrong return value in qla_nvme_register_hba() Tianjia Zhang
2020-08-31 17:41 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).