From: Tom Yan <tom.ty89@gmail.com>
To: linux-scsi@vger.kernel.org, dgilbert@interlog.com,
bvanassche@acm.org, gregkh@linuxfoundation.org
Cc: stern@rowland.harvard.edu, akinobu.mita@gmail.com, hch@lst.de,
linux-api@vger.kernel.org, Tom Yan <tom.ty89@gmail.com>
Subject: [PATCH v2 1/4] scsi: sg: fix BLKSECTGET ioctl
Date: Sun, 6 Sep 2020 15:40:15 +0800 [thread overview]
Message-ID: <20200906074018.2370-1-tom.ty89@gmail.com> (raw)
In-Reply-To: <CAGnHSEmos_vznm40WfnX0XC-kdOKz9CNdW9thWzepkgS2eEDCw@mail.gmail.com>
It should give out the maximum number of sectors per request
instead of maximum number of bytes, as that is what its equivalence
in the block layer does (that is also the reason for the USHRT_MAX
clamp; they should always have identical behaviour when possbile).
Signed-off-by: Tom Yan <tom.ty89@gmail.com>
---
v2: add more details in commit messages
drivers/scsi/sg.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c
index 20472aaaf630..e57831910228 100644
--- a/drivers/scsi/sg.c
+++ b/drivers/scsi/sg.c
@@ -922,6 +922,7 @@ sg_ioctl_common(struct file *filp, Sg_device *sdp, Sg_fd *sfp,
int result, val, read_only;
Sg_request *srp;
unsigned long iflags;
+ unsigned int max_sectors;
SCSI_LOG_TIMEOUT(3, sg_printk(KERN_INFO, sdp,
"sg_ioctl: cmd=0x%x\n", (int) cmd_in));
@@ -1114,8 +1115,9 @@ sg_ioctl_common(struct file *filp, Sg_device *sdp, Sg_fd *sfp,
sdp->sgdebug = (char) val;
return 0;
case BLKSECTGET:
- return put_user(max_sectors_bytes(sdp->device->request_queue),
- ip);
+ max_sectors = min_t(unsigned int, USHRT_MAX,
+ queue_max_sectors(sdp->device->request_queue));
+ return put_user(max_sectors, ip);
case BLKTRACESETUP:
return blk_trace_setup(sdp->device->request_queue,
sdp->disk->disk_name,
--
2.28.0
next prev parent reply other threads:[~2020-09-06 7:40 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-04 4:42 About BLKSECTGET in sg Tom Yan
2020-09-04 16:28 ` Douglas Gilbert
2020-09-04 19:21 ` Tom Yan
2020-09-04 20:05 ` [PATCH 1/4] scsi: sg: fix BLKSECTGET ioctl Tom Yan
2020-09-04 20:05 ` [PATCH 2/4] scsi: sg: implement BLKSSZGET Tom Yan
2020-09-05 18:37 ` Douglas Gilbert
2020-09-04 20:05 ` [PATCH 3/4] scsi: sg: use queue_logical_sector_size() in max_sectors_bytes() Tom Yan
2020-09-05 18:37 ` Douglas Gilbert
2020-09-04 20:05 ` [PATCH 4/4] block/scsi_ioctl.c: " Tom Yan
2020-09-05 18:37 ` Douglas Gilbert
2020-09-05 18:37 ` [PATCH 1/4] scsi: sg: fix BLKSECTGET ioctl Douglas Gilbert
2020-09-05 19:32 ` Bart Van Assche
2020-09-05 20:36 ` Douglas Gilbert
2020-09-06 1:19 ` Tom Yan
2020-09-06 1:25 ` [PATCH RESEND " Tom Yan
2020-09-06 1:25 ` [PATCH RESEND 2/4] scsi: sg: implement BLKSSZGET Tom Yan
2020-09-06 1:25 ` [PATCH RESEND 3/4] scsi: sg: use queue_logical_sector_size() in max_sectors_bytes() Tom Yan
2020-09-06 1:25 ` [PATCH RESEND 4/4] block/scsi_ioctl.c: " Tom Yan
2020-09-06 1:27 ` [PATCH RESEND 1/4] scsi: sg: fix BLKSECTGET ioctl Tom Yan
2020-09-06 1:27 ` [PATCH RESEND 2/4] scsi: sg: implement BLKSSZGET Tom Yan
2020-09-07 6:09 ` Christoph Hellwig
2020-09-07 9:01 ` Tom Yan
2020-09-08 8:42 ` Christoph Hellwig
2020-09-10 1:59 ` Tom Yan
2020-09-10 5:28 ` Christoph Hellwig
2020-09-11 2:52 ` Tom Yan
2020-09-11 6:48 ` Christoph Hellwig
2020-09-11 17:52 ` Douglas Gilbert
2020-09-11 21:33 ` Alan Stern
2020-09-16 5:47 ` Tom Yan
2020-09-06 1:27 ` [PATCH RESEND 3/4] scsi: sg: use queue_logical_sector_size() in max_sectors_bytes() Tom Yan
2020-09-06 6:26 ` Greg KH
2020-09-06 7:01 ` Tom Yan
2020-09-06 7:40 ` Tom Yan [this message]
2020-09-06 7:40 ` [PATCH v2 2/4] scsi: sg: implement BLKSSZGET Tom Yan
2020-09-06 7:40 ` [PATCH v2 3/4] scsi: sg: use queue_logical_sector_size() in max_sectors_bytes() Tom Yan
2020-09-06 7:40 ` [PATCH v2 4/4] block/scsi_ioctl.c: " Tom Yan
2020-09-06 7:51 ` [PATCH v3 1/4] scsi: sg: fix BLKSECTGET ioctl Tom Yan
2020-09-06 7:51 ` [PATCH v3 2/4] scsi: sg: implement BLKSSZGET Tom Yan
2020-09-06 7:51 ` [PATCH v3 3/4] scsi: sg: use queue_logical_sector_size() in max_sectors_bytes() Tom Yan
2020-09-06 7:51 ` [PATCH v3 4/4] block/scsi_ioctl.c: " Tom Yan
2020-09-06 1:27 ` [PATCH RESEND " Tom Yan
2020-09-06 5:09 ` [PATCH 1/4] scsi: sg: fix BLKSECTGET ioctl Douglas Gilbert
2020-09-06 7:16 ` Tom Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200906074018.2370-1-tom.ty89@gmail.com \
--to=tom.ty89@gmail.com \
--cc=akinobu.mita@gmail.com \
--cc=bvanassche@acm.org \
--cc=dgilbert@interlog.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=linux-api@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).