* [PATCH] scsi: ibmvfc: Fix error return in ibmvfc_probe()
@ 2020-09-07 8:39 Jing Xiangfeng
2020-09-09 19:20 ` Tyrel Datwyler
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jing Xiangfeng @ 2020-09-07 8:39 UTC (permalink / raw)
To: tyreld, mpe, benh, paulus, jejb, martin.petersen
Cc: linux-scsi, linuxppc-dev, linux-kernel, jingxiangfeng
Fix to return error code PTR_ERR() from the error handling case instead
of 0.
Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
---
drivers/scsi/ibmvscsi/ibmvfc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c
index ea7c8930592d..70daa0605082 100644
--- a/drivers/scsi/ibmvscsi/ibmvfc.c
+++ b/drivers/scsi/ibmvscsi/ibmvfc.c
@@ -4928,6 +4928,7 @@ static int ibmvfc_probe(struct vio_dev *vdev, const struct vio_device_id *id)
if (IS_ERR(vhost->work_thread)) {
dev_err(dev, "Couldn't create kernel thread: %ld\n",
PTR_ERR(vhost->work_thread));
+ rc = PTR_ERR(vhost->work_thread);
goto free_host_mem;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: ibmvfc: Fix error return in ibmvfc_probe()
2020-09-07 8:39 [PATCH] scsi: ibmvfc: Fix error return in ibmvfc_probe() Jing Xiangfeng
@ 2020-09-09 19:20 ` Tyrel Datwyler
2020-09-10 2:11 ` Martin K. Petersen
2020-09-15 20:16 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Tyrel Datwyler @ 2020-09-09 19:20 UTC (permalink / raw)
To: Jing Xiangfeng, mpe, benh, paulus, jejb, martin.petersen
Cc: linux-scsi, linuxppc-dev, linux-kernel
On 9/7/20 1:39 AM, Jing Xiangfeng wrote:
> Fix to return error code PTR_ERR() from the error handling case instead
> of 0.
>
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
Acked-by: Tyrel Datwyler <tyreld@linux.ibm.com>
> ---
> drivers/scsi/ibmvscsi/ibmvfc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c
> index ea7c8930592d..70daa0605082 100644
> --- a/drivers/scsi/ibmvscsi/ibmvfc.c
> +++ b/drivers/scsi/ibmvscsi/ibmvfc.c
> @@ -4928,6 +4928,7 @@ static int ibmvfc_probe(struct vio_dev *vdev, const struct vio_device_id *id)
> if (IS_ERR(vhost->work_thread)) {
> dev_err(dev, "Couldn't create kernel thread: %ld\n",
> PTR_ERR(vhost->work_thread));
> + rc = PTR_ERR(vhost->work_thread);
> goto free_host_mem;
> }
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: ibmvfc: Fix error return in ibmvfc_probe()
2020-09-07 8:39 [PATCH] scsi: ibmvfc: Fix error return in ibmvfc_probe() Jing Xiangfeng
2020-09-09 19:20 ` Tyrel Datwyler
@ 2020-09-10 2:11 ` Martin K. Petersen
2020-09-15 20:16 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2020-09-10 2:11 UTC (permalink / raw)
To: Jing Xiangfeng
Cc: tyreld, mpe, benh, paulus, jejb, martin.petersen, linux-scsi,
linuxppc-dev, linux-kernel
Jing,
> Fix to return error code PTR_ERR() from the error handling case instead
> of 0.
Applied to 5.10/scsi-staging. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: ibmvfc: Fix error return in ibmvfc_probe()
2020-09-07 8:39 [PATCH] scsi: ibmvfc: Fix error return in ibmvfc_probe() Jing Xiangfeng
2020-09-09 19:20 ` Tyrel Datwyler
2020-09-10 2:11 ` Martin K. Petersen
@ 2020-09-15 20:16 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2020-09-15 20:16 UTC (permalink / raw)
To: mpe, benh, Jing Xiangfeng, jejb, paulus, tyreld
Cc: Martin K . Petersen, linux-kernel, linuxppc-dev, linux-scsi
On Mon, 7 Sep 2020 16:39:49 +0800, Jing Xiangfeng wrote:
> Fix to return error code PTR_ERR() from the error handling case instead
> of 0.
Applied to 5.10/scsi-queue, thanks!
[1/1] scsi: ibmvfc: Fix error return in ibmvfc_probe()
https://git.kernel.org/mkp/scsi/c/5e48a084f4e8
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-15 22:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-07 8:39 [PATCH] scsi: ibmvfc: Fix error return in ibmvfc_probe() Jing Xiangfeng
2020-09-09 19:20 ` Tyrel Datwyler
2020-09-10 2:11 ` Martin K. Petersen
2020-09-15 20:16 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).