From: Christoph Hellwig <hch@infradead.org>
To: Damien Le Moal <damien.lemoal@wdc.com>
Cc: linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH 3/3] scsi: handle zone resources errors
Date: Thu, 10 Sep 2020 18:53:43 +0100 [thread overview]
Message-ID: <20200910175343.GA9539@infradead.org> (raw)
In-Reply-To: <20200910073952.212130-4-damien.lemoal@wdc.com>
On Thu, Sep 10, 2020 at 04:39:52PM +0900, Damien Le Moal wrote:
> + case DATA_PROTECT:
> + sdev_printk(KERN_INFO, cmd->device,
> + "asc/ascq = 0x%02x 0x%02x\n",
> + sshdr.asc, sshdr.ascq);
> + action = ACTION_FAIL;
> + if ((sshdr.asc == 0x0C && sshdr.ascq == 0x12) ||
> + (sshdr.asc == 0x55 &&
> + (sshdr.ascq == 0x0E || sshdr.ascq == 0x0F))) {
> + /* Insufficient zone resources */
> + blk_stat = BLK_STS_DEV_RESOURCE;
BLK_STS_DEV_RESOURCE is a magic error code leading to a retry on the
particular request_queue once it isn't busy any more. Please don't
abuse it for random other conditions.
next prev parent reply other threads:[~2020-09-10 17:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 7:39 [PATCH 0/3] Improve error handling Damien Le Moal
2020-09-10 7:39 ` [PATCH 1/3] scsi: Cleanup scsi_noretry_cmd() Damien Le Moal
2020-09-10 17:47 ` Bart Van Assche
2020-09-10 22:07 ` Damien Le Moal
2020-09-10 7:39 ` [PATCH 2/3] scsi: update additional sense codes list Damien Le Moal
2020-09-10 7:39 ` [PATCH 3/3] scsi: handle zone resources errors Damien Le Moal
2020-09-10 7:45 ` Damien Le Moal
2020-09-10 17:53 ` Christoph Hellwig [this message]
2020-09-10 22:16 ` Damien Le Moal
2020-09-10 14:11 ` [PATCH 0/3] Improve error handling Himanshu Madhani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200910175343.GA9539@infradead.org \
--to=hch@infradead.org \
--cc=damien.lemoal@wdc.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).