From: Daniel Wagner <dwagner@suse.de>
To: John Garry <john.garry@huawei.com>
Cc: jejb@linux.ibm.com, martin.petersen@oracle.com, lenb@kernel.org,
rjw@rjwysocki.net, gregkh@linuxfoundation.org,
tglx@linutronix.de, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, linuxarm@huawei.com,
linux-acpi@vger.kernel.org, maz@kernel.org
Subject: Re: [PATCH v3 1/5] genirq/affinity: Add irq_update_affinity_desc()
Date: Thu, 26 Nov 2020 09:51:45 +0100 [thread overview]
Message-ID: <20201126085145.jjioc7belyny5kp4@beryllium.lan> (raw)
In-Reply-To: <1606324841-217570-2-git-send-email-john.garry@huawei.com>
Hi John,
On Thu, Nov 26, 2020 at 01:20:37AM +0800, John Garry wrote:
> + activated = irqd_is_activated(&desc->irq_data);
> + if (activated)
> + irq_domain_deactivate_irq(&desc->irq_data);
> +
> + if (affinity->is_managed) {
> + irqd_set(&desc->irq_data, IRQD_AFFINITY_MANAGED);
> + irqd_set(&desc->irq_data, IRQD_MANAGED_SHUTDOWN);
> + }
> +
> + cpumask_copy(desc->irq_common_data.affinity, &affinity->mask);
> +
> + /* Restore the activation state */
> + if (activated)
> + irq_domain_deactivate_irq(&desc->irq_data);
Shouldn't this be irq_domain_activate_irq() ?
Thanks,
Daniel
next prev parent reply other threads:[~2020-11-26 8:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-25 17:20 [PATCH v3 0/5] Support managed interrupts for platform devices John Garry
2020-11-25 17:20 ` [PATCH v3 1/5] genirq/affinity: Add irq_update_affinity_desc() John Garry
2020-11-26 8:51 ` Daniel Wagner [this message]
2020-11-26 8:54 ` John Garry
2020-11-25 17:20 ` [PATCH v3 2/5] ACPI: Make acpi_dev_irqresource_disabled() public John Garry
2020-11-25 17:43 ` Rafael J. Wysocki
2020-11-26 8:49 ` John Garry
2020-11-26 14:24 ` Rafael J. Wysocki
2020-11-25 17:20 ` [PATCH v3 3/5] driver core: platform: Add platform_put_irq() John Garry
2020-11-26 9:28 ` Marc Zyngier
2020-11-26 11:23 ` John Garry
2020-11-25 17:20 ` [PATCH v3 4/5] Driver core: platform: Add devm_platform_get_irqs_affinity() John Garry
2020-11-25 17:20 ` [PATCH v3 5/5] scsi: hisi_sas: Expose HW queues for v2 hw John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201126085145.jjioc7belyny5kp4@beryllium.lan \
--to=dwagner@suse.de \
--cc=gregkh@linuxfoundation.org \
--cc=jejb@linux.ibm.com \
--cc=john.garry@huawei.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=martin.petersen@oracle.com \
--cc=maz@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).