From: Anastasia Kovaleva <a.kovaleva@yadro.com>
To: <martin.petersen@oracle.com>
Cc: <target-devel@vger.kernel.org>, <linux-scsi@vger.kernel.org>,
<linux@yadro.com>, Anastasia Kovaleva <a.kovaleva@yadro.com>
Subject: [RESEND PATCH 0/3] scsi: target: Set correct residual data
Date: Thu, 3 Dec 2020 11:20:32 +0300 [thread overview]
Message-ID: <20201203082035.54566-1-a.kovaleva@yadro.com> (raw)
Hi Martin,
Please apply the changes to 5.11/scsi-queue at your earliest
convenience.
The series changes the behavior of the target in regard to processing
commands with overflow/underflow in accordance with the standarts.
The target driver used to process the DMA_TO_DEVICE commands with
residuals (in particular, WRITE command) incorrectly. The target
response contained neither a residual count, nor an OVERFLOW/UNDERFLOW
bit. Such behavior did not comply with the RFC 7143. Also the
returned ASC and ASCQ were incorrect according to FCP-4,
and residuals were not set for the 4Kn devices.
This patches fix the major inconsistances in processing these kind of
commands.
This patch series has been tested with a modified libiscsi testing
library.
The link to the pull request:
https://github.com/sahlberg/libiscsi/pull/345
Write10Residuals, Write12Residuals, Write16Residuals tests have passed.
Thanks,
Anastasia
Anastasia Kovaleva (2):
scsi: target: core: Signal WRITE residuals
scsi: target: core: Change ASCQ for residual write
Roman Bolshakov (1):
scsi: target: core: Set residuals for 4Kn devices
drivers/target/target_core_transport.c | 53 +++++++++++++-------------
include/target/target_core_base.h | 1 +
2 files changed, 28 insertions(+), 26 deletions(-)
--
2.24.3 (Apple Git-128)
next reply other threads:[~2020-12-03 8:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 8:20 Anastasia Kovaleva [this message]
2020-12-03 8:20 ` [RESEND PATCH 1/3] scsi: target: core: Set residuals for 4Kn devices Anastasia Kovaleva
2020-12-03 8:20 ` [RESEND PATCH 2/3] scsi: target: core: Signal WRITE residuals Anastasia Kovaleva
2020-12-03 8:20 ` [RESEND PATCH 3/3] scsi: target: core: Change ASCQ for residual write Anastasia Kovaleva
2021-01-21 15:24 ` [RESEND PATCH 0/3] scsi: target: Set correct residual data Anastasia Kovaleva
2021-01-27 4:12 ` Martin K. Petersen
2021-01-29 19:01 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201203082035.54566-1-a.kovaleva@yadro.com \
--to=a.kovaleva@yadro.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@yadro.com \
--cc=martin.petersen@oracle.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).