From: Yue Hu <zbestahu@gmail.com>
To: martin.petersen@oracle.com, jejb@linux.ibm.com,
alim.akhtar@samsung.com, avri.altman@wdc.com, beanhuo@micron.com,
stanley.chu@mediatek.com, cang@codeaurora.org
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
huyue2@yulong.com, zbestahu@163.com, zhangwen@yulong.com
Subject: [PATCH] scsi: ufs: Remove unnecessary ret in ufshcd_populate_vreg()
Date: Wed, 10 Mar 2021 16:27:41 +0800 [thread overview]
Message-ID: <20210310082741.647-1-zbestahu@gmail.com> (raw)
From: Yue Hu <huyue2@yulong.com>
The local variable _ret_ is always zero, so we can remove it and just
return 0 directly in the end.
Signed-off-by: Yue Hu <huyue2@yulong.com>
---
drivers/scsi/ufs/ufshcd-pltfrm.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c b/drivers/scsi/ufs/ufshcd-pltfrm.c
index 1a69949..fedb7de 100644
--- a/drivers/scsi/ufs/ufshcd-pltfrm.c
+++ b/drivers/scsi/ufs/ufshcd-pltfrm.c
@@ -106,7 +106,6 @@ static int ufshcd_parse_clock_info(struct ufs_hba *hba)
static int ufshcd_populate_vreg(struct device *dev, const char *name,
struct ufs_vreg **out_vreg)
{
- int ret = 0;
char prop_name[MAX_PROP_SIZE];
struct ufs_vreg *vreg = NULL;
struct device_node *np = dev->of_node;
@@ -135,9 +134,8 @@ static int ufshcd_populate_vreg(struct device *dev, const char *name,
vreg->max_uA = 0;
}
out:
- if (!ret)
- *out_vreg = vreg;
- return ret;
+ *out_vreg = vreg;
+ return 0;
}
/**
--
1.9.1
next reply other threads:[~2021-03-10 8:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 8:27 Yue Hu [this message]
2021-03-19 3:46 ` [PATCH] scsi: ufs: Remove unnecessary ret in ufshcd_populate_vreg() Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210310082741.647-1-zbestahu@gmail.com \
--to=zbestahu@gmail.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=cang@codeaurora.org \
--cc=huyue2@yulong.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stanley.chu@mediatek.com \
--cc=zbestahu@163.com \
--cc=zhangwen@yulong.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).