From: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
Cc: Bart Van Assche <bvanassche@acm.org>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
Damien Le Moal <Damien.LeMoal@wdc.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] scsi: sd_zbc: update write pointer offset cache
Date: Fri, 12 Mar 2021 04:38:29 +0000 [thread overview]
Message-ID: <20210312043828.kl2olk2d7awfsi7j@shindev.dhcp.fujisawa.hgst.com> (raw)
In-Reply-To: <PH0PR04MB7416FFA8BC2332DB647FA12E9B909@PH0PR04MB7416.namprd04.prod.outlook.com>
On Mar 11, 2021 / 15:54, Johannes Thumshirn wrote:
> On 11/03/2021 16:48, Bart Van Assche wrote:
> > On 3/11/21 7:18 AM, Johannes Thumshirn wrote:
> >> On 11/03/2021 16:13, Bart Van Assche wrote:
> >>> On 3/10/21 1:48 AM, Johannes Thumshirn wrote:
> >>>> Recent changes [ ... ]
> >>>
> >>> Please add Fixes: and/or Cc: stable tags as appropriate.
> >>
> >> I couldn't pin down the offending commit and I can't reproduce it locally
> >> as well, so I opted out of this. But it must be something between v5.11 and v5.12-rc2.
> >
> > That's weird. Did Shinichiro use a HBA? Could this be the result of a
> > behavior change in the HBA driver?
>
> Yes I've looked at the commits in mpt3sas, but can't really pinpoint the
> offending commit TBH. 664f0dce2058 ("scsi: mpt3sas: Add support for shared
> host tagset for CPU hotplug") is the only one that /looks/ as if it could
> be causing it, but I don't know mpt3sas well enough.
>
> FWIW added Sreekanth
The WARNING was found in kernel v5.12-rc2 test with a SAS SMR drive and HBA
Broadcom 9400. It can be recreated by running blktests block/004 on the drive
(after reboot). It is also recreated with SATA SMR drive with the HBA, but not
observed with SATA drives connected to AHCI.
I reverted the commit 664f0dce2058, then the WARNING disappeared. I suppose
it indicates that the commit changed HBA driver behavior.
--
Best Regards,
Shin'ichiro Kawasaki
next prev parent reply other threads:[~2021-03-12 4:39 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 9:48 [PATCH] scsi: sd_zbc: update write pointer offset cache Johannes Thumshirn
2021-03-10 22:45 ` Damien Le Moal
2021-03-11 3:14 ` Shinichiro Kawasaki
2021-03-11 15:13 ` Bart Van Assche
2021-03-11 15:18 ` Johannes Thumshirn
2021-03-11 15:48 ` Bart Van Assche
2021-03-11 15:54 ` Johannes Thumshirn
2021-03-12 2:56 ` Bart Van Assche
2021-03-12 4:38 ` Shinichiro Kawasaki [this message]
2021-03-12 5:51 ` Johannes Thumshirn
2021-03-12 7:27 ` Damien Le Moal
2021-03-12 7:59 ` Johannes Thumshirn
2021-03-12 8:20 ` Damien Le Moal
2021-03-12 8:58 ` Johannes Thumshirn
2021-03-12 10:05 ` Shinichiro Kawasaki
2021-03-12 10:28 ` Johannes Thumshirn
2021-03-12 11:48 ` Shinichiro Kawasaki
2021-03-12 12:02 ` Johannes Thumshirn
2021-03-16 7:53 ` Johannes Thumshirn
2021-03-17 1:42 ` Martin K. Petersen
2021-03-17 7:45 ` Johannes Thumshirn
2021-03-19 2:21 ` Martin K. Petersen
2021-03-19 3:45 ` Martin K. Petersen
2021-03-19 8:15 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210312043828.kl2olk2d7awfsi7j@shindev.dhcp.fujisawa.hgst.com \
--to=shinichiro.kawasaki@wdc.com \
--cc=Damien.LeMoal@wdc.com \
--cc=Johannes.Thumshirn@wdc.com \
--cc=bvanassche@acm.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sreekanth.reddy@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).