From: Daejun Park <daejun7.park@samsung.com>
To: Daejun Park <daejun7.park@samsung.com>
Cc: "avri.altman@wdc.com" <avri.altman@wdc.com>,
"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
"stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
"cang@codeaurora.org" <cang@codeaurora.org>,
"bvanassche@acm.org" <bvanassche@acm.org>,
"huobean@gmail.com" <huobean@gmail.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
ALIM AKHTAR <alim.akhtar@samsung.com>,
JinHwan Park <jh.i.park@samsung.com>,
SEUNGUK SHIN <seunguk.shin@samsung.com>,
Sung-Jun Park <sungjun07.park@samsung.com>,
Jinyoung CHOI <j-young.choi@samsung.com>,
BoRam Shin <boram.shin@samsung.com>
Subject: RE: Re: [PATCH] scsi: ufs: Add selector to ufshcd_query_flag* APIs
Date: Fri, 19 Mar 2021 11:51:21 +0900 [thread overview]
Message-ID: <20210319025121epcms2p54274eddaa64ae4d0868424df3dac11b2@epcms2p5> (raw)
In-Reply-To: <yq1mtuzq3tu.fsf@ca-mkp.ca.oracle.com>
Hi Martin
>
>Daejun,
>
>> Unlike other query APIs in UFS, ufshcd_query_flag has a fixed selector
>> as 0. This patch allows ufshcd_query_flag API to choose selector value
>> by parameter.
>
>I don't see any users of the added parameter. Am I missing something?
The JEDEC standard describes it as follows:
The selector field may be needed to further identify a particular element of a flag.
Other cannot used it because it is fixed as zero in the API.
Thanks,
Daejun
The selector field may be needed to further identify a particular element of a flag. Selector field is not
2218 used in this version of the standard and its value shall be zero.
>
>--
>Martin K. Petersen Oracle Linux Engineering
>
>
>
prev parent reply other threads:[~2021-03-19 2:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210317033143epcms2p25b37bba2bb515c1ce85bf555656ca3f2@epcms2p2>
2021-03-17 3:31 ` [PATCH] scsi: ufs: Add selector to ufshcd_query_flag* APIs Daejun Park
2021-03-18 5:48 ` Can Guo
2021-03-19 2:25 ` Martin K. Petersen
[not found] ` <CGME20210317033143epcms2p25b37bba2bb515c1ce85bf555656ca3f2@epcms2p5>
2021-03-19 2:51 ` Daejun Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210319025121epcms2p54274eddaa64ae4d0868424df3dac11b2@epcms2p5 \
--to=daejun7.park@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=boram.shin@samsung.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=huobean@gmail.com \
--cc=j-young.choi@samsung.com \
--cc=jejb@linux.ibm.com \
--cc=jh.i.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=seunguk.shin@samsung.com \
--cc=stanley.chu@mediatek.com \
--cc=sungjun07.park@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).