From: Mike Christie <michael.christie@oracle.com>
To: lduncan@suse.com, cleech@redhat.com, njavali@marvell.com,
mrangankar@marvell.com, GR-QLogic-Storage-Upstream@marvell.com,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
jejb@linux.ibm.com
Cc: Mike Christie <michael.christie@oracle.com>
Subject: [PATCH 09/28] scsi: iscsi_tcp: Start socket shutdown during conn stop
Date: Sun, 23 May 2021 12:57:20 -0500 [thread overview]
Message-ID: <20210523175739.360324-10-michael.christie@oracle.com> (raw)
In-Reply-To: <20210523175739.360324-1-michael.christie@oracle.com>
Make sure the conn socket shutdown starts before we start the timer to fail
commands to upper layers.
Reviewed-by: Lee Duncan <lduncan@suse.com>
Signed-off-by: Mike Christie <michael.christie@oracle.com>
---
drivers/scsi/iscsi_tcp.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c
index 553e95ad6197..1bc37593c88f 100644
--- a/drivers/scsi/iscsi_tcp.c
+++ b/drivers/scsi/iscsi_tcp.c
@@ -600,6 +600,12 @@ static void iscsi_sw_tcp_release_conn(struct iscsi_conn *conn)
if (!sock)
return;
+ /*
+ * Make sure we start socket shutdown now in case userspace is up
+ * but delayed in releasing the socket.
+ */
+ kernel_sock_shutdown(sock, SHUT_RDWR);
+
sock_hold(sock->sk);
iscsi_sw_tcp_conn_restore_callbacks(conn);
sock_put(sock->sk);
--
2.25.1
next prev parent reply other threads:[~2021-05-23 17:58 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-23 17:57 iscsi error handler fixes Mike Christie
2021-05-23 17:57 ` [PATCH 01/28] scsi: iscsi: Add task completion helper Mike Christie
2021-05-23 17:57 ` [PATCH 02/28] scsi: iscsi: Stop queueing during ep_disconnect Mike Christie
2021-05-23 17:57 ` [PATCH 03/28] scsi: iscsi: Drop suspend calls from ep_disconnect Mike Christie
2021-05-23 17:57 ` [PATCH 04/28] scsi: iscsi: Force immediate failure during shutdown Mike Christie
2021-05-24 16:00 ` Lee Duncan
2021-05-23 17:57 ` [PATCH 05/28] scsi: iscsi: Use system_unbound_wq for destroy_work Mike Christie
2021-05-23 17:57 ` [PATCH 06/28] scsi: iscsi: Rel ref after iscsi_lookup_endpoint Mike Christie
2021-05-23 17:57 ` [PATCH 07/28] scsi: iscsi: Fix in-kernel conn failure handling Mike Christie
2021-05-24 18:22 ` Lee Duncan
2021-05-23 17:57 ` [PATCH 08/28] scsi: iscsi_tcp: Set no linger Mike Christie
2021-05-23 17:57 ` Mike Christie [this message]
2021-05-23 17:57 ` [PATCH 10/28] scsi: iscsi: Add iscsi_cls_conn refcount helpers Mike Christie
2021-05-24 18:34 ` Lee Duncan
2021-05-23 17:57 ` [PATCH 11/28] scsi: iscsi: Have abort handler get ref to conn Mike Christie
2021-05-24 18:36 ` Lee Duncan
2021-05-23 17:57 ` [PATCH 12/28] scsi: iscsi: Get ref to conn during reset handling Mike Christie
2021-05-24 18:37 ` Lee Duncan
2021-05-23 17:57 ` [PATCH 13/28] scsi: iscsi: Fix conn use after free during resets Mike Christie
2021-05-23 17:57 ` [PATCH 14/28] scsi: iscsi: Fix shost->max_id use Mike Christie
2021-05-23 17:57 ` [PATCH 15/28] scsi: iscsi: Fix completion check during abort races Mike Christie
2021-05-24 18:38 ` Lee Duncan
2021-05-23 17:57 ` [PATCH 16/28] scsi: iscsi: Flush block work before unblock Mike Christie
2021-05-24 18:43 ` Lee Duncan
2021-05-23 17:57 ` [PATCH 17/28] scsi: iscsi: Hold task ref during TMF timeout handling Mike Christie
2021-05-24 18:45 ` Lee Duncan
2021-05-23 17:57 ` [PATCH 18/28] scsi: iscsi: Move pool freeing Mike Christie
2021-05-23 17:57 ` [PATCH 19/28] scsi: qedi: Fix null ref during abort handling Mike Christie
2021-05-23 17:57 ` [PATCH 20/28] scsi: qedi: Fix race during abort timeouts Mike Christie
2021-05-23 17:57 ` [PATCH 21/28] scsi: qedi: Fix use after free during abort cleanup Mike Christie
2021-05-23 17:57 ` [PATCH 22/28] scsi: qedi: Fix TMF tid allocation Mike Christie
2021-05-23 17:57 ` [PATCH 23/28] scsi: qedi: Use GFP_NOIO for TMF allocation Mike Christie
2021-05-23 17:57 ` [PATCH 24/28] scsi: qedi: Fix TMF session block/unblock use Mike Christie
2021-05-23 17:57 ` [PATCH 25/28] scsi: qedi: Fix cleanup " Mike Christie
2021-05-23 17:57 ` [PATCH 26/28] scsi: qedi: Pass send_iscsi_tmf task to abort Mike Christie
2021-05-23 17:57 ` [PATCH 27/28] scsi: qedi: Complete TMF works before disconnect Mike Christie
2021-05-23 17:57 ` [PATCH 28/28] scsi: qedi: Wake up if cmd_cleanup_req is set Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210523175739.360324-10-michael.christie@oracle.com \
--to=michael.christie@oracle.com \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=cleech@redhat.com \
--cc=jejb@linux.ibm.com \
--cc=lduncan@suse.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mrangankar@marvell.com \
--cc=njavali@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).