linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Douglas Gilbert <dgilbert@interlog.com>
To: linux-scsi@vger.kernel.org
Cc: martin.petersen@oracle.com, jejb@linux.vnet.ibm.com,
	hare@suse.de, Hannes Reinecke <hare@suse.com>
Subject: [PATCH v19 04/45] sg: rework sg_poll(), minor changes
Date: Sun, 23 May 2021 21:01:06 -0400	[thread overview]
Message-ID: <20210524010147.94845-5-dgilbert@interlog.com> (raw)
In-Reply-To: <20210524010147.94845-1-dgilbert@interlog.com>

Re-arrange code in sg_poll(). Rename sg_read_oxfer() to
sg_rd_append(). In sg_start_req() rename rw to r0w.
Plus associated changes demanded by checkpatch.pl

Reviewed-by: Hannes Reinecke <hare@suse.com>

Signed-off-by: Douglas Gilbert <dgilbert@interlog.com>
---
 drivers/scsi/sg.c | 65 ++++++++++++++++++++++-------------------------
 1 file changed, 30 insertions(+), 35 deletions(-)

diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c
index 33fd280dc5da..4bb0bf82bc39 100644
--- a/drivers/scsi/sg.c
+++ b/drivers/scsi/sg.c
@@ -182,8 +182,8 @@ static ssize_t sg_new_write(struct sg_fd *sfp, struct file *file,
 			    struct sg_request **o_srp);
 static int sg_common_write(struct sg_fd *sfp, struct sg_request *srp,
 			   u8 *cmnd, int timeout, int blocking);
-static int sg_read_oxfer(struct sg_request *srp, char __user *outp,
-			 int num_xfer);
+static int sg_rd_append(struct sg_request *srp, char __user *outp,
+			int num_xfer);
 static void sg_remove_scat(struct sg_fd *sfp, struct sg_scatter_hold *schp);
 static void sg_build_reserve(struct sg_fd *sfp, int req_size);
 static void sg_link_reserve(struct sg_fd *sfp, struct sg_request *srp,
@@ -796,7 +796,7 @@ sg_read(struct file *filp, char __user *buf, size_t count, loff_t *ppos)
 		old_hdr = kmalloc(SZ_SG_HEADER, GFP_KERNEL);
 		if (!old_hdr)
 			return -ENOMEM;
-		if (__copy_from_user(old_hdr, buf, SZ_SG_HEADER)) {
+		if (copy_from_user(old_hdr, buf, SZ_SG_HEADER)) {
 			retval = -EFAULT;
 			goto free_old_hdr;
 		}
@@ -809,7 +809,7 @@ sg_read(struct file *filp, char __user *buf, size_t count, loff_t *ppos)
 					retval = -ENOMEM;
 					goto free_old_hdr;
 				}
-				retval = __copy_from_user
+				retval = copy_from_user
 				    (new_hdr, buf, SZ_SG_IO_HDR);
 				req_pack_id = new_hdr->pack_id;
 				kfree(new_hdr);
@@ -904,7 +904,7 @@ sg_read(struct file *filp, char __user *buf, size_t count, loff_t *ppos)
 
 	/* Now copy the result back to the user buffer.  */
 	if (count >= SZ_SG_HEADER) {
-		if (__copy_to_user(buf, old_hdr, SZ_SG_HEADER)) {
+		if (copy_to_user(buf, old_hdr, SZ_SG_HEADER)) {
 			retval = -EFAULT;
 			goto free_old_hdr;
 		}
@@ -912,7 +912,7 @@ sg_read(struct file *filp, char __user *buf, size_t count, loff_t *ppos)
 		if (count > old_hdr->reply_len)
 			count = old_hdr->reply_len;
 		if (count > SZ_SG_HEADER) {
-			if (sg_read_oxfer(srp, buf, count - SZ_SG_HEADER)) {
+			if (sg_rd_append(srp, buf, count - SZ_SG_HEADER)) {
 				retval = -EFAULT;
 				goto free_old_hdr;
 			}
@@ -1278,38 +1278,34 @@ sg_compat_ioctl(struct file *filp, unsigned int cmd_in, unsigned long arg)
 static __poll_t
 sg_poll(struct file *filp, poll_table * wait)
 {
-	__poll_t res = 0;
-	struct sg_device *sdp;
-	struct sg_fd *sfp;
+	__poll_t p_res = 0;
+	struct sg_fd *sfp = filp->private_data;
 	struct sg_request *srp;
 	int count = 0;
 	unsigned long iflags;
 
-	sfp = filp->private_data;
 	if (!sfp)
 		return EPOLLERR;
-	sdp = sfp->parentdp;
-	if (!sdp)
-		return EPOLLERR;
 	poll_wait(filp, &sfp->read_wait, wait);
 	read_lock_irqsave(&sfp->rq_list_lock, iflags);
 	list_for_each_entry(srp, &sfp->rq_list, entry) {
 		/* if any read waiting, flag it */
-		if ((0 == res) && (1 == srp->done) && (!srp->sg_io_owned))
-			res = EPOLLIN | EPOLLRDNORM;
+		if (p_res == 0 && srp->done == 1 && !srp->sg_io_owned)
+			p_res = EPOLLIN | EPOLLRDNORM;
 		++count;
 	}
 	read_unlock_irqrestore(&sfp->rq_list_lock, iflags);
 
-	if (atomic_read(&sdp->detaching))
-		res |= EPOLLHUP;
-	else if (!sfp->cmd_q) {
-		if (0 == count)
-			res |= EPOLLOUT | EPOLLWRNORM;
-	} else if (count < SG_MAX_QUEUE)
-		res |= EPOLLOUT | EPOLLWRNORM;
-	SG_LOG(3, sfp, "%s: res=0x%x\n", __func__, (__force u32)res);
-	return res;
+	if (sfp->parentdp && atomic_read(&sfp->parentdp->detaching)) {
+		p_res |= EPOLLHUP;
+	} else if (!sfp->cmd_q) {
+		if (count == 0)
+			p_res |= EPOLLOUT | EPOLLWRNORM;
+	} else if (count < SG_MAX_QUEUE) {
+		p_res |= EPOLLOUT | EPOLLWRNORM;
+	}
+	SG_LOG(3, sfp, "%s: p_res=0x%x\n", __func__, (__force u32)p_res);
+	return p_res;
 }
 
 static int
@@ -1827,7 +1823,7 @@ sg_start_req(struct sg_request *srp, u8 *cmd)
 	struct sg_scatter_hold *rsv_schp = &sfp->reserve;
 	struct request_queue *q = sfp->parentdp->device->request_queue;
 	struct rq_map_data *md, map_data;
-	int rw = hp->dxfer_direction == SG_DXFER_TO_DEV ? WRITE : READ;
+	int r0w = hp->dxfer_direction == SG_DXFER_TO_DEV ? WRITE : READ;
 	u8 *long_cmdp = NULL;
 
 	if (hp->cmd_len > BLK_MAX_CDB) {
@@ -1837,7 +1833,7 @@ sg_start_req(struct sg_request *srp, u8 *cmd)
 		SG_LOG(5, sfp, "%s: long_cmdp=0x%p ++\n", __func__, long_cmdp);
 	}
 	SG_LOG(4, sfp, "%s: dxfer_len=%d, data-%s\n", __func__, dxfer_len,
-	       (rw ? "OUT" : "IN"));
+	       (r0w ? "OUT" : "IN"));
 
 	/*
 	 * NOTE
@@ -1913,7 +1909,7 @@ sg_start_req(struct sg_request *srp, u8 *cmd)
 		struct iovec *iov = NULL;
 		struct iov_iter i;
 
-		res = import_iovec(rw, hp->dxferp, iov_count, 0, &iov, &i);
+		res = import_iovec(r0w, hp->dxferp, iov_count, 0, &iov, &i);
 		if (res < 0)
 			return res;
 
@@ -2078,33 +2074,32 @@ sg_remove_scat(struct sg_fd *sfp, struct sg_scatter_hold *schp)
  * appended to given struct sg_header object.
  */
 static int
-sg_read_oxfer(struct sg_request *srp, char __user *outp, int num_read_xfer)
+sg_rd_append(struct sg_request *srp, char __user *outp, int num_xfer)
 {
 	struct sg_scatter_hold *schp = &srp->data;
 	int k, num;
 
-	SG_LOG(4, srp->parentfp, "%s: num_xfer=%d\n", __func__, num_read_xfer);
-	if ((!outp) || (num_read_xfer <= 0))
+	SG_LOG(4, srp->parentfp, "%s: num_xfer=%d\n", __func__, num_xfer);
+	if (!outp || num_xfer <= 0)
 		return 0;
 
 	num = 1 << (PAGE_SHIFT + schp->page_order);
 	for (k = 0; k < schp->k_use_sg && schp->pages[k]; k++) {
-		if (num > num_read_xfer) {
+		if (num > num_xfer) {
 			if (copy_to_user(outp, page_address(schp->pages[k]),
-					   num_read_xfer))
+					   num_xfer))
 				return -EFAULT;
 			break;
 		} else {
 			if (copy_to_user(outp, page_address(schp->pages[k]),
 					   num))
 				return -EFAULT;
-			num_read_xfer -= num;
-			if (num_read_xfer <= 0)
+			num_xfer -= num;
+			if (num_xfer <= 0)
 				break;
 			outp += num;
 		}
 	}
-
 	return 0;
 }
 
-- 
2.25.1


  parent reply	other threads:[~2021-05-24  1:02 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-24  1:01 [PATCH v19 00/45] sg: add v4 interface Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 01/45] sg: move functions around Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 02/45] sg: remove typedefs, type+formatting cleanup Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 03/45] sg: sg_log and is_enabled Douglas Gilbert
2021-05-24  1:01 ` Douglas Gilbert [this message]
2021-05-24  1:01 ` [PATCH v19 05/45] sg: bitops in sg_device Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 06/45] sg: make open count an atomic Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 07/45] sg: move header to uapi section Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 08/45] sg: speed sg_poll and sg_get_num_waiting Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 09/45] sg: sg_allow_if_err_recovery and renames Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 10/45] sg: improve naming Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 11/45] sg: change rwlock to spinlock Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 12/45] sg: ioctl handling Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 13/45] sg: split sg_read Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 14/45] sg: sg_common_write add structure for arguments Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 15/45] sg: rework sg_vma_fault Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 16/45] sg: rework sg_mmap Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 17/45] sg: replace sg_allow_access Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 18/45] sg: rework scatter gather handling Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 19/45] sg: introduce request state machine Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 20/45] sg: sg_find_srp_by_id Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 21/45] sg: sg_fill_request_element Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 22/45] sg: printk change %p to %pK Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 23/45] sg: xarray for fds in device Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 24/45] sg: xarray for reqs in fd Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 25/45] sg: replace rq array with xarray Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 26/45] sg: sense buffer rework Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 27/45] sg: add sg v4 interface support Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 28/45] sg: rework debug info Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 29/45] sg: add 8 byte SCSI LUN to sg_scsi_id Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 30/45] sg: expand sg_comm_wr_t Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 31/45] sg: add sg_iosubmit_v3 and sg_ioreceive_v3 ioctls Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 32/45] sg: add some __must_hold macros Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 33/45] sg: move procfs objects to avoid forward decls Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 34/45] sg: protect multiple receivers Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 35/45] sg: first debugfs support Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 36/45] sg: rework mmap support Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 37/45] sg: defang allow_dio Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 38/45] sg: warn v3 write system call users Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 39/45] sg: add mmap_sz tracking Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 40/45] sg: remove rcv_done request state Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 41/45] sg: track lowest inactive and await indexes Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 42/45] sg: remove unit attention check for device changed Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 43/45] sg: no_dxfer: move to/from kernel buffers Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 44/45] sg: add blk_poll support Douglas Gilbert
2021-05-25  8:36   ` Hannes Reinecke
2021-05-24  1:01 ` [PATCH v19 45/45] sg: bump version to 4.0.12 Douglas Gilbert
2021-05-25  8:36   ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210524010147.94845-5-dgilbert@interlog.com \
    --to=dgilbert@interlog.com \
    --cc=hare@suse.com \
    --cc=hare@suse.de \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).