linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/1] scsi: ufs-mediatek: Fix HWReset timing
@ 2021-05-27 16:02 Alice
  2021-05-27 16:02 ` Alice
  0 siblings, 1 reply; 4+ messages in thread
From: Alice @ 2021-05-27 16:02 UTC (permalink / raw)
  To: stanley.chu, linux-scsi, martin.petersen, avri.altman, alim.akhtar, jejb
  Cc: wsd_upstream, peter.wang, chun-hung.wu, alice.chao, jonathan.hsu,
	powen.kao, cc.chou, chaotian.jing, jiajie.hao

From: "Alice.Chao" <alice.chao@mediatek.com>

HCI disable before HW Reset.
Because of the property of mtk ufshci,
we need to change reset flow to avoid potential issues.

Signed-off-by: Alice.Chao <alice.chao@mediatek.com>
---
 drivers/scsi/ufs/ufs-mediatek.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
index a981f261b304..c62603ed3d33 100644
--- a/drivers/scsi/ufs/ufs-mediatek.c
+++ b/drivers/scsi/ufs/ufs-mediatek.c
@@ -846,6 +846,9 @@ static int ufs_mtk_device_reset(struct ufs_hba *hba)
 {
 	struct arm_smccc_res res;
 
+	/* disable hba before device reset */
+	ufshcd_hba_stop(hba);
+
 	ufs_mtk_device_reset_ctrl(0, res);
 
 	/*
-- 
2.18.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 1/1] scsi: ufs-mediatek: Fix HWReset timing
  2021-05-27 16:02 [PATCH 1/1] scsi: ufs-mediatek: Fix HWReset timing Alice
@ 2021-05-27 16:02 ` Alice
  0 siblings, 0 replies; 4+ messages in thread
From: Alice @ 2021-05-27 16:02 UTC (permalink / raw)
  To: stanley.chu, linux-scsi, martin.petersen, avri.altman, alim.akhtar, jejb
  Cc: wsd_upstream, peter.wang, chun-hung.wu, alice.chao, jonathan.hsu,
	powen.kao, cc.chou, chaotian.jing, jiajie.hao

From: "Alice.Chao" <alice.chao@mediatek.com>

HCI disable before HW Reset.
Because of the property of mtk ufshci,
we need to change reset flow to avoid potential issues.

Change-Id: I3eb917fd2953b58dcf7e021286d1de71c9232cfb
Signed-off-by: Alice.Chao <alice.chao@mediatek.com>
CR-Id: ALPS05728133
Feature: UFS(Universal Flash Storage)
---
 drivers/scsi/ufs/ufs-mediatek.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
index a981f261b304..c62603ed3d33 100644
--- a/drivers/scsi/ufs/ufs-mediatek.c
+++ b/drivers/scsi/ufs/ufs-mediatek.c
@@ -846,6 +846,9 @@ static int ufs_mtk_device_reset(struct ufs_hba *hba)
 {
 	struct arm_smccc_res res;
 
+	/* disable hba before device reset */
+	ufshcd_hba_stop(hba);
+
 	ufs_mtk_device_reset_ctrl(0, res);
 
 	/*
-- 
2.18.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* RE: [PATCH 1/1] scsi: ufs-mediatek: Fix HWReset timing
  2021-05-27 15:58 ` [PATCH 1/1] scsi: ufs-mediatek: Fix HWReset timing Alice
@ 2021-05-27 16:39   ` Alim Akhtar
  0 siblings, 0 replies; 4+ messages in thread
From: Alim Akhtar @ 2021-05-27 16:39 UTC (permalink / raw)
  To: 'Alice',
	stanley.chu, linux-scsi, martin.petersen, avri.altman, jejb
  Cc: wsd_upstream, peter.wang, chun-hung.wu, jonathan.hsu, powen.kao,
	cc.chou, chaotian.jing, jiajie.hao



> -----Original Message-----
> From: Alice <alice.chao@mediatek.com>
> Sent: 27 May 2021 21:28
> To: stanley.chu@mediatek.com; linux-scsi@vger.kernel.org;
> martin.petersen@oracle.com; avri.altman@wdc.com;
> alim.akhtar@samsung.com; jejb@linux.ibm.com
> Cc: wsd_upstream@mediatek.com; peter.wang@mediatek.com; chun-
> hung.wu@mediatek.com; alice.chao@mediatek.com;
> jonathan.hsu@mediatek.com; powen.kao@mediatek.com;
> cc.chou@mediatek.com; chaotian.jing@mediatek.com;
> jiajie.hao@mediatek.com
> Subject: [PATCH 1/1] scsi: ufs-mediatek: Fix HWReset timing
> 
> From: "Alice.Chao" <alice.chao@mediatek.com>
> 
> HCI disable before HW Reset.
> Because of the property of mtk ufshci,
> we need to change reset flow to avoid potential issues.
> 
Please re-format the commit message and mention few wards about potential
issues.

> Change-Id: I3eb917fd2953b58dcf7e021286d1de71c9232cfb
Hmm, run a checkpatch before submitting any patch. 

> Signed-off-by: Alice.Chao <alice.chao@mediatek.com>
> CR-Id: ALPS05728133
What are these ID? Please remove.
> Feature: UFS(Universal Flash Storage)
Please check Documentation/process/submitting-patches.rst, before submitting
patches.

> ---
>  drivers/scsi/ufs/ufs-mediatek.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/scsi/ufs/ufs-mediatek.c
b/drivers/scsi/ufs/ufs-mediatek.c
> index a981f261b304..c62603ed3d33 100644
> --- a/drivers/scsi/ufs/ufs-mediatek.c
> +++ b/drivers/scsi/ufs/ufs-mediatek.c
> @@ -846,6 +846,9 @@ static int ufs_mtk_device_reset(struct ufs_hba *hba)
> {
>  	struct arm_smccc_res res;
> 
> +	/* disable hba before device reset */
> +	ufshcd_hba_stop(hba);
> +
>  	ufs_mtk_device_reset_ctrl(0, res);
> 
>  	/*
> --
> 2.18.0



^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/1] scsi: ufs-mediatek: Fix HWReset timing
  2021-05-27 15:58 [PATCH 1/1] scsi: ufs: Export ufshcd_hba_stop Alice
@ 2021-05-27 15:58 ` Alice
  2021-05-27 16:39   ` Alim Akhtar
  0 siblings, 1 reply; 4+ messages in thread
From: Alice @ 2021-05-27 15:58 UTC (permalink / raw)
  To: stanley.chu, linux-scsi, martin.petersen, avri.altman, alim.akhtar, jejb
  Cc: wsd_upstream, peter.wang, chun-hung.wu, alice.chao, jonathan.hsu,
	powen.kao, cc.chou, chaotian.jing, jiajie.hao

From: "Alice.Chao" <alice.chao@mediatek.com>

HCI disable before HW Reset.
Because of the property of mtk ufshci,
we need to change reset flow to avoid potential issues.

Change-Id: I3eb917fd2953b58dcf7e021286d1de71c9232cfb
Signed-off-by: Alice.Chao <alice.chao@mediatek.com>
CR-Id: ALPS05728133
Feature: UFS(Universal Flash Storage)
---
 drivers/scsi/ufs/ufs-mediatek.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
index a981f261b304..c62603ed3d33 100644
--- a/drivers/scsi/ufs/ufs-mediatek.c
+++ b/drivers/scsi/ufs/ufs-mediatek.c
@@ -846,6 +846,9 @@ static int ufs_mtk_device_reset(struct ufs_hba *hba)
 {
 	struct arm_smccc_res res;
 
+	/* disable hba before device reset */
+	ufshcd_hba_stop(hba);
+
 	ufs_mtk_device_reset_ctrl(0, res);
 
 	/*
-- 
2.18.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-05-27 16:42 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-27 16:02 [PATCH 1/1] scsi: ufs-mediatek: Fix HWReset timing Alice
2021-05-27 16:02 ` Alice
  -- strict thread matches above, loose matches on Subject: below --
2021-05-27 15:58 [PATCH 1/1] scsi: ufs: Export ufshcd_hba_stop Alice
2021-05-27 15:58 ` [PATCH 1/1] scsi: ufs-mediatek: Fix HWReset timing Alice
2021-05-27 16:39   ` Alim Akhtar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).