From: Guenter Roeck <linux@roeck-us.net>
To: Avri Altman <avri.altman@wdc.com>
Cc: "James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Bart Van Assche <bvanassche@acm.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Bean Huo <beanhuo@micron.com>
Subject: Re: [PATCH v7 2/2] scsi: ufs: Add temperature notification exception handling
Date: Wed, 15 Sep 2021 00:06:01 -0700 [thread overview]
Message-ID: <20210915070601.GB4174921@roeck-us.net> (raw)
In-Reply-To: <20210915060407.40-3-avri.altman@wdc.com>
On Wed, Sep 15, 2021 at 09:04:07AM +0300, Avri Altman wrote:
> The device may notify the host of an extreme temperature by using the
> exception event mechanism. The exception can be raised when the device’s
> Tcase temperature is either too high or too low.
>
> It is essentially up to the platform to decide what further actions need
> to be taken. leave a placeholder for a designated vop for that.
>
> Signed-off-by: Avri Altman <avri.altman@wdc.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/scsi/ufs/ufs-hwmon.c | 12 ++++++++++++
> drivers/scsi/ufs/ufshcd.c | 21 +++++++++++++++++++++
> drivers/scsi/ufs/ufshcd.h | 2 ++
> 3 files changed, 35 insertions(+)
>
> diff --git a/drivers/scsi/ufs/ufs-hwmon.c b/drivers/scsi/ufs/ufs-hwmon.c
> index 33b66736aaa4..74855491dc8f 100644
> --- a/drivers/scsi/ufs/ufs-hwmon.c
> +++ b/drivers/scsi/ufs/ufs-hwmon.c
> @@ -196,3 +196,15 @@ void ufs_hwmon_remove(struct ufs_hba *hba)
> hba->hwmon_device = NULL;
> kfree(data);
> }
> +
> +void ufs_hwmon_notify_event(struct ufs_hba *hba, u8 ee_mask)
> +{
> + if (!hba->hwmon_device)
> + return;
> +
> + if (ee_mask & MASK_EE_TOO_HIGH_TEMP)
> + hwmon_notify_event(hba->hwmon_device, hwmon_temp, hwmon_temp_max_alarm, 0);
> +
> + if (ee_mask & MASK_EE_TOO_LOW_TEMP)
> + hwmon_notify_event(hba->hwmon_device, hwmon_temp, hwmon_temp_min_alarm, 0);
> +}
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index ce22340024ce..debef631c89a 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -5642,6 +5642,24 @@ static void ufshcd_bkops_exception_event_handler(struct ufs_hba *hba)
> __func__, err);
> }
>
> +static void ufshcd_temp_exception_event_handler(struct ufs_hba *hba, u16 status)
> +{
> + u32 value;
> +
> + if (ufshcd_query_attr_retry(hba, UPIU_QUERY_OPCODE_READ_ATTR,
> + QUERY_ATTR_IDN_CASE_ROUGH_TEMP, 0, 0, &value))
> + return;
> +
> + dev_info(hba->dev, "exception Tcase %d\n", value - 80);
> +
> + ufs_hwmon_notify_event(hba, status & MASK_EE_URGENT_TEMP);
> +
> + /*
> + * A placeholder for the platform vendors to add whatever additional
> + * steps required
> + */
> +}
> +
> static int __ufshcd_wb_toggle(struct ufs_hba *hba, bool set, enum flag_idn idn)
> {
> u8 index;
> @@ -5821,6 +5839,9 @@ static void ufshcd_exception_event_handler(struct work_struct *work)
> if (status & hba->ee_drv_mask & MASK_EE_URGENT_BKOPS)
> ufshcd_bkops_exception_event_handler(hba);
>
> + if (status & hba->ee_drv_mask & MASK_EE_URGENT_TEMP)
> + ufshcd_temp_exception_event_handler(hba, status);
> +
> ufs_debugfs_exception_event(hba, status);
> out:
> ufshcd_scsi_unblock_requests(hba);
> diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
> index 021c858955af..92d05329de68 100644
> --- a/drivers/scsi/ufs/ufshcd.h
> +++ b/drivers/scsi/ufs/ufshcd.h
> @@ -1062,9 +1062,11 @@ static inline u8 ufshcd_wb_get_query_index(struct ufs_hba *hba)
> #ifdef CONFIG_SCSI_UFS_HWMON
> void ufs_hwmon_probe(struct ufs_hba *hba, u8 mask);
> void ufs_hwmon_remove(struct ufs_hba *hba);
> +void ufs_hwmon_notify_event(struct ufs_hba *hba, u8 ee_mask);
> #else
> static inline void ufs_hwmon_probe(struct ufs_hba *hba, u8 mask) {}
> static inline void ufs_hwmon_remove(struct ufs_hba *hba) {}
> +static inline void ufs_hwmon_notify_event(struct ufs_hba *hba, u8 ee_mask) {}
> #endif
>
> #ifdef CONFIG_PM
> --
> 2.17.1
>
next prev parent reply other threads:[~2021-09-15 7:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 6:04 [PATCH v7 0/2] Add temperature notification support Avri Altman
2021-09-15 6:04 ` [PATCH v7 1/2] scsi: ufs: Probe for " Avri Altman
2021-09-15 7:05 ` Guenter Roeck
2021-09-15 8:34 ` Bean Huo
2021-09-15 6:04 ` [PATCH v7 2/2] scsi: ufs: Add temperature notification exception handling Avri Altman
2021-09-15 7:06 ` Guenter Roeck [this message]
2021-09-15 9:05 ` Bean Huo
[not found] ` <CGME20210915060437epcas2p1f8bcdda5911050391b82be6c9831e4c2@epcms2p3>
2021-09-16 2:30 ` [PATCH v7 1/2] scsi: ufs: Probe for temperature notification support Daejun Park
[not found] ` <CGME20210915060436epcas2p326d8663ed23430529a5b4f9407eca8c9@epcms2p3>
2021-09-16 2:31 ` [PATCH v7 2/2] scsi: ufs: Add temperature notification exception handling Daejun Park
2021-09-22 4:08 ` [PATCH v7 0/2] Add temperature notification support Martin K. Petersen
2021-09-29 4:20 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210915070601.GB4174921@roeck-us.net \
--to=linux@roeck-us.net \
--cc=adrian.hunter@intel.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).