* [PATCH] scsi: qla1280: Use bitwise instead of arithmetic operator for flags
@ 2021-11-24 3:28 cgel.zte
0 siblings, 0 replies; only message in thread
From: cgel.zte @ 2021-11-24 3:28 UTC (permalink / raw)
To: mdr
Cc: jejb, martin.petersen, linux-scsi, linux-kernel, Changcheng Deng,
Zeal Robot
From: Changcheng Deng <deng.changcheng@zte.com.cn>
Fix the following coccicheck warnings:
./drivers/scsi/qla1280.c: 3719: sum of probable bitmasks, consider |
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
---
drivers/scsi/qla1280.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla1280.c b/drivers/scsi/qla1280.c
index 1dc56f4c89d8..1147a32ef488 100644
--- a/drivers/scsi/qla1280.c
+++ b/drivers/scsi/qla1280.c
@@ -3716,7 +3716,7 @@ qla1280_error_entry(struct scsi_qla_host *ha, struct response *pkt,
ha->outstanding_cmds[handle] = NULL;
/* Bad payload or header */
- if (pkt->entry_status & (BIT_3 + BIT_2)) {
+ if (pkt->entry_status & (BIT_3 | BIT_2)) {
/* Bad payload or header, set error status. */
/* CMD_RESULT(sp->cmd) = CS_BAD_PAYLOAD; */
CMD_RESULT(sp->cmd) = DID_ERROR << 16;
--
2.25.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-11-24 3:28 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-24 3:28 [PATCH] scsi: qla1280: Use bitwise instead of arithmetic operator for flags cgel.zte
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).