Re: [PATCH v2 1/2] mpt3sas: Reload SBR without rebooting HBA

From: kernel test robot <lkp@intel.com>
To: Ranjan Kumar <ranjan.kumar@broadcom.com>,
	linux-scsi@vger.kernel.org, martin.petersen@oracle.com
Cc: oe-kbuild-all@lists.linux.dev, sathya.prakash@broadcom.com,
	sreekanth.reddy@broadcom.com,
	Ranjan Kumar <ranjan.kumar@broadcom.com>
Subject: Re: [PATCH v2 1/2] mpt3sas: Reload SBR without rebooting HBA
Date: Thu, 28 Dec 2023 11:56:46 +0800	[thread overview]
Message-ID: <202312281141.jDyPezRn-lkp@intel.com> (raw)
In-Reply-To: <20231227110610.18276-2-ranjan.kumar@broadcom.com>

Hi Ranjan,

kernel test robot noticed the following build warnings:

[auto build test WARNING on jejb-scsi/for-next]
[also build test WARNING on mkp-scsi/for-next linus/master v6.7-rc7 next-20231222]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Ranjan-Kumar/mpt3sas-Reload-SBR-without-rebooting-HBA/20231227-191013
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
patch link:    https://lore.kernel.org/r/20231227110610.18276-2-ranjan.kumar%40broadcom.com
patch subject: [PATCH v2 1/2] mpt3sas: Reload SBR without rebooting HBA
config: x86_64-randconfig-161-20231228 (https://download.01.org/0day-ci/archive/20231228/202312281141.jDyPezRn-lkp@intel.com/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231228/202312281141.jDyPezRn-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312281141.jDyPezRn-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/scsi/mpt3sas/mpt3sas_ctl.c:2555: warning: Function parameter or member 'arg' not described in '_ctl_enable_diag_sbr_reload'

vim +2555 drivers/scsi/mpt3sas/mpt3sas_ctl.c

  2545	
  2546	/**
  2547	 * _ctl_enable_diag_sbr_reload - enable sbr reload bit
  2548	 * @ioc: per adapter object
  2549	 * @arg - user space buffer containing ioctl content
  2550	 *
  2551	 * Enable the SBR reload bit
  2552	 */
  2553	static int
  2554	_ctl_enable_diag_sbr_reload(struct MPT3SAS_ADAPTER *ioc, void __user *arg)
> 2555	{
  2556		u32 ioc_state, host_diagnostic;
  2557	
  2558		if (ioc->shost_recovery ||
  2559		    ioc->pci_error_recovery || ioc->is_driver_loading ||
  2560		    ioc->remove_host)
  2561			return -EAGAIN;
  2562	
  2563		ioc_state = mpt3sas_base_get_iocstate(ioc, 1);
  2564	
  2565		if (ioc_state != MPI2_IOC_STATE_OPERATIONAL)
  2566			return -EFAULT;
  2567	
  2568		host_diagnostic = ioc->base_readl(&ioc->chip->HostDiagnostic);
  2569	
  2570		if (host_diagnostic & MPI2_DIAG_SBR_RELOAD)
  2571			return 0;
  2572	
  2573		if (mutex_trylock(&ioc->hostdiag_unlock_mutex)) {
  2574			if (mpt3sas_base_unlock_and_get_host_diagnostic(ioc, &host_diagnostic)) {
  2575				mutex_unlock(&ioc->hostdiag_unlock_mutex);
  2576					return -EFAULT;
  2577			}
  2578		} else
  2579			return -EAGAIN;
  2580	
  2581		host_diagnostic |= MPI2_DIAG_SBR_RELOAD;
  2582		writel(host_diagnostic, &ioc->chip->HostDiagnostic);
  2583		host_diagnostic = ioc->base_readl(&ioc->chip->HostDiagnostic);
  2584		mpt3sas_base_lock_host_diagnostic(ioc);
  2585		mutex_unlock(&ioc->hostdiag_unlock_mutex);
  2586	
  2587		if (!(host_diagnostic & MPI2_DIAG_SBR_RELOAD)) {
  2588			ioc_err(ioc, "%s: Failed to set Diag SBR Reload Bit\n", __func__);
  2589			return -EFAULT;
  2590		}
  2591	
  2592		ioc_info(ioc, "%s: Successfully set the Diag SBR Reload Bit\n", __func__);
  2593		return 0;
  2594	}
  2595	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki