From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: Bart Van Assche <bvanassche@acm.org>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>,
linux-scsi@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH 05/13] scsi: ata: Declare 'ata_ncq_sdev_attrs' static
Date: Wed, 24 Nov 2021 17:54:35 +0900 [thread overview]
Message-ID: <26e883cd-3337-5875-47e1-d94f96be1ec5@opensource.wdc.com> (raw)
In-Reply-To: <20211124005217.2300458-6-bvanassche@acm.org>
On 2021/11/24 9:52, Bart Van Assche wrote:
> Fix the following kernel-doc warning:
>
> 'ata_ncq_sdev_attrs' is only used in one source file. Hence declare this
> array static.
>
> Fixes: c3f69c7f629f ("scsi: ata: Switch to attribute groups")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
> drivers/ata/libata-sata.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/libata-sata.c b/drivers/ata/libata-sata.c
> index 4e88597aa9df..5b78e86e3459 100644
> --- a/drivers/ata/libata-sata.c
> +++ b/drivers/ata/libata-sata.c
> @@ -922,7 +922,7 @@ DEVICE_ATTR(ncq_prio_enable, S_IRUGO | S_IWUSR,
> ata_ncq_prio_enable_show, ata_ncq_prio_enable_store);
> EXPORT_SYMBOL_GPL(dev_attr_ncq_prio_enable);
>
> -struct attribute *ata_ncq_sdev_attrs[] = {
> +static struct attribute *ata_ncq_sdev_attrs[] = {
> &dev_attr_unload_heads.attr,
> &dev_attr_ncq_prio_enable.attr,
> &dev_attr_ncq_prio_supported.attr,
>
Already fixed in rc2.
See commit cac7e8b5f5fa94e28d581fbb9e76cb1c0c7fd56a.
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2021-11-24 8:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-24 0:52 [PATCH 00/13] A series of small SCSI patches Bart Van Assche
2021-11-24 0:52 ` [PATCH 01/13] scsi: core: Suppress a kernel-doc warning Bart Van Assche
2021-11-24 0:52 ` [PATCH 02/13] scsi: core: Declare 'scsi_scan_type' static Bart Van Assche
2021-11-24 0:52 ` [PATCH 03/13] scsi: core: Show SCMD_LAST in text form Bart Van Assche
2021-11-24 0:52 ` [PATCH 04/13] scsi: a100u2w: Fix a kernel-doc warning Bart Van Assche
2021-11-24 0:52 ` [PATCH 05/13] scsi: ata: Declare 'ata_ncq_sdev_attrs' static Bart Van Assche
2021-11-24 8:54 ` Damien Le Moal [this message]
2021-11-29 19:37 ` Bart Van Assche
2021-11-24 0:52 ` [PATCH 06/13] scsi: atp870u: Fix a kernel-doc warning Bart Van Assche
2021-11-24 0:52 ` [PATCH 07/13] scsi: bfa: Declare 'bfad_im_vport_attrs' static Bart Van Assche
2021-11-24 0:52 ` [PATCH 08/13] scsi: dc395x: Fix a kernel-doc warning Bart Van Assche
2021-11-24 0:52 ` [PATCH 09/13] scsi: initio: " Bart Van Assche
2021-11-24 0:52 ` [PATCH 10/13] scsi: megaraid: " Bart Van Assche
2021-11-24 0:52 ` [PATCH 11/13] scsi: pm8001: Fix kernel-doc warnings Bart Van Assche
2021-11-24 6:08 ` Jinpu Wang
2021-11-24 0:52 ` [PATCH 12/13] scsi: pmcraid: Fix a kernel-doc warning Bart Van Assche
2021-11-24 0:52 ` [PATCH 13/13] scsi: Remove superfluous #include <linux/async.h> directives Bart Van Assche
[not found] ` <CGME20211124005259epcas2p30b07896d8dcdb3ec71ff1ae87e169a18@epcms2p3>
2021-11-24 1:54 ` Daejun Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26e883cd-3337-5875-47e1-d94f96be1ec5@opensource.wdc.com \
--to=damien.lemoal@opensource.wdc.com \
--cc=bvanassche@acm.org \
--cc=jaegeuk@kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=lkp@intel.com \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).