From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20F77C4CEC5 for ; Thu, 12 Sep 2019 13:12:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EB40B20856 for ; Thu, 12 Sep 2019 13:12:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="HnE6QibG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731952AbfILNMf (ORCPT ); Thu, 12 Sep 2019 09:12:35 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:44627 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731283AbfILNMe (ORCPT ); Thu, 12 Sep 2019 09:12:34 -0400 Received: by mail-pg1-f195.google.com with SMTP id i18so13461416pgl.11 for ; Thu, 12 Sep 2019 06:12:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=eDPbVXqU+y+RmPn4/ZLvHXxFmtHPu9FG57Z6VOzUMvY=; b=HnE6QibGc8QbXvgR7z4lNSDL09+NmGKGy1fRXULhjvG0xbmEdafAJkCDi0302zxTwt qBPwDfRYcQB7pUUuEdBpFzdGMwGnMo4BwjofoqTRT2+qK7/5cCDO40UvT4ULFlUtOzWU z5aajg2c+ulNJSH3EudIAIulziEwBpZphkcXIGpikHIGOXTeYK99PrDs43X1xUeKmjc4 vRVE60SnTPpsjQrfNkCwMLRLNhm38Eu7xU6Qo/5AeJ+CJE1ve6p8qsbZ7Tmna+66s5N6 cbui7ZzWXNWy377MilRPai/306n+XaMMeck8va3DiwUhi3Vh+LNL9HVtJocbHL8yNGyV HGcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=eDPbVXqU+y+RmPn4/ZLvHXxFmtHPu9FG57Z6VOzUMvY=; b=rBSze6mDW4nSDLz766u+44b2EbO6MzCfByEGpYDkbGkE7ojlqMNpqTgppEyLEPet7G sl6B5dA7V8RflOJMp63eJtp1r5iNg1okoEck/0e6douIcuM9rw4yU0tjOjXlfG4ZXK9Q ZZVdrI9E3oGjS1S8TZnTE/Adsjr0o/up6s9T6ncO11eQPdZ8WpK2gJsSTK61xu5SKA1m D4lN9R0thz38/uC5IDzUo4wEKnSIKgvsDzdiKjLl5Ee3900qmwPy2d1QxOCQ6X+xVnAr 558CDqhVNi6tqMIyn+ZL1snisD1xrBHwWIVuZp/KAQPyBCZ5xjR9v13UGURc++7qi/mG /f5A== X-Gm-Message-State: APjAAAXofwghsyObVuvCKO7pDEKmdtAnDPGVxwR4kw1dZFTZTVsciUe0 VTqJpi5fz8JmL5x+dW9o2T/fCg== X-Google-Smtp-Source: APXvYqy5IRnkfN40k2/B7q313u2BRWeMvX80jlePX/MlMV1tGW/e5n3Y99EGn/AhhLeBvPK61j8c0Q== X-Received: by 2002:a62:2787:: with SMTP id n129mr10490181pfn.45.1568293952678; Thu, 12 Sep 2019 06:12:32 -0700 (PDT) Received: from ?IPv6:2600:380:4b2e:3b64:29ff:2f14:b019:100? ([2600:380:4b2e:3b64:29ff:2f14:b019:100]) by smtp.gmail.com with ESMTPSA id m13sm24678837pgn.57.2019.09.12.06.12.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Sep 2019 06:12:31 -0700 (PDT) Subject: Re: [PATCH v2] fixup null q->dev checking in both block and scsi layer To: Stanley Chu , linux-scsi@vger.kernel.org, linux-block@vger.kernel.org, martin.petersen@oracle.com, jejb@linux.ibm.com, matthias.bgg@gmail.com Cc: linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, kuohong.wang@mediatek.com, peter.wang@mediatek.com, chun-hung.wu@mediatek.com, andy.teng@mediatek.com References: <1568277328-4597-1-git-send-email-stanley.chu@mediatek.com> From: Jens Axboe Message-ID: <2a285805-cdf3-fe7a-0d1a-9f53f821d025@kernel.dk> Date: Thu, 12 Sep 2019 07:12:28 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <1568277328-4597-1-git-send-email-stanley.chu@mediatek.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On 9/12/19 2:35 AM, Stanley Chu wrote: > Some devices may skip blk_pm_runtime_init() and have null pointer in > its request_queue->dev. For example, SCSI devices of UFS Well-Known > LUNs. > > Currently the null pointer is checked by the user of > blk_set_runtime_active(), i.e., scsi_dev_type_resume(). It is better > to check it by blk_set_runtime_active() itself instead of by its > users. Applied, thanks. -- Jens Axboe