From: dinghao.liu@zju.edu.cn
To: "Bean Huo (beanhuo)" <beanhuo@micron.com>
Cc: "kjlu@umn.edu" <kjlu@umn.edu>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Avri Altman" <avri.altman@wdc.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"Bart Van Assche" <bvanassche@acm.org>,
"Can Guo" <cang@codeaurora.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: RE: RE: [EXT] [PATCH] scsi: ufs-bsg: Fix runtime PM imbalance on error
Date: Sat, 23 May 2020 18:10:25 +0800 (GMT+08:00) [thread overview]
Message-ID: <2ca4e9a1.c1e27.1724103291c.Coremail.dinghao.liu@zju.edu.cn> (raw)
In-Reply-To: <SN6PR08MB5693D06B4B30D0A76824D2BBDBB40@SN6PR08MB5693.namprd08.prod.outlook.com>
> Hi, Dinghao
>
> > Thank you for your advice! Moving original pm_runtime_put_sync() to after
> > "out" label will influence an error path branched from
> > ups_bsg_verify_query_size(). So I think changing "goto out" to "break" is a good
> > idea. But in this case we may execute an extra
> > sg_copy_from_buffer() and an extra kfree() compared with unpatched version.
> > Does this matter?
> >
> What do you mean " unpatched version "?
>
> I see, below goto will bypass sg_copy_from_buffer() and an extra kfree()
> In case ufs_bsg_alloc_desc_buffer() fails.
>
That's exactly what I want to express. If using "break" is OK I will send
a new patch to fix this problem.
> Bean
>
Regaeds,
Dinghao
next prev parent reply other threads:[~2020-05-23 10:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 4:59 [PATCH] scsi: ufs-bsg: Fix runtime PM imbalance on error Dinghao Liu
2020-05-22 8:36 ` [EXT] " Bean Huo (beanhuo)
2020-05-22 8:54 ` dinghao.liu
2020-05-22 14:55 ` Bean Huo (beanhuo)
2020-05-23 10:10 ` dinghao.liu [this message]
2020-06-10 2:11 ` Martin K. Petersen
2020-06-10 7:16 ` Avri Altman
2020-06-16 3:46 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ca4e9a1.c1e27.1724103291c.Coremail.dinghao.liu@zju.edu.cn \
--to=dinghao.liu@zju.edu.cn \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=jejb@linux.ibm.com \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).