From: James Smart <james.smart@broadcom.com>
To: Daniel Wagner <dwagner@suse.de>, linux-scsi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Dick Kennedy <dick.kennedy@broadcom.com>,
James Smart <jsmart2021@gmail.com>
Subject: Re: [PATCH] scsi: lpfc: Check queue pointer before use
Date: Fri, 18 Oct 2019 14:40:27 -0700 [thread overview]
Message-ID: <3624b42a-712a-bab5-c325-7171f71a51e1@broadcom.com> (raw)
In-Reply-To: <20191018162111.8798-1-dwagner@suse.de>
On 10/18/2019 9:21 AM, Daniel Wagner wrote:
> The queue pointer might not be valid. The rest of the code checks the
> pointer before accessing it. lpfc_sli4_process_missed_mbox_completions
> is the only place where the check is missing.
>
> Fixes: 657add4e5e15 ("scsi: lpfc: Fix poor use of hardware queues if fewer irq vectors")
> Cc: James Smart <jsmart2021@gmail.com>
> Signed-off-by: Daniel Wagner <dwagner@suse.de>
> ---
> Hi,
>
> Not entirely sure if this correct. I tried to understand the logic of
> the mentioned patch but failed to grasps all the details. Anyway, we
> observe a crash in lpfc_sli4_process_missed_mbox_completions() while
> iterating the array. All but the last one entry has a valid pointer.
>
> Thanks,
> Daniel
>
> drivers/scsi/lpfc/lpfc_sli.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
> index 379c37451645..149966ba8a17 100644
> --- a/drivers/scsi/lpfc/lpfc_sli.c
> +++ b/drivers/scsi/lpfc/lpfc_sli.c
> @@ -7906,7 +7906,7 @@ lpfc_sli4_process_missed_mbox_completions(struct lpfc_hba *phba)
> if (sli4_hba->hdwq) {
> for (eqidx = 0; eqidx < phba->cfg_irq_chann; eqidx++) {
> eq = phba->sli4_hba.hba_eq_hdl[eqidx].eq;
> - if (eq->queue_id == sli4_hba->mbx_cq->assoc_qid) {
> + if (eq && eq->queue_id == sli4_hba->mbx_cq->assoc_qid) {
> fpeq = eq;
> break;
> }
looks fine. Thanks!
Reviewed by: James Smart <james.smart@broadcom.com>
-- james
next prev parent reply other threads:[~2019-10-18 21:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 16:21 [PATCH] scsi: lpfc: Check queue pointer before use Daniel Wagner
2019-10-18 21:40 ` James Smart [this message]
2019-10-18 22:00 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3624b42a-712a-bab5-c325-7171f71a51e1@broadcom.com \
--to=james.smart@broadcom.com \
--cc=dick.kennedy@broadcom.com \
--cc=dwagner@suse.de \
--cc=jsmart2021@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).