From: John Garry <john.garry@huawei.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: <jejb@linux.ibm.com>, <martin.petersen@oracle.com>,
<lenb@kernel.org>, <rjw@rjwysocki.net>, <tglx@linutronix.de>,
<maz@kernel.org>, <linux-scsi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linuxarm@huawei.com>,
<linux-acpi@vger.kernel.org>, <dwagner@suse.de>
Subject: Re: [PATCH v5 4/5] Driver core: platform: Add devm_platform_get_irqs_affinity()
Date: Wed, 9 Dec 2020 19:04:02 +0000 [thread overview]
Message-ID: <36730230-9fd7-8c6c-b997-328beea2fc31@huawei.com> (raw)
In-Reply-To: <X9EYRNDXS1Xcy4iU@kroah.com>
On 09/12/2020 18:32, Greg KH wrote:
> On Wed, Dec 02, 2020 at 06:36:56PM +0800, John Garry wrote:
>> Drivers for multi-queue platform devices may also want managed interrupts
>> for handling HW queue completion interrupts, so add support.
>
Hi Greg,
> Why would a platform device want all of this? Shouldn't such a device
> be on a "real" bus instead?
For this HW version, the device is on the system bus, directly
addressable by the CPU.
Motivation is that I wanted to switch the HW completion queues to use
managed interrupts.
>
> What in-kernel driver needs this complexity? I can't take new apis
> without a real user in the tree, sorry.
It's in the final patch in the series
https://lore.kernel.org/linux-scsi/1606905417-183214-1-git-send-email-john.garry@huawei.com/T/#m0df7e7cd6f0819b99aaeb6b7f8939ef1e17b8a83.
I don't anticipate a huge number of users of this API in future, as most
multi-queue devices are PCI devices; so we could do the work of this API
in the driver itself, but the preference was not to export genirq
functions like irq_update_affinity_desc() or
irq_create_affinity_masks(), and rather have a common helper in the core
platform code.
Thanks,
John
next prev parent reply other threads:[~2020-12-09 19:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 10:36 [PATCH v5 0/5] Support managed interrupts for platform devices John Garry
2020-12-02 10:36 ` [PATCH v5 1/5] genirq/affinity: Add irq_update_affinity_desc() John Garry
2020-12-02 10:36 ` [PATCH v5 2/5] resource: Add irqresource_disabled() John Garry
2020-12-02 10:36 ` [PATCH v5 3/5] ACPI: Drop acpi_dev_irqresource_disabled() John Garry
2020-12-02 10:36 ` [PATCH v5 4/5] Driver core: platform: Add devm_platform_get_irqs_affinity() John Garry
2020-12-09 18:32 ` Greg KH
2020-12-09 19:04 ` John Garry [this message]
2020-12-09 19:13 ` Greg KH
2020-12-09 19:36 ` John Garry
2020-12-09 19:39 ` Marc Zyngier
2020-12-10 10:10 ` John Garry
2020-12-10 15:29 ` Greg KH
2020-12-10 16:37 ` John Garry
2020-12-02 10:36 ` [PATCH v5 5/5] scsi: hisi_sas: Expose HW queues for v2 hw John Garry
2020-12-11 16:56 ` John Garry
2020-12-11 17:20 ` Martin K. Petersen
2020-12-11 17:33 ` John Garry
2020-12-11 15:01 ` [PATCH v5 0/5] Support managed interrupts for platform devices Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36730230-9fd7-8c6c-b997-328beea2fc31@huawei.com \
--to=john.garry@huawei.com \
--cc=dwagner@suse.de \
--cc=gregkh@linuxfoundation.org \
--cc=jejb@linux.ibm.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=martin.petersen@oracle.com \
--cc=maz@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).