From: Sagi Grimberg <sagi@grimberg.me>
To: Ming Lei <ming.lei@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
linux-scsi@vger.kernel.org, Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH 3/5] blk-mq: add helper of blk_mq_global_quiesce_wait()
Date: Mon, 22 Nov 2021 15:55:36 +0200 [thread overview]
Message-ID: <38b9661e-c5b8-ae18-f2ab-b30f9d3e7115@grimberg.me> (raw)
In-Reply-To: <YZuagPbZJ6CjiUNi@T590>
>>> Add helper of blk_mq_global_quiesce_wait() for supporting to quiesce
>>> queues in parallel, then we can just wait once if global quiesce wait
>>> is allowed.
>>
>> blk_mq_global_quiesce_wait() is a poor name... global is scope-less and
>> obviously it has a scope.
>
> How about blk_mq_shared_quiesce_wait()? or any suggestion?
Shared between what?
Maybe if the queue has a non-blocking tagset, it can have a "quiesced"
flag that is cleared in unquiesce? then the callers can just continue
to iterate but will only wait the rcu grace period once.
next prev parent reply other threads:[~2021-11-22 13:55 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 2:18 [PATCH 0/5] blk-mq: quiesce improvement Ming Lei
2021-11-19 2:18 ` [PATCH 1/5] blk-mq: move srcu from blk_mq_hw_ctx to request_queue Ming Lei
2021-11-19 4:30 ` Bart Van Assche
2021-11-19 8:10 ` Ming Lei
2021-11-22 7:48 ` Sagi Grimberg
2021-11-22 13:08 ` Ming Lei
2021-11-22 13:47 ` Sagi Grimberg
2021-11-19 2:18 ` [PATCH 2/5] blk-mq: rename hctx_lock & hctx_unlock Ming Lei
2021-11-22 7:53 ` Sagi Grimberg
2021-11-22 13:20 ` Ming Lei
2021-11-22 13:50 ` Sagi Grimberg
2021-11-23 0:08 ` Ming Lei
2021-11-23 8:54 ` Sagi Grimberg
2021-11-22 9:00 ` Christoph Hellwig
2021-11-19 2:18 ` [PATCH 3/5] blk-mq: add helper of blk_mq_global_quiesce_wait() Ming Lei
2021-11-22 7:56 ` Sagi Grimberg
2021-11-22 8:00 ` Sagi Grimberg
2021-11-22 13:26 ` Ming Lei
2021-11-22 13:55 ` Sagi Grimberg [this message]
2021-11-23 0:17 ` Ming Lei
2021-11-23 9:00 ` Sagi Grimberg
2021-11-30 2:33 ` Ming Lei
2021-12-08 12:49 ` Sagi Grimberg
2021-12-10 2:02 ` Ming Lei
2021-11-19 2:18 ` [PATCH 4/5] nvme: quiesce namespace queue in parallel Ming Lei
2021-11-22 8:07 ` Sagi Grimberg
2021-11-23 0:13 ` Ming Lei
2021-11-19 2:18 ` [PATCH 5/5] scsi: use blk-mq quiesce APIs to implement scsi_host_block Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38b9661e-c5b8-ae18-f2ab-b30f9d3e7115@grimberg.me \
--to=sagi@grimberg.me \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).