From: Bart Van Assche <bvanassche@acm.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
Jaegeuk Kim <jaegeuk@kernel.org>,
scsi <linux-scsi@vger.kernel.org>, Ming Lei <ming.lei@redhat.com>,
Hannes Reinecke <hare@suse.de>,
John Garry <john.garry@huawei.com>,
ericspero@icloud.com, jason600.groome@gmail.com,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-ide@vger.kernel.org,
James Bottomley <James.Bottomley@hansenpartnership.com>
Subject: Re: [PATCH v2 2/2] scsi: sd: Rework asynchronous resume support
Date: Mon, 15 Aug 2022 06:49:12 -0700 [thread overview]
Message-ID: <40700595-8c83-1b61-ea93-ea9554bfb2db@acm.org> (raw)
In-Reply-To: <CAMuHMdW7nGxV_3Z2JV_TCM+WtTdYv5P+0cE6Tw=6krcseNCdAw@mail.gmail.com>
On 8/15/22 03:13, Geert Uytterhoeven wrote:
> Showing all locks held in the system:
> 1 lock held by rcu_tasks_kthre/10:
> #0: ffff800009575c38 (rcu_tasks.tasks_gp_mutex){+.+.}-{3:3}, at:
> rcu_tasks_one_gp+0x34/0x4c8
> 4 locks held by kworker/0:10/104:
> #0: ffff0004c0008738 ((wq_completion)events){+.+.}-{0:0}, at:
> process_one_work+0x1f4/0x6a0
> #1: ffff80000a90bde0
> ((work_completion)(&ap->scsi_rescan_task)){+.+.}-{0:0}, at:
> process_one_work+0x1f4/0x6a0
> #2: ffff0004c2b6bf60 (&ap->scsi_scan_mutex){+.+.}-{3:3}, at:
> ata_scsi_dev_rescan+0x28/0x118
> #3: ffff0004c2902368 (&dev->mutex){....}-{3:3}, at:
> scsi_rescan_device+0x28/0x78
> 1 lock held by in:imklog/636:
> #0: ffff0004c5ee86e8 (&f->f_pos_lock){+.+.}-{3:3}, at: __fdget_pos+0x54/0x68
> 1 lock held by hd/1013:
> #0: ffff0004c06388b8 (mapping.invalidate_lock#2){.+.+}-{3:3}, at:
> page_cache_ra_unbounded+0x64/0x1a8
Thank you for having shared this information. I will take a closer look
and see what I can derive from the above information.
> I've just tried with a USB storage device on the same platform,
> and it can be read fine after s2idle. So it looks like the issue
> is related to SATA.
Unfortunately the above does not learn us anything new. The code
modified by commit 88f1669019bd ("scsi: sd: Rework asynchronous resume
support") is only called if sdev->manage_start_stop != 1. Only the SATA
code, the Firewire code and the manage_start_stop sysfs attribute store
method set that member variable:
$ git grep -nH 'manage_start_stop = '
drivers/ata/libata-scsi.c:1083: sdev->manage_start_stop = 1;
drivers/firewire/sbp2.c:1521: sdev->manage_start_stop = 1;
drivers/scsi/sd.c:240: sdp->manage_start_stop = v;
Would it be possible to share the output of the command below? That
should reveal which ATA driver is active on the test setup.
find /sys -name proc_name | xargs grep -aH .
Thanks,
Bart.
next prev parent reply other threads:[~2022-08-15 13:49 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 19:57 [PATCH v2 0/2] Reduce ATA disk resume time Bart Van Assche
2022-06-30 19:57 ` [PATCH v2 1/2] scsi: core: Move the definition of SCSI_QUEUE_DELAY Bart Van Assche
2022-06-30 19:57 ` [PATCH v2 2/2] scsi: sd: Rework asynchronous resume support Bart Van Assche
2022-07-19 9:26 ` Geert Uytterhoeven
2022-07-19 18:14 ` Bart Van Assche
2022-07-20 7:26 ` Geert Uytterhoeven
2022-07-20 7:47 ` Geert Uytterhoeven
2022-07-20 16:51 ` Bart Van Assche
2022-07-20 17:44 ` Geert Uytterhoeven
2022-07-20 18:04 ` Bart Van Assche
2022-07-21 8:07 ` Geert Uytterhoeven
2022-07-21 18:14 ` Bart Van Assche
2022-07-22 8:53 ` Geert Uytterhoeven
2022-07-22 17:56 ` Bart Van Assche
2022-08-12 10:48 ` Geert Uytterhoeven
2022-08-12 15:53 ` Bart Van Assche
2022-08-15 10:13 ` Geert Uytterhoeven
2022-08-15 13:49 ` Bart Van Assche [this message]
2022-08-15 18:26 ` Geert Uytterhoeven
2022-08-16 20:21 ` Bart Van Assche
2022-08-17 8:53 ` Sergey Shtylyov
2022-08-17 19:07 ` Vlastimil Babka
2022-08-17 19:28 ` Bart Van Assche
2022-08-28 11:52 ` [PATCH v2 2/2] scsi: sd: Rework asynchronous resume support #forregzbot Thorsten Leemhuis
2022-07-21 5:40 ` [PATCH v2 2/2] scsi: sd: Rework asynchronous resume support Hannes Reinecke
2022-07-07 21:07 ` [PATCH v2 0/2] Reduce ATA disk resume time Martin K. Petersen
2022-07-14 4:22 ` Martin K. Petersen
-- strict thread matches above, loose matches on Subject: below --
2022-06-29 23:56 Bart Van Assche
2022-06-29 23:56 ` [PATCH v2 2/2] scsi: sd: Rework asynchronous resume support Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40700595-8c83-1b61-ea93-ea9554bfb2db@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=ericspero@icloud.com \
--cc=geert@linux-m68k.org \
--cc=hare@suse.de \
--cc=jaegeuk@kernel.org \
--cc=jason600.groome@gmail.com \
--cc=john.garry@huawei.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).