From: Jeff Garzik <jeff@garzik.org>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: Mike Anderson <andmike@us.ibm.com>,
linux-scsi <linux-scsi@vger.kernel.org>,
"Tarte, Robert" <Robert_Tarte@adaptec.com>
Subject: Re: [RFC] aic94xx: attaching to the sas transport class
Date: Mon, 06 Mar 2006 11:37:54 -0500 [thread overview]
Message-ID: <440C6562.7060309@garzik.org> (raw)
In-Reply-To: <1141657981.3167.3.camel@mulgrave.il.steeleye.com>
James Bottomley wrote:
> On Mon, 2006-03-06 at 00:26 -0800, Mike Anderson wrote:
>
>>Ran into a issue that on the first load I did not have the
>>attach_HostRAID=1 that I need for my model of card so when I went to do a
>>modprobe -r; modprobe I got an oops. The patch below helps with the
>>describe case, but does not fix the problem of not being able to unload if
>>devices are found.
>
>
> Yes, that's part of the refcounting problems. Eventually this will
> either become a transport class in its own right or an adjunct library
> to the sas transport class (in which case I'll make it inherit
> refcounting).
>
> In the meantime attach_HostRAID shouldn't be a parameter, so I'll just
> get rid of it as well.
>
> James
>
> diff --git a/drivers/scsi/aic94xx/aic94xx_init.c b/drivers/scsi/aic94xx/aic94xx_init.c
> index f0c5cf2..924075d 100644
> --- a/drivers/scsi/aic94xx/aic94xx_init.c
> +++ b/drivers/scsi/aic94xx/aic94xx_init.c
> @@ -41,12 +41,6 @@
> /* The format is "version.release.patchlevel" */
> #define ASD_DRIVER_VERSION "1.0.2"
>
> -static int attach_HostRAID = 0;
> -module_param_named(attach_HostRAID, attach_HostRAID, int, S_IRUGO|S_IWUSR);
> -MODULE_PARM_DESC(attach_HostRAID, "\n"
> - "\tEnable(1) or disable(0) attaching to HostRAID enabled host adapters.\n"
> - "\tDefault: 0");
> -
> static int use_msi = 0;
> module_param_named(use_msi, use_msi, int, S_IRUGO);
> MODULE_PARM_DESC(use_msi, "\n"
> @@ -541,13 +535,6 @@ static int __devinit asd_pci_probe(struc
> struct asd_ha_struct *asd_ha;
> int err;
>
> - if (dev->class == (PCI_CLASS_STORAGE_RAID << 8) && !attach_HostRAID) {
> - asd_printk("will not attach to HostRAID enabled device %s, "
> - "unless attach_HostRAID parameter is set\n",
> - pci_name(dev));
> - return -ENODEV;
> - }
> -
ACK, I meant to do this one myself.
next prev parent reply other threads:[~2006-03-06 16:37 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-02 22:38 [RFC] aic94xx: attaching to the sas transport class James Bottomley
2006-03-02 23:13 ` Mike Anderson
2006-03-03 2:16 ` Mark Rustad
2006-03-03 4:04 ` Randy.Dunlap
2006-03-03 16:51 ` Mark Rustad
2006-03-03 15:51 ` Stefan Richter
2006-03-03 18:24 ` Luben Tuikov
2006-03-03 4:34 ` James Bottomley
2006-03-04 1:47 ` Alexis Bruemmer
2006-03-03 10:26 ` Luben Tuikov
2006-03-03 16:12 ` Stefan Richter
2006-03-03 18:26 ` Luben Tuikov
2006-03-03 10:14 ` Luben Tuikov
2006-03-03 15:23 ` James Bottomley
2006-03-03 15:58 ` Stefan Richter
2006-03-03 16:26 ` James Bottomley
2006-03-03 17:03 ` Mike Anderson
2006-03-03 17:28 ` Jeff Garzik
2006-03-06 18:30 ` Douglas Gilbert
2006-03-03 18:20 ` Luben Tuikov
2006-03-06 8:26 ` Mike Anderson
2006-03-06 15:13 ` James Bottomley
2006-03-06 16:37 ` Jeff Garzik [this message]
2006-03-18 1:45 ` [PATCH] " Alexis Bruemmer
2006-03-18 2:05 ` Alexis Bruemmer
2006-03-18 15:24 ` James Bottomley
2006-03-20 5:53 ` Mike Anderson
2006-03-03 16:39 [RFC] " Robert Tarte
2006-03-04 3:01 Tarte, Robert
2006-03-04 4:09 ` James Bottomley
2006-03-04 8:50 ` Luben Tuikov
2006-03-06 19:35 ` Mike Anderson
2006-03-06 19:50 ` James Bottomley
2006-03-07 0:44 ` Alexis Bruemmer
2006-03-08 15:15 ` James Bottomley
2006-03-09 17:06 ` Alexis Bruemmer
2006-03-09 18:05 ` Mike Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=440C6562.7060309@garzik.org \
--to=jeff@garzik.org \
--cc=James.Bottomley@SteelEye.com \
--cc=Robert_Tarte@adaptec.com \
--cc=andmike@us.ibm.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).