From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5226EC4740C for ; Mon, 9 Sep 2019 16:56:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3086321479 for ; Mon, 9 Sep 2019 16:56:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727780AbfIIQ4i (ORCPT ); Mon, 9 Sep 2019 12:56:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55622 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726415AbfIIQ4i (ORCPT ); Mon, 9 Sep 2019 12:56:38 -0400 Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D836E4E908 for ; Mon, 9 Sep 2019 16:56:37 +0000 (UTC) Received: by mail-wr1-f72.google.com with SMTP id 32so3217245wrk.15 for ; Mon, 09 Sep 2019 09:56:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to; bh=b+DYBvL0oEEFzvAdvWpG5+5SFlJp7gZgu0SZ3ZeObvI=; b=jOH4inH1xGVPr2CtxFrXY3d38gc3U1s3aQK2DByOZZYrBX1ik3bhNCGUi5qAJvlWYA Vc1UEYwSjX8xDtrfyqVO0wN3OHsGETPTGRrBUWAfYhie/X5Tv93v1XPPKFuxM1j5Azx3 k86B6Q+6MBBaVtsCFCUA3XMdIi3Gm1/fdatsyOk1KoFL4VmivER9wvPDv9vbUzWVB15l oxAIkfXG/gHVViLbjAHin+nnli9SexmPNvlZJJxMSFhnAAVM29UNzb94VD6WuT7NuQ9I 3pkjbLSTZuZLOEdU8uiYHo+OdI+C3y7HtHGm0ICgS2Env1mRaqNQrFcL4RYH7IRlF4EJ qzsw== X-Gm-Message-State: APjAAAUCYYkSfQnlodN6zk8GvPL3zeNqp6W1SdH+B94wacrpl03EB3tp b8/I1IBNZxdTYBqDqZmL2n50khLi6V347gdLRt67sFXUt6ByMsN4Am7RTa3PK1WMuJ+hfXasHbt 0J3fue64iET7k/B+3QAi58g== X-Received: by 2002:adf:e342:: with SMTP id n2mr2723312wrj.341.1568048196574; Mon, 09 Sep 2019 09:56:36 -0700 (PDT) X-Google-Smtp-Source: APXvYqwCDEHfmFTtFBYf4wpg2xKJ2cjZDTuhPEW8XcTtrVh3SrWj7ioRNCGl/I1N77Z+ytfjL6XmFA== X-Received: by 2002:adf:e342:: with SMTP id n2mr2723289wrj.341.1568048196307; Mon, 09 Sep 2019 09:56:36 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:4580:a289:2f55:eec1? ([2001:b07:6468:f312:4580:a289:2f55:eec1]) by smtp.gmail.com with ESMTPSA id q15sm18613985wrg.65.2019.09.09.09.56.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Sep 2019 09:56:35 -0700 (PDT) Subject: Re: [PATCH v2] scsi: virtio_scsi: unplug LUNs when events missed To: Stefan Hajnoczi , Matt Lupfer Cc: "mst@redhat.com" , "jasowang@redhat.com" , "jejb@linux.ibm.com" , "martin.petersen@oracle.com" , "virtualization@lists.linux-foundation.org" , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20190905181903.29756-1-mlupfer@ddn.com> <20190906085409.GC5900@stefanha-x1.localdomain> From: Paolo Bonzini Openpgp: preference=signencrypt Message-ID: <45d4fc47-cfc2-b7ae-e147-fb993a77e9e5@redhat.com> Date: Mon, 9 Sep 2019 18:55:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190906085409.GC5900@stefanha-x1.localdomain> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="pxnQuVbtWYEwmX3SJy3OhOXnAXOYEWRNZ" Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --pxnQuVbtWYEwmX3SJy3OhOXnAXOYEWRNZ Content-Type: multipart/mixed; boundary="KlMsZ2txnG2HaPm51dmD2esB01PSzQkME"; protected-headers="v1" From: Paolo Bonzini To: Stefan Hajnoczi , Matt Lupfer Cc: "mst@redhat.com" , "jasowang@redhat.com" , "jejb@linux.ibm.com" , "martin.petersen@oracle.com" , "virtualization@lists.linux-foundation.org" , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Message-ID: <45d4fc47-cfc2-b7ae-e147-fb993a77e9e5@redhat.com> Subject: Re: [PATCH v2] scsi: virtio_scsi: unplug LUNs when events missed References: <20190905181903.29756-1-mlupfer@ddn.com> <20190906085409.GC5900@stefanha-x1.localdomain> In-Reply-To: <20190906085409.GC5900@stefanha-x1.localdomain> --KlMsZ2txnG2HaPm51dmD2esB01PSzQkME Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 06/09/19 10:54, Stefan Hajnoczi wrote: > On Thu, Sep 05, 2019 at 06:19:28PM +0000, Matt Lupfer wrote: >> The event handler calls scsi_scan_host() when events are missed, which= >> will hotplug new LUNs. However, this function won't remove any >> unplugged LUNs. The result is that hotunplug doesn't work properly wh= en >> the number of unplugged LUNs exceeds the event queue size (currently 8= ). >> >> Scan existing LUNs when events are missed to check if they are still >> present. If not, remove them. >> >> Signed-off-by: Matt Lupfer >> --- >> drivers/scsi/virtio_scsi.c | 33 +++++++++++++++++++++++++++++++++ >> 1 file changed, 33 insertions(+) >=20 > Please include a changelog in future patch revisions. For example: >=20 > Signed-off-by: ... > --- > v2: > * Replaced magic constants with sd.h constants [Michael] >=20 > Just C and virtio code review, no SCSI specifics: >=20 > Reviewed-by: Stefan Hajnoczi >=20 Acked-by: Paolo Bonzini --KlMsZ2txnG2HaPm51dmD2esB01PSzQkME-- --pxnQuVbtWYEwmX3SJy3OhOXnAXOYEWRNZ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEE8TM4V0tmI4mGbHaCv/vSX3jHroMFAl12hBQACgkQv/vSX3jH roNf/QgAmxUxJG1dOWyJiM9cOE05ZHpVBvjYtllR4MHb7M3HkgznPc7bAe3ojMCh MjjpnhamcSKKTKtx9cgDK1bh8uj8viucaOZ43r0/P+npJO8XsdwwAlzfx5WMQ/Al qEaNVoX1KUxdWZAEYS1y52JmEvOf+0SlmaeJZMYQOWSJHepaM3d7l2vslFhZMIdt y054MXFZiJxyEB/AE8R/Xy7LPe9/CHliHqxDBMVjLYRFuUeqtkgAXjKUVsThUsGt EIKONYmN0aQ+Nl8bphUlxHhVVUgCTZ+YP/OCQqAOWtGKpINsFKBcvipeJeAVj3id Z7Jdh+v01Bs92VJ3BdQHgIbvvRulCA== =O1le -----END PGP SIGNATURE----- --pxnQuVbtWYEwmX3SJy3OhOXnAXOYEWRNZ--