Problem with scsi device sysfs attributes

[Damien Le Moal <damien.lemoal@opensource.wdc.com>]

Bart,

Your patch 92c4b58b15c5 ("scsi: core: Register sysfs attributes earlier")
modified the scsi device sysfs attributes initialization to use the scsi
template shost_groups and sdev_groups for adding attributes using groups instead
of arrays of attrs. However, this patch completely removed the
sysfs_create_groups() call to actually create the attributes listed in the groups.

As a result, I see many missing sysfs device attributes for at least ahci (e.g.
ncq_prio_enavle, ncq_prio_supported), but I suspect other device types may have
similar problems.

I do not see where the attribute groups in the arrray sdev->gendev_attr_groups
are registered with sysfs. In fact, it looks like sdev->gendev_attr_groups is
referenced only in scsi_sysfs.c but only for initializing it. It is never used
to actually register the attr groups... Am I missing something ?

This is at least breaking NCQ priority support right now. Did your patch
92c4b58b15c5 remove too much code ? Shouldn't we have a call to
sysfs_create_groups() somewhere ? I think that should be in
scsi_sysfs_device_initialize() but I am not 100% sure.



-- 
Damien Le Moal
Western Digital Research