linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Lee Duncan <lduncan@suse.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>
Cc: linux-scsi@vger.kernel.org, Quinn Tran <qutran@marvell.com>,
	Mike Christie <michael.christie@oracle.com>,
	Daniel Wagner <dwagner@suse.de>,
	Himanshu Madhani <himanshu.madhani@oracle.com>
Subject: Re: [PATCH v2 4/6] qla2xxx: Suppress Coverity complaints about dseg_r*
Date: Thu, 18 Mar 2021 12:10:43 -0700	[thread overview]
Message-ID: <4f784043-1ea3-0aee-d927-ce9ccaeeeb09@acm.org> (raw)
In-Reply-To: <b04f8794-caa7-a21a-0c5f-363dd4ea6e43@suse.com>

On 3/18/21 9:00 AM, Lee Duncan wrote:
> I dislike such an uncommented change just to keep a tool happy. Could
> you add a comment in qla_mr.h saying why these are one-element-long
> arrays, just so nobody optimizes those out later?
I will add a comment. Thanks for the feedback.

Bart.

  reply	other threads:[~2021-03-18 19:11 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-18  3:28 [PATCH v2 0/6] qla2xxx patches for kernel v5.12 and v5.13 Bart Van Assche
2021-03-18  3:28 ` [PATCH v2 1/6] Revert "qla2xxx: Make sure that aborted commands are freed" Bart Van Assche
2021-03-18  3:28 ` [PATCH v2 2/6] qla2xxx: Constify struct qla_tgt_func_tmpl Bart Van Assche
2021-03-18 16:01   ` Lee Duncan
2021-03-18  3:28 ` [PATCH v2 3/6] qla2xxx: Fix endianness annotations Bart Van Assche
2021-03-18 16:01   ` Lee Duncan
2021-03-18  3:28 ` [PATCH v2 4/6] qla2xxx: Suppress Coverity complaints about dseg_r* Bart Van Assche
2021-03-18 16:00   ` Lee Duncan
2021-03-18 19:10     ` Bart Van Assche [this message]
2021-03-18  3:28 ` [PATCH v2 5/6] qla2xxx: Simplify qla8044_minidump_process_control() Bart Van Assche
2021-03-18 16:03   ` Lee Duncan
2021-03-18  3:28 ` [PATCH v2 6/6] qla2xxx: Always check the return value of qla24xx_get_isp_stats() Bart Van Assche
2021-03-18  8:08   ` Daniel Wagner
2021-03-18 19:11     ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4f784043-1ea3-0aee-d927-ce9ccaeeeb09@acm.org \
    --to=bvanassche@acm.org \
    --cc=dwagner@suse.de \
    --cc=himanshu.madhani@oracle.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=lduncan@suse.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=michael.christie@oracle.com \
    --cc=qutran@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).