From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>,
Mike Christie <michael.christie@oracle.com>
Cc: "kbusch@kernel.org" <kbusch@kernel.org>,
"axboe@fb.com" <axboe@fb.com>, "hch@lst.de" <hch@lst.de>,
"sagi@grimberg.me" <sagi@grimberg.me>,
"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH v3 0/4] block/scsi/nvme: Add error codes for PR ops
Date: Tue, 29 Nov 2022 04:18:19 +0000 [thread overview]
Message-ID: <538bcade-c453-e6f8-4530-808a9bf2140a@nvidia.com> (raw)
In-Reply-To: <yq1o7sumo0c.fsf@ca-mkp.ca.oracle.com>
On 11/25/22 18:48, Martin K. Petersen wrote:
>
> Mike,
>
>> The following patches were made over Linus's tree and allow the
>> PR/pr_ops users to handle errors without having to know the device
>> type and also for SCSI handle devices that require the sense
>> code. Currently, we return a -Exyz type of error code if the PR call
>> fails before the drivers can send the command and a device specific
>> error code if it's queued. The problem is that the callers don't
>> always know the device type so they can't check for specific errors
>> like reservation conflicts, or transport errors or invalid operations.
>>
>> These patches add common error codes which callers can check for.
>
> This looks OK to me. Not sure which tree makes the most sense to funnel
> this through?
>
> Acked-by: Martin K. Petersen <martin.petersen@oracle.com>
>
perhaps a block tree since it has block/scsi/nvme ?
-ck
next prev parent reply other threads:[~2022-11-29 4:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 3:25 [PATCH v3 0/4] block/scsi/nvme: Add error codes for PR ops Mike Christie
2022-11-22 3:26 ` [PATCH v3 1/4] block: Add error codes for common PR failures Mike Christie
2022-11-22 3:26 ` [PATCH v3 2/4] scsi: Rename status_byte to sg_status_byte Mike Christie
2022-11-22 3:26 ` [PATCH v3 3/4] scsi: Convert SCSI errors to PR errors Mike Christie
2022-11-22 3:26 ` [PATCH v3 4/4] nvme: Convert NVMe " Mike Christie
2022-11-26 2:48 ` [PATCH v3 0/4] block/scsi/nvme: Add error codes for PR ops Martin K. Petersen
2022-11-29 4:18 ` Chaitanya Kulkarni [this message]
2022-11-29 13:28 ` hch
2022-11-29 14:00 ` Jens Axboe
2022-11-29 21:31 ` Mike Christie
2022-12-01 3:28 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538bcade-c453-e6f8-4530-808a9bf2140a@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=jejb@linux.ibm.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=michael.christie@oracle.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).