From: Mike Christie <michael.christie@oracle.com>
To: lduncan@suse.com, cleech@redhat.com, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org,
james.bottomley@hansenpartnership.com
Cc: lutianxiong@huawei.com, linfeilong@huawei.com,
liuzhiqiang26@huawei.com, haowenchao@huawei.com
Subject: Re: [PATCH 2/3] libiscsi: drop taskqueuelock
Date: Sat, 19 Dec 2020 16:18:36 -0600 [thread overview]
Message-ID: <568fe846-9b63-c9a0-8449-b401a93845ae@oracle.com> (raw)
In-Reply-To: <1608144943-4748-3-git-send-email-michael.christie@oracle.com>
On 12/16/20 12:55 PM, Mike Christie wrote:
> The purpose of the taskqueuelock was to handle the issue where a bad
> target decides to send a R2T and before it's data has been sent
> decides to send a cmd response to complete the cmd. The following
> patches fix up the frwd/back locks so they are taken from the
> queue/xmit (frwd) and completion (back) paths again. To get there
> this patch removes the taskqueuelock which for iscsi xmit wq based
> drivers was taken in the queue, xmit and completion paths.
>
> Instead of the lock, we just make sure we have a ref to the task
> when we queue a R2T, and then we always remove the task from the
> requeue list in the xmit path or the forced cleanup paths.
>
> Signed-off-by: Mike Christie<michael.christie@oracle.com>
Lee,
There is a bug in this patch. I'll resend a new version with some
fixes for other bugs I hit while testing.
next prev parent reply other threads:[~2020-12-19 22:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 18:55 [PATCH 0/3 V2] iscsi cmd lifetime fixups/cleanups Mike Christie
2020-12-16 18:55 ` [PATCH 1/3] libiscsi: fix iscsi_prep_scsi_cmd_pdu error handling Mike Christie
2020-12-16 18:55 ` [PATCH 2/3] libiscsi: drop taskqueuelock Mike Christie
2020-12-19 22:18 ` Mike Christie [this message]
2020-12-16 18:55 ` [PATCH 3/3] libiscsi: fix iscsi_task use after free Mike Christie
2020-12-17 17:49 ` Lee Duncan
-- strict thread matches above, loose matches on Subject: below --
2020-12-15 21:53 [PATCH 0/3] iscsi cmd lifetime fixups/cleanups Mike Christie
2020-12-15 21:53 ` [PATCH 2/3] libiscsi: drop taskqueuelock Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568fe846-9b63-c9a0-8449-b401a93845ae@oracle.com \
--to=michael.christie@oracle.com \
--cc=cleech@redhat.com \
--cc=haowenchao@huawei.com \
--cc=james.bottomley@hansenpartnership.com \
--cc=lduncan@suse.com \
--cc=linfeilong@huawei.com \
--cc=linux-scsi@vger.kernel.org \
--cc=liuzhiqiang26@huawei.com \
--cc=lutianxiong@huawei.com \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).