From: James Smart <james.smart@broadcom.com>
To: YueHaibing <yuehaibing@huawei.com>,
dick.kennedy@broadcom.com, jejb@linux.ibm.com,
martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] scsi: lpfc: Make lpfc_defer_acc_rsp static
Date: Tue, 7 Jan 2020 10:22:26 -0800 [thread overview]
Message-ID: <591891cb-81fd-777a-3a21-3fd24c8f7cc2@broadcom.com> (raw)
In-Reply-To: <20200107014956.41748-1-yuehaibing@huawei.com>
On 1/6/2020 5:49 PM, YueHaibing wrote:
> Fix sparse warning:
>
> drivers/scsi/lpfc/lpfc_nportdisc.c:344:1: warning:
> symbol 'lpfc_defer_acc_rsp' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/scsi/lpfc/lpfc_nportdisc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_nportdisc.c b/drivers/scsi/lpfc/lpfc_nportdisc.c
> index 1c46e3a..a024e5a 100644
> --- a/drivers/scsi/lpfc/lpfc_nportdisc.c
> +++ b/drivers/scsi/lpfc/lpfc_nportdisc.c
> @@ -340,7 +340,7 @@ lpfc_defer_pt2pt_acc(struct lpfc_hba *phba, LPFC_MBOXQ_t *link_mbox)
> * This routine is only called if we are SLI4, acting in target
> * mode and the remote NPort issues the PLOGI after link up.
> **/
> -void
> +static void
> lpfc_defer_acc_rsp(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmb)
> {
> struct lpfc_vport *vport = pmb->vport;
Yep. Looks good. Thank You
Reviewed-by: James Smart <james.smart@broadcom.com>
-- james
next prev parent reply other threads:[~2020-01-07 18:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 1:49 [PATCH -next] scsi: lpfc: Make lpfc_defer_acc_rsp static YueHaibing
2020-01-07 18:22 ` James Smart [this message]
2020-01-10 6:26 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=591891cb-81fd-777a-3a21-3fd24c8f7cc2@broadcom.com \
--to=james.smart@broadcom.com \
--cc=dick.kennedy@broadcom.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).