From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63841C433E2 for ; Wed, 16 Sep 2020 20:35:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 237B8206CA for ; Wed, 16 Sep 2020 20:35:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726908AbgIPUfz (ORCPT ); Wed, 16 Sep 2020 16:35:55 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:33188 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728389AbgIPUfy (ORCPT ); Wed, 16 Sep 2020 16:35:54 -0400 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 8138FC97797992C28F05; Wed, 16 Sep 2020 20:29:04 +0800 (CST) Received: from [10.174.178.248] (10.174.178.248) by smtp.huawei.com (10.3.19.210) with Microsoft SMTP Server (TLS) id 14.3.487.0; Wed, 16 Sep 2020 20:28:59 +0800 Subject: Re: [PATCH] scsi: esas2r: prevent a potential NULL dereference in esas2r_probe() To: "Martin K. Petersen" References: <20200909084653.79341-1-jingxiangfeng@huawei.com> CC: , , , From: Jing Xiangfeng Message-ID: <5F62050A.6060109@huawei.com> Date: Wed, 16 Sep 2020 20:28:58 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.248] X-CFilter-Loop: Reflected Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On 2020/9/16 5:44, Martin K. Petersen wrote: > > Jing, > >> esas2r_probe() calls scsi_host_put() in an error path. However, >> esas2r_log_dev() may hit a potential NULL dereference. So use NUll instead. > > Wouldn't it be better to move the scsi_host_put() call after the error > message? There is already a message before the scsi_host_put() call. It is used to record calling function. >