linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bean Huo <huobean@gmail.com>
To: Avri Altman <Avri.Altman@wdc.com>,
	"alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
	"asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
	"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
	"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
	"stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
	"beanhuo@micron.com" <beanhuo@micron.com>,
	"bvanassche@acm.org" <bvanassche@acm.org>,
	"tomas.winkler@intel.com" <tomas.winkler@intel.com>,
	"cang@codeaurora.org" <cang@codeaurora.org>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] scsi: ufs: Keep device power on only fWriteBoosterBufferFlushDuringHibernate == 1
Date: Thu, 03 Dec 2020 13:31:40 +0100	[thread overview]
Message-ID: <5b26c234d357512c0bffccf733d6ed8c5dd3a517.camel@gmail.com> (raw)
In-Reply-To: <DM6PR04MB65750B6EF8B374476E255FA7FCF20@DM6PR04MB6575.namprd04.prod.outlook.com>

On Thu, 2020-12-03 at 12:15 +0000, Avri Altman wrote:
> > so, you agree the possiblity of failure  exists.
> 
> I was more relating to the lottery part.
It doesn't matter. even the possibility of winning a lottery is very
low, but still there is.
> > 
> > > Hence we need-not any extra logic protecting device management
> > > command failures.
> > 
> > what extra logic?
> > 
> > > 
> > > if reading the configuration pass correctly, and UFSHCD_CAP_WB_EN
> > > is
> > > set,
> > 
> > 
> > UFSHCD_CAP_WB_EN set is DRAM level. still in the cache.
> > 
> > > one should expect that any other functionality would work.
> > > 
> > 
> > No,  The programming will consume more power than reading, the
> > later setting will more possbile fail than reading.
> > 
> > > Otherwise, any non-standard behavior should be added with a
> > > quirk.
> > > 
> > 
> > NO, this is not what is standard or non-standard. This is
> > independent
> > of UFS device/controller. It is a software design. IMO, we didn't
> > deal
> > with programming status that is a potential bug. If having to
> > impose to
> > a component, do you think should be controller or device? Instead
> > of
> > addin a quirk, I prefer dropping this patch.
> 
> It seems you are adding some special treatment in case some device
> management command failed,
> A vanishingly unlikely event but a one that has significant impact
> over power consumption.

again, there is nothing with device. Obviously, you didn't do system
reliability testing in harsh environment. you don't believe this is WB
driver bug. I will send my next version patch with a fix-tag. even It
cannot merge. but I want to highlight it is a bug.

Thanks,
Bean



  reply	other threads:[~2020-12-03 12:32 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-30 18:11 [PATCH 0/3] Three changes for UFS WriteBooster Bean Huo
2020-11-30 18:11 ` [PATCH 1/3] scsi: ufs: Add "wb_on" sysfs node to control WB on/off Bean Huo
2020-11-30 23:19   ` Asutosh Das (asd)
2020-12-02 16:20     ` Bean Huo
2020-12-02 17:58       ` Asutosh Das (asd)
2020-11-30 18:11 ` [PATCH 2/3] scsi: ufs: Keep device power on only fWriteBoosterBufferFlushDuringHibernate == 1 Bean Huo
     [not found]   ` <BY5PR04MB6599826730BD3FB0E547E60587F30@BY5PR04MB6599.namprd04.prod.outlook.com>
2020-12-03  7:27     ` Avri Altman
2020-12-03  9:36       ` Bean Huo
2020-12-03  9:40       ` Bean Huo
2020-12-03 10:46         ` Avri Altman
2020-12-03 11:45           ` Bean Huo
2020-12-03 12:15             ` Avri Altman
2020-12-03 12:31               ` Bean Huo [this message]
2020-12-04  3:26   ` Can Guo
2020-12-04  8:28     ` Bean Huo
2020-11-30 18:11 ` [PATCH 3/3] scsi: ufs: Changes comment in the function ufshcd_wb_probe() Bean Huo
2020-12-04  3:27   ` Can Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5b26c234d357512c0bffccf733d6ed8c5dd3a517.camel@gmail.com \
    --to=huobean@gmail.com \
    --cc=Avri.Altman@wdc.com \
    --cc=alim.akhtar@samsung.com \
    --cc=asutoshd@codeaurora.org \
    --cc=beanhuo@micron.com \
    --cc=bvanassche@acm.org \
    --cc=cang@codeaurora.org \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=stanley.chu@mediatek.com \
    --cc=tomas.winkler@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).