From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B79F5C433EF for ; Fri, 1 Apr 2022 09:32:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344603AbiDAJeZ (ORCPT ); Fri, 1 Apr 2022 05:34:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344602AbiDAJeW (ORCPT ); Fri, 1 Apr 2022 05:34:22 -0400 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 726AF26A97B for ; Fri, 1 Apr 2022 02:32:32 -0700 (PDT) Received: by mail-ej1-x635.google.com with SMTP id k23so1163887ejd.3 for ; Fri, 01 Apr 2022 02:32:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=nE3hf1YCDJ6kEtg0m/qHzL1wDrtyteiqpEI9iRcSgrQ=; b=TcuEH/WIfOzHMnHFSRp2Zwb4XlQ/993CuV0nXVA1JL+UbCwhDNejOZM4rPI3NUETGC amMumtiKJJQCuCMguDNVDc6wnshG6IUv98w5P+4HBfOoCfoKGFR+qAqPZU0adYJglOY6 2pGVg/PXvS8hEgu0c3ReL+61QBdslOLb36lMDO/jqm/brxE0X/pJk3qcs4faSt1AJp2q 6WgXceVU+5uLB8P0iOXuQjhlPPj3D1VSUqfuFuwa/aZ4/2t69vREQHfox31liOywyDK8 RQdpvNAE4pCXiEKOs7O+2r/uQliceyg1mE/d6dmrk2/RyPoKz+2zMtYzmWO6jwNB8cXU X0vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=nE3hf1YCDJ6kEtg0m/qHzL1wDrtyteiqpEI9iRcSgrQ=; b=zVi7LxyJ18eBlhrwh7gJR7wfDakFodaMNQzcPQLmfJQ0cXmYtiDqzl32KTbizjQTBG 87xra35dV2yJdRz8Go8LN2SmytzjzdmWBnTy3jJHvucUWBBkuxAofaAghTVD/R1pHwvm bVh4lmEk9Z6DYcVhnUGAMTZ+Yt13EhPP5NYprAeTU/b7paRdrGaeATb+Hrk2Uzn48hTS 2C0Lb/w/FgjakQzQjS2XCfc9xYDOk9HJ3UlonhUNt+UYwApqC3xF0pEm2jlacEFfSTFO ItoFnkp4fCnm06p410kf+H6BONCw9JeTV7lq0IM6ZxULaLqd+kPaxjkOJd+kIxeSHFbf ZoRg== X-Gm-Message-State: AOAM533uxCUxLireZExKfrWDdetqZSwmdCjX153sm2P3SVqow00+fJc+ McctKMKGmbej/YCk0+6T9+w= X-Google-Smtp-Source: ABdhPJwYKb3iUpDjX5SzkL7pBYHorH9bmbd3o+F+0IlrZGBiBTztGOafTpZGQb6nOveWOVQSiG8mnQ== X-Received: by 2002:a17:906:dc8f:b0:6e0:5ce7:d80e with SMTP id cs15-20020a170906dc8f00b006e05ce7d80emr8813745ejc.435.1648805550859; Fri, 01 Apr 2022 02:32:30 -0700 (PDT) Received: from ubuntu-laptop (p5dd1ed70.dip0.t-ipconnect.de. [93.209.237.112]) by smtp.googlemail.com with ESMTPSA id qa30-20020a170907869e00b006df9ff41154sm837560ejc.141.2022.04.01.02.32.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Apr 2022 02:32:30 -0700 (PDT) Message-ID: <60dc8a92c7eda8f190a8a6123bc927e8403bdbb1.camel@gmail.com> Subject: Re: [PATCH 00/29] UFS patches for kernel v5.19 From: Bean Huo To: Bart Van Assche , "Martin K . Petersen" , Can Guo Cc: Jaegeuk Kim , Adrian Hunter , linux-scsi@vger.kernel.org Date: Fri, 01 Apr 2022 11:32:30 +0200 In-Reply-To: <20220331223424.1054715-1-bvanassche@acm.org> References: <20220331223424.1054715-1-bvanassche@acm.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Bart, Agree that the current UFS driver is messy, but I don't think there was such a big structural change before UFS 4.0 was released, especially the design of the UFS CQE driver. If you already have a plan for CQE, it's best to state it in the patch. If you have made such a big change in an environment that is now very stable, do we have to make changes after UFS 4.0? ? Kind regards, Bean On Thu, 2022-03-31 at 15:33 -0700, Bart Van Assche wrote: > Hi Martin, > > This patch series includes the following changes: > - Separation of UFS core and UFS driver source code into separate > directories. > - Split the ufshcd.h header file into two header files - one file > that > defines the interface with UFS drivers and another file with > definitions > only used in the core. > - Multiple source code cleanup patches. > - A few patches with minor functional changes. > > Please consider these changes for kernel v5.19. > > Thank you, > > Bart. > > Bart Van Assche (29): > scsi: ufs: Declare ufshcd_wait_for_register() static > scsi: ufs: Remove superfluous boolean conversions > scsi: ufs: Simplify statements that return a boolean > scsi: ufs: Remove ufshcd_lrb.sense_bufflen > scsi: ufs: Remove ufshcd_lrb.sense_buffer > scsi: ufs: Use get_unaligned_be16() instead of be16_to_cpup() > scsi: ufs: Remove the UFS_FIX() and END_FIX() macros > scsi: ufs: Rename struct ufs_dev_fix into ufs_dev_quirk > scsi: ufs: Declare the quirks array const > scsi: ufs: Invert the return value of ufshcd_is_hba_active() > scsi: ufs: Remove unused constants and code > scsi: ufs: Switch to aggregate initialization > scsi: ufs: Remove the LUN quiescing code from ufshcd_wl_shutdown() > scsi: ufs: Make the config_scaling_param calls type safe > scsi: ufs: Remove the driver version > scsi: ufs: Rename sdev_ufs_device into ufs_device_wlun > scsi: ufs: Use an SPDX license identifier in the Kconfig file > scsi: ufs: Remove paths from source code comments > scsi: ufs: Remove the TRUE and FALSE definitions > scsi: ufs: Remove locking from around single register writes > scsi: ufs: Introduce ufshcd_clkgate_delay_set() > scsi: ufs: qcom: Fix ufs_qcom_resume() > scsi: ufs: Remove unnecessary ufshcd-crypto.h include directives > scsi: ufs: Fix kernel-doc syntax in ufshcd.h > scsi: ufs: Minimize #include directives > scsi: ufs: Split the ufshcd.h header file > scsi: ufs: Move the struct ufs_ref_clk definition > scsi: ufs: Move the ufs_is_valid_unit_desc_lun() definition > scsi: ufs: Split the drivers/scsi/ufs directory > > drivers/scsi/Kconfig | 3 +- > drivers/scsi/Makefile | 4 +- > drivers/scsi/ufs-core/Kconfig | 82 ++++ > drivers/scsi/ufs-core/Makefile | 10 + > drivers/scsi/{ufs => ufs-core}/ufs-debugfs.c | 4 +- > drivers/scsi/{ufs => ufs-core}/ufs-debugfs.h | 0 > .../{ufs => ufs-core}/ufs-fault-injection.c | 4 +- > .../{ufs => ufs-core}/ufs-fault-injection.h | 0 > drivers/scsi/{ufs => ufs-core}/ufs-hwmon.c | 4 +- > drivers/scsi/{ufs => ufs-core}/ufs-sysfs.c | 8 +- > drivers/scsi/{ufs => ufs-core}/ufs-sysfs.h | 3 +- > drivers/scsi/{ufs => ufs-core}/ufs_bsg.c | 6 + > drivers/scsi/{ufs => ufs-core}/ufs_bsg.h | 7 +- > .../scsi/{ufs => ufs-core}/ufshcd-crypto.c | 2 +- > .../scsi/{ufs => ufs-core}/ufshcd-crypto.h | 7 +- > drivers/scsi/ufs-core/ufshcd-priv.h | 296 ++++++++++++++ > drivers/scsi/{ufs => ufs-core}/ufshcd.c | 254 ++++++------ > drivers/scsi/{ufs => ufs-core}/ufshpb.c | 10 +- > drivers/scsi/{ufs => ufs-core}/ufshpb.h | 0 > drivers/scsi/ufs-drivers/Kconfig | 118 ++++++ > drivers/scsi/{ufs => ufs-drivers}/Makefile | 12 - > .../scsi/{ufs => ufs-drivers}/cdns-pltfrm.c | 5 +- > .../{ufs => ufs-drivers}/tc-dwc-g210-pci.c | 8 +- > .../{ufs => ufs-drivers}/tc-dwc-g210-pltfrm.c | 10 +- > .../scsi/{ufs => ufs-drivers}/tc-dwc-g210.c | 8 +- > .../scsi/{ufs => ufs-drivers}/tc-dwc-g210.h | 2 + > .../scsi/{ufs => ufs-drivers}/ti-j721e-ufs.c | 0 > .../scsi/{ufs => ufs-drivers}/ufs-exynos.c | 17 +- > .../scsi/{ufs => ufs-drivers}/ufs-exynos.h | 8 +- > drivers/scsi/{ufs => ufs-drivers}/ufs-hisi.c | 17 +- > drivers/scsi/{ufs => ufs-drivers}/ufs-hisi.h | 0 > .../{ufs => ufs-drivers}/ufs-mediatek-trace.h | 2 +- > .../scsi/{ufs => ufs-drivers}/ufs-mediatek.c | 40 +- > .../scsi/{ufs => ufs-drivers}/ufs-mediatek.h | 0 > .../scsi/{ufs => ufs-drivers}/ufs-qcom-ice.c | 3 +- > drivers/scsi/{ufs => ufs-drivers}/ufs-qcom.c | 49 +-- > drivers/scsi/{ufs => ufs-drivers}/ufs-qcom.h | 6 +- > .../scsi/{ufs => ufs-drivers}/ufshcd-dwc.c | 6 +- > .../scsi/{ufs => ufs-drivers}/ufshcd-dwc.h | 2 + > .../scsi/{ufs => ufs-drivers}/ufshcd-pci.c | 14 +- > .../scsi/{ufs => ufs-drivers}/ufshcd-pltfrm.c | 35 +- > .../scsi/{ufs => ufs-drivers}/ufshcd-pltfrm.h | 2 +- > .../scsi/{ufs => ufs-drivers}/ufshci-dwc.h | 0 > drivers/scsi/ufs/Kconfig | 211 ---------- > {drivers/scsi/ufs => include/scsi}/ufs.h | 35 -- > .../scsi/ufs => include/scsi}/ufs_quirks.h | 15 +- > {drivers/scsi/ufs => include/scsi}/ufshcd.h | 366 ++++---------- > ---- > {drivers/scsi/ufs => include/scsi}/ufshci.h | 2 + > {drivers/scsi/ufs => include/scsi}/unipro.h | 16 - > 49 files changed, 856 insertions(+), 857 deletions(-) > create mode 100644 drivers/scsi/ufs-core/Kconfig > create mode 100644 drivers/scsi/ufs-core/Makefile > rename drivers/scsi/{ufs => ufs-core}/ufs-debugfs.c (99%) > rename drivers/scsi/{ufs => ufs-core}/ufs-debugfs.h (100%) > rename drivers/scsi/{ufs => ufs-core}/ufs-fault-injection.c (100%) > rename drivers/scsi/{ufs => ufs-core}/ufs-fault-injection.h (100%) > rename drivers/scsi/{ufs => ufs-core}/ufs-hwmon.c (98%) > rename drivers/scsi/{ufs => ufs-core}/ufs-sysfs.c (99%) > rename drivers/scsi/{ufs => ufs-core}/ufs-sysfs.h (95%) > rename drivers/scsi/{ufs => ufs-core}/ufs_bsg.c (97%) > rename drivers/scsi/{ufs => ufs-core}/ufs_bsg.h (77%) > rename drivers/scsi/{ufs => ufs-core}/ufshcd-crypto.c (99%) > rename drivers/scsi/{ufs => ufs-core}/ufshcd-crypto.h (94%) > create mode 100644 drivers/scsi/ufs-core/ufshcd-priv.h > rename drivers/scsi/{ufs => ufs-core}/ufshcd.c (98%) > rename drivers/scsi/{ufs => ufs-core}/ufshpb.c (99%) > rename drivers/scsi/{ufs => ufs-core}/ufshpb.h (100%) > create mode 100644 drivers/scsi/ufs-drivers/Kconfig > rename drivers/scsi/{ufs => ufs-drivers}/Makefile (56%) > rename drivers/scsi/{ufs => ufs-drivers}/cdns-pltfrm.c (99%) > rename drivers/scsi/{ufs => ufs-drivers}/tc-dwc-g210-pci.c (98%) > rename drivers/scsi/{ufs => ufs-drivers}/tc-dwc-g210-pltfrm.c (98%) > rename drivers/scsi/{ufs => ufs-drivers}/tc-dwc-g210.c (99%) > rename drivers/scsi/{ufs => ufs-drivers}/tc-dwc-g210.h (95%) > rename drivers/scsi/{ufs => ufs-drivers}/ti-j721e-ufs.c (100%) > rename drivers/scsi/{ufs => ufs-drivers}/ufs-exynos.c (99%) > rename drivers/scsi/{ufs => ufs-drivers}/ufs-exynos.h (97%) > rename drivers/scsi/{ufs => ufs-drivers}/ufs-hisi.c (99%) > rename drivers/scsi/{ufs => ufs-drivers}/ufs-hisi.h (100%) > rename drivers/scsi/{ufs => ufs-drivers}/ufs-mediatek-trace.h (92%) > rename drivers/scsi/{ufs => ufs-drivers}/ufs-mediatek.c (97%) > rename drivers/scsi/{ufs => ufs-drivers}/ufs-mediatek.h (100%) > rename drivers/scsi/{ufs => ufs-drivers}/ufs-qcom-ice.c (99%) > rename drivers/scsi/{ufs => ufs-drivers}/ufs-qcom.c (98%) > rename drivers/scsi/{ufs => ufs-drivers}/ufs-qcom.h (98%) > rename drivers/scsi/{ufs => ufs-drivers}/ufshcd-dwc.c (98%) > rename drivers/scsi/{ufs => ufs-drivers}/ufshcd-dwc.h (95%) > rename drivers/scsi/{ufs => ufs-drivers}/ufshcd-pci.c (99%) > rename drivers/scsi/{ufs => ufs-drivers}/ufshcd-pltfrm.c (94%) > rename drivers/scsi/{ufs => ufs-drivers}/ufshcd-pltfrm.h (98%) > rename drivers/scsi/{ufs => ufs-drivers}/ufshci-dwc.h (100%) > delete mode 100644 drivers/scsi/ufs/Kconfig > rename {drivers/scsi/ufs => include/scsi}/ufs.h (93%) > rename {drivers/scsi/ufs => include/scsi}/ufs_quirks.h (94%) > rename {drivers/scsi/ufs => include/scsi}/ufshcd.h (82%) > rename {drivers/scsi/ufs => include/scsi}/ufshci.h (99%) > rename {drivers/scsi/ufs => include/scsi}/unipro.h (98%) >