From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68979C28CBC for ; Wed, 6 May 2020 13:42:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4970F206D5 for ; Wed, 6 May 2020 13:42:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728301AbgEFNml (ORCPT ); Wed, 6 May 2020 09:42:41 -0400 Received: from mx2.suse.de ([195.135.220.15]:53264 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725801AbgEFNmk (ORCPT ); Wed, 6 May 2020 09:42:40 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 93608AEA1; Wed, 6 May 2020 13:42:41 +0000 (UTC) Subject: Re: [PATCH v4 04/11] qla2xxx: Add more BUILD_BUG_ON() statements To: Bart Van Assche , "Martin K . Petersen" , "James E . J . Bottomley" Cc: linux-scsi@vger.kernel.org, Nilesh Javali , Himanshu Madhani , Quinn Tran , Martin Wilck , Daniel Wagner , Roman Bolshakov References: <20200427030310.19687-1-bvanassche@acm.org> <20200427030310.19687-5-bvanassche@acm.org> From: Hannes Reinecke Message-ID: <618d7104-e30d-8755-6111-5ec95e1e7133@suse.de> Date: Wed, 6 May 2020 15:42:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200427030310.19687-5-bvanassche@acm.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On 4/27/20 5:03 AM, Bart Van Assche wrote: > Before fixing the endianness annotations in data structures, make the > compiler verify the size of FC protocol and firmware data structures. > > Cc: Nilesh Javali > Cc: Himanshu Madhani > Cc: Quinn Tran > Cc: Martin Wilck > Cc: Daniel Wagner > Cc: Roman Bolshakov > Signed-off-by: Bart Van Assche > --- > drivers/scsi/qla2xxx/qla_os.c | 59 ++++++++++++++++++++++++++++++ > drivers/scsi/qla2xxx/tcm_qla2xxx.c | 14 +++++++ > 2 files changed, 73 insertions(+) > > diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c > index 497544413aa0..2dd9c2a39cd5 100644 > --- a/drivers/scsi/qla2xxx/qla_os.c > +++ b/drivers/scsi/qla2xxx/qla_os.c > @@ -7815,13 +7815,19 @@ qla2x00_module_init(void) > { > int ret = 0; > > + BUILD_BUG_ON(sizeof(cmd_a64_entry_t) != 64); > BUILD_BUG_ON(sizeof(cmd_entry_t) != 64); > BUILD_BUG_ON(sizeof(cont_a64_entry_t) != 64); > BUILD_BUG_ON(sizeof(cont_entry_t) != 64); > BUILD_BUG_ON(sizeof(init_cb_t) != 96); > + BUILD_BUG_ON(sizeof(mrk_entry_t) != 64); > BUILD_BUG_ON(sizeof(ms_iocb_entry_t) != 64); > BUILD_BUG_ON(sizeof(request_t) != 64); > + BUILD_BUG_ON(sizeof(struct abort_entry_24xx) != 64); > + BUILD_BUG_ON(sizeof(struct abort_iocb_entry_fx00) != 64); > + BUILD_BUG_ON(sizeof(struct abts_entry_24xx) != 64); > BUILD_BUG_ON(sizeof(struct access_chip_84xx) != 64); > + BUILD_BUG_ON(sizeof(struct access_chip_rsp_84xx) != 64); > BUILD_BUG_ON(sizeof(struct cmd_bidir) != 64); > BUILD_BUG_ON(sizeof(struct cmd_nvme) != 64); > BUILD_BUG_ON(sizeof(struct cmd_type_6) != 64); > @@ -7829,17 +7835,70 @@ qla2x00_module_init(void) > BUILD_BUG_ON(sizeof(struct cmd_type_7_fx00) != 64); > BUILD_BUG_ON(sizeof(struct cmd_type_crc_2) != 64); > BUILD_BUG_ON(sizeof(struct ct_entry_24xx) != 64); > + BUILD_BUG_ON(sizeof(struct ct_fdmi1_hba_attributes) != 2344); > + BUILD_BUG_ON(sizeof(struct ct_fdmi2_hba_attributes) != 4424); > + BUILD_BUG_ON(sizeof(struct ct_fdmi2_port_attributes) != 4164); > + BUILD_BUG_ON(sizeof(struct ct_fdmi_hba_attr) != 260); > + BUILD_BUG_ON(sizeof(struct ct_fdmi_port_attr) != 260); > + BUILD_BUG_ON(sizeof(struct ct_rsp_hdr) != 16); > + BUILD_BUG_ON(sizeof(struct ct_sns_req) != 4460); > BUILD_BUG_ON(sizeof(struct ctio_crc2_to_fw) != 64); > + BUILD_BUG_ON(sizeof(struct device_reg_24xx) != 256); > + BUILD_BUG_ON(sizeof(struct device_reg_25xxmq) != 24); > + BUILD_BUG_ON(sizeof(struct device_reg_2xxx) != 256); > + BUILD_BUG_ON(sizeof(struct device_reg_82xx) != 1288); > + BUILD_BUG_ON(sizeof(struct device_reg_fx00) != 216); > BUILD_BUG_ON(sizeof(struct els_entry_24xx) != 64); > + BUILD_BUG_ON(sizeof(struct els_sts_entry_24xx) != 64); > BUILD_BUG_ON(sizeof(struct fxdisc_entry_fx00) != 64); > + BUILD_BUG_ON(sizeof(struct imm_ntfy_from_isp) != 64); > BUILD_BUG_ON(sizeof(struct init_cb_24xx) != 128); > BUILD_BUG_ON(sizeof(struct init_cb_81xx) != 128); > + BUILD_BUG_ON(sizeof(struct logio_entry_24xx) != 64); > + BUILD_BUG_ON(sizeof(struct mbx_entry) != 64); > + BUILD_BUG_ON(sizeof(struct mid_init_cb_24xx) != 5252); > + BUILD_BUG_ON(sizeof(struct mrk_entry_24xx) != 64); > + BUILD_BUG_ON(sizeof(struct nvram_24xx) != 512); > + BUILD_BUG_ON(sizeof(struct nvram_81xx) != 512); > BUILD_BUG_ON(sizeof(struct pt_ls4_request) != 64); > + BUILD_BUG_ON(sizeof(struct pt_ls4_rx_unsol) != 64); > + BUILD_BUG_ON(sizeof(struct purex_entry_24xx) != 64); > + BUILD_BUG_ON(sizeof(struct qla2100_fw_dump) != 123634); > + BUILD_BUG_ON(sizeof(struct qla2300_fw_dump) != 136100); > + BUILD_BUG_ON(sizeof(struct qla24xx_fw_dump) != 37976); > + BUILD_BUG_ON(sizeof(struct qla25xx_fw_dump) != 39228); > + BUILD_BUG_ON(sizeof(struct qla2xxx_fce_chain) != 52); > + BUILD_BUG_ON(sizeof(struct qla2xxx_fw_dump) != 136172); > + BUILD_BUG_ON(sizeof(struct qla2xxx_mq_chain) != 524); > + BUILD_BUG_ON(sizeof(struct qla2xxx_mqueue_chain) != 8); > + BUILD_BUG_ON(sizeof(struct qla2xxx_mqueue_header) != 12); > + BUILD_BUG_ON(sizeof(struct qla2xxx_offld_chain) != 24); > + BUILD_BUG_ON(sizeof(struct qla81xx_fw_dump) != 39420); > + BUILD_BUG_ON(sizeof(struct qla82xx_uri_data_desc) != 28); > + BUILD_BUG_ON(sizeof(struct qla82xx_uri_table_desc) != 32); > + BUILD_BUG_ON(sizeof(struct qla83xx_fw_dump) != 51196); > + BUILD_BUG_ON(sizeof(struct qla_fdt_layout) != 128); > BUILD_BUG_ON(sizeof(struct qla_flt_header) != 8); > BUILD_BUG_ON(sizeof(struct qla_flt_region) != 16); > + BUILD_BUG_ON(sizeof(struct qla_npiv_entry) != 24); > + BUILD_BUG_ON(sizeof(struct qla_npiv_header) != 16); > + BUILD_BUG_ON(sizeof(struct rdp_rsp_payload) != 336); > BUILD_BUG_ON(sizeof(struct sns_cmd_pkt) != 2064); > + BUILD_BUG_ON(sizeof(struct sts_entry_24xx) != 64); > + BUILD_BUG_ON(sizeof(struct tsk_mgmt_entry) != 64); > + BUILD_BUG_ON(sizeof(struct tsk_mgmt_entry_fx00) != 64); > BUILD_BUG_ON(sizeof(struct verify_chip_entry_84xx) != 64); > + BUILD_BUG_ON(sizeof(struct verify_chip_rsp_84xx) != 52); > BUILD_BUG_ON(sizeof(struct vf_evfp_entry_24xx) != 56); > + BUILD_BUG_ON(sizeof(struct vp_config_entry_24xx) != 64); > + BUILD_BUG_ON(sizeof(struct vp_ctrl_entry_24xx) != 64); > + BUILD_BUG_ON(sizeof(struct vp_rpt_id_entry_24xx) != 64); > + BUILD_BUG_ON(sizeof(sts21_entry_t) != 64); > + BUILD_BUG_ON(sizeof(sts22_entry_t) != 64); > + BUILD_BUG_ON(sizeof(sts_cont_entry_t) != 64); > + BUILD_BUG_ON(sizeof(sts_entry_t) != 64); > + BUILD_BUG_ON(sizeof(sw_info_t) != 32); > + BUILD_BUG_ON(sizeof(target_id_t) != 2); > > /* Allocate cache for SRBs. */ > srb_cachep = kmem_cache_create("qla2xxx_srbs", sizeof(srb_t), 0, > diff --git a/drivers/scsi/qla2xxx/tcm_qla2xxx.c b/drivers/scsi/qla2xxx/tcm_qla2xxx.c > index 1f0a185b2a95..92e1a5d3928b 100644 > --- a/drivers/scsi/qla2xxx/tcm_qla2xxx.c > +++ b/drivers/scsi/qla2xxx/tcm_qla2xxx.c > @@ -1958,6 +1958,20 @@ static int __init tcm_qla2xxx_init(void) > { > int ret; > > + BUILD_BUG_ON(sizeof(struct abts_recv_from_24xx) != 64); > + BUILD_BUG_ON(sizeof(struct abts_resp_from_24xx_fw) != 64); > + BUILD_BUG_ON(sizeof(struct atio7_fcp_cmnd) != 32); > + BUILD_BUG_ON(sizeof(struct atio_from_isp) != 64); > + BUILD_BUG_ON(sizeof(struct ba_acc_le) != 12); > + BUILD_BUG_ON(sizeof(struct ba_rjt_le) != 4); > + BUILD_BUG_ON(sizeof(struct ctio7_from_24xx) != 64); > + BUILD_BUG_ON(sizeof(struct ctio7_to_24xx) != 64); > + BUILD_BUG_ON(sizeof(struct ctio_crc2_to_fw) != 64); > + BUILD_BUG_ON(sizeof(struct ctio_crc_from_fw) != 64); > + BUILD_BUG_ON(sizeof(struct ctio_to_2xxx) != 64); > + BUILD_BUG_ON(sizeof(struct fcp_hdr_le) != 24); > + BUILD_BUG_ON(sizeof(struct nack_to_isp) != 64); > + > ret = tcm_qla2xxx_register_configfs(); > if (ret < 0) > return ret; > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer