From: Martin Kepplinger <email@example.com> To: Alan Stern <firstname.lastname@example.org>, James Bottomley <James.Bottomley@hansenpartnership.com> Cc: Bart Van Assche <email@example.com>, Can Guo <firstname.lastname@example.org>, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org Subject: Re: [PATCH] scsi: sd: add runtime pm to open / release Date: Wed, 29 Jul 2020 17:52:57 +0200 Message-ID: <email@example.com> (raw) In-Reply-To: <20200729154056.GA1575761@rowland.harvard.edu> On 29.07.20 17:40, Alan Stern wrote: > On Wed, Jul 29, 2020 at 07:53:52AM -0700, James Bottomley wrote: >> On Wed, 2020-07-29 at 07:46 -0700, James Bottomley wrote: >>> On Wed, 2020-07-29 at 10:32 -0400, Alan Stern wrote: >>>> On Wed, Jul 29, 2020 at 04:12:22PM +0200, Martin Kepplinger wrote: >>>>> On 28.07.20 22:02, Alan Stern wrote: >>>>>> On Tue, Jul 28, 2020 at 09:02:44AM +0200, Martin Kepplinger >>>>>> wrote: >>>>>>> Hi Alan, >>>>>>> >>>>>>> Any API cleanup is of course welcome. I just wanted to remind >>>>>>> you that the underlying problem: broken block device runtime >>>>>>> pm. Your initial proposed fix "almost" did it and mounting >>>>>>> works but during file access, it still just looks like a >>>>>>> runtime_resume is missing somewhere. >>>>>> >>>>>> Well, I have tested that proposed fix several times, and on my >>>>>> system it's working perfectly. When I stop accessing a drive >>>>>> it autosuspends, and when I access it again it gets resumed and >>>>>> works -- as you would expect. >>>>> >>>>> that's weird. when I mount, everything looks good, "sda1". But as >>>>> soon as I cd to the mountpoint and do "ls" (on another SD card >>>>> "ls" works but actual file reading leads to the exact same >>>>> errors), I get: >>>>> >>>>> [ 77.474632] sd 0:0:0:0: [sda] tag#0 UNKNOWN(0x2003) Result: >>>>> hostbyte=0x00 driverbyte=0x08 cmd_age=0s >>>>> [ 77.474647] sd 0:0:0:0: [sda] tag#0 Sense Key : 0x6 [current] >>>>> [ 77.474655] sd 0:0:0:0: [sda] tag#0 ASC=0x28 ASCQ=0x0 >>>>> [ 77.474667] sd 0:0:0:0: [sda] tag#0 CDB: opcode=0x28 28 00 00 >>>>> 00 60 40 00 00 01 00 >>>> >>>> This error report comes from the SCSI layer, not the block layer. >>> >>> That sense code means "NOT READY TO READY CHANGE, MEDIUM MAY HAVE >>> CHANGED" so it sounds like it something we should be >>> ignoring. Usually this signals a problem, like you changed the >>> medium manually (ejected the CD). But in this case you can tell us >>> to expect this by setting >>> >>> sdev->expecting_cc_ua >>> >>> And we'll retry. I think you need to set this on all resumed >>> devices. >> >> Actually, it's not quite that easy, we filter out this ASC/ASCQ >> combination from the check because we should never ignore medium might >> have changed events on running devices. We could ignore it if we had a >> flag to say the power has been yanked (perhaps an additional sdev flag >> you set on resume) but we would still miss the case where you really >> had powered off the drive and then changed the media ... if you can >> regard this as the user's problem, then we might have a solution. > > Indeed, I was going to make the same point. > > The only reasonable conclusion is that suspending these SD card readers > isn't safe unless they don't contain a card -- or maybe just if the > device file isn't open or mounted. > > Although support for this sort of thing could be added to the kernel, > for now it's best to rely on userspace doing the right thing. The > kernel doesn't even know which devices suffer from this problem. > > well, userspace can do something like "automatically unmount if not used" but that is *way* more inefficient than if the kernel would support this is some way or another, for SD cards.
next prev parent reply index Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-23 11:10 Martin Kepplinger 2020-06-24 13:33 ` Bart Van Assche 2020-06-25 8:16 ` Martin Kepplinger 2020-06-25 14:52 ` Alan Stern 2020-06-26 3:53 ` Bart Van Assche 2020-06-26 15:07 ` Bart Van Assche 2020-06-26 15:44 ` Alan Stern 2020-06-28 2:37 ` Bart Van Assche 2020-06-28 13:10 ` Alan Stern 2020-06-29 9:42 ` Martin Kepplinger 2020-06-29 16:15 ` Alan Stern 2020-06-29 16:56 ` Bart Van Assche 2020-06-29 17:40 ` Alan Stern 2020-06-30 3:33 ` Martin Kepplinger 2020-06-30 13:38 ` Alan Stern 2020-06-30 15:59 ` Bart Van Assche 2020-06-30 18:02 ` Alan Stern 2020-06-30 19:23 ` Bart Van Assche 2020-06-30 19:38 ` Alan Stern 2020-06-30 23:31 ` Bart Van Assche 2020-07-01 0:49 ` Alan Stern 2020-07-06 16:41 ` Alan Stern 2020-07-28 7:02 ` Martin Kepplinger 2020-07-28 20:02 ` Alan Stern 2020-07-29 14:12 ` Martin Kepplinger 2020-07-29 14:32 ` Alan Stern 2020-07-29 14:44 ` Martin K. Petersen 2020-07-29 14:56 ` Alan Stern 2020-07-29 14:46 ` James Bottomley 2020-07-29 14:53 ` James Bottomley 2020-07-29 15:40 ` Martin Kepplinger 2020-07-29 15:44 ` James Bottomley 2020-07-29 16:43 ` Martin Kepplinger 2020-07-29 18:25 ` Alan Stern 2020-07-29 18:29 ` James Bottomley 2020-07-30 8:52 ` Martin Kepplinger 2020-07-30 8:54 ` Martin Kepplinger 2020-07-30 15:10 ` Alan Stern 2020-08-04 9:39 ` Martin Kepplinger 2020-08-07 9:51 ` Martin Kepplinger 2020-08-07 14:30 ` Alan Stern 2020-08-08 6:59 ` Martin Kepplinger 2020-08-08 15:05 ` Alan Stern 2020-08-09 9:20 ` Martin Kepplinger 2020-08-09 15:26 ` Alan Stern 2020-08-10 12:03 ` Martin Kepplinger 2020-08-10 14:13 ` Alan Stern 2020-08-11 7:55 ` Martin Kepplinger 2020-08-11 13:48 ` Alan Stern 2020-08-23 14:57 ` [PATCH] block: Fix bug in runtime-resume handling Alan Stern 2020-08-24 17:48 ` Bart Van Assche 2020-08-24 20:13 ` Alan Stern 2020-08-26 7:48 ` Martin Kepplinger 2020-08-27 17:42 ` Martin Kepplinger 2020-08-27 20:29 ` Alan Stern 2020-08-29 7:24 ` Martin Kepplinger 2020-08-29 15:26 ` Alan Stern 2020-08-29 16:33 ` Martin Kepplinger 2020-08-29 18:56 ` Alan Stern 2020-08-30 0:38 ` Bart Van Assche 2020-08-30 1:06 ` Alan Stern 2020-07-29 15:40 ` [PATCH] scsi: sd: add runtime pm to open / release Alan Stern 2020-07-29 15:49 ` James Bottomley 2020-07-29 16:17 ` Alan Stern 2020-07-29 15:52 ` Martin Kepplinger [this message] 2020-07-29 18:10 ` Douglas Gilbert 2020-07-30 8:05 ` Martin Kepplinger 2020-07-30 15:14 ` Alan Stern
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --cc=James.Bottomley@hansenpartnership.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-SCSI Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-scsi/0 linux-scsi/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-scsi linux-scsi/ https://lore.kernel.org/linux-scsi \ email@example.com public-inbox-index linux-scsi Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-scsi AGPL code for this site: git clone https://public-inbox.org/public-inbox.git